[patch] Bluetooth: fix breakage in amp_write_rem_assoc_frag()

[patch] Bluetooth: fix breakage in amp_write_rem_assoc_frag()

[Dan Carpenter]

We should be passing the pointer itself instead of the address of the
pointer.

This was a copy and paste bug when we replaced the calls to
hci_send_cmd().  Originally, the arguments were "len, cp" but we
overwrote them with "sizeof(cp), &cp" by mistake.

Fixes: b3d3914006a0 ('Bluetooth: Move amp assoc read/write completed callback to amp.c')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm pretty sure this is correct, but it's a static checker fix and I
haven't tested it.

diff --git a/net/bluetooth/amp.c b/net/bluetooth/amp.c
index 238ddd3..e32f341 100644
--- a/net/bluetooth/amp.c
+++ b/net/bluetooth/amp.c
@@ -379,7 +379,7 @@ static bool amp_write_rem_assoc_frag(struct hci_dev *hdev,
 	amp_ctrl_put(ctrl);
 
 	hci_req_init(&req, hdev);
-	hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, sizeof(cp), &cp);
+	hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, len, cp);
 	hci_req_run_skb(&req, write_remote_amp_assoc_complete);
 
 	kfree(cp);

[patch] Bluetooth: fix breakage in amp_write_rem_assoc_frag()

[Dan Carpenter]

We should be passing the pointer itself instead of the address of the
pointer.

This was a copy and paste bug when we replaced the calls to
hci_send_cmd().  Originally, the arguments were "len, cp" but we
overwrote them with "sizeof(cp), &cp" by mistake.

Fixes: b3d3914006a0 ('Bluetooth: Move amp assoc read/write completed callback to amp.c')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm pretty sure this is correct, but it's a static checker fix and I
haven't tested it.

diff --git a/net/bluetooth/amp.c b/net/bluetooth/amp.c
index 238ddd3..e32f341 100644
--- a/net/bluetooth/amp.c
+++ b/net/bluetooth/amp.c
@@ -379,7 +379,7 @@ static bool amp_write_rem_assoc_frag(struct hci_dev *hdev,
 	amp_ctrl_put(ctrl);
 
 	hci_req_init(&req, hdev);
-	hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, sizeof(cp), &cp);
+	hci_req_add(&req, HCI_OP_WRITE_REMOTE_AMP_ASSOC, len, cp);
 	hci_req_run_skb(&req, write_remote_amp_assoc_complete);
 
 	kfree(cp);

Re: [patch] Bluetooth: fix breakage in amp_write_rem_assoc_frag()

[Marcel Holtmann]

Hi Dan,

> We should be passing the pointer itself instead of the address of the
> pointer.
> 
> This was a copy and paste bug when we replaced the calls to
> hci_send_cmd().  Originally, the arguments were "len, cp" but we
> overwrote them with "sizeof(cp), &cp" by mistake.
> 
> Fixes: b3d3914006a0 ('Bluetooth: Move amp assoc read/write completed callback to amp.c')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I'm pretty sure this is correct, but it's a static checker fix and I
> haven't tested it.

it is correct and patch has been applied to bluetooth-next tree.

Regards

Marcel

Re: [patch] Bluetooth: fix breakage in amp_write_rem_assoc_frag()

[Marcel Holtmann]

Hi Dan,

> We should be passing the pointer itself instead of the address of the
> pointer.
> 
> This was a copy and paste bug when we replaced the calls to
> hci_send_cmd().  Originally, the arguments were "len, cp" but we
> overwrote them with "sizeof(cp), &cp" by mistake.
> 
> Fixes: b3d3914006a0 ('Bluetooth: Move amp assoc read/write completed callback to amp.c')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I'm pretty sure this is correct, but it's a static checker fix and I
> haven't tested it.

it is correct and patch has been applied to bluetooth-next tree.

Regards

Marcel