From: H Hartley Sweeten <hartleys-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org> To: Mika Westerberg <mika.westerberg-X3B1VOXEql0@public.gmane.org>, "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" <spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH v2 2/3] ep93xx: added chip revision reading function Date: Thu, 18 Mar 2010 12:27:15 -0500 [thread overview] Message-ID: <0D753D10438DA54287A00B02708426976368AC725D@AUSP01VMBX24.collaborationhost.net> (raw) In-Reply-To: <c222c3df9c94d9ec919817f640a953e4f45ae99b.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org> On Thursday, March 18, 2010 10:00 AM, Mika Westerberg wrote: > Added a new function: ep93xx_chip_revision() which reads chip revision from the > sysconfig register. > > Signed-off-by: Mika Westerberg <mika.westerberg-X3B1VOXEql0@public.gmane.org> Hello Mika, I'm ok with this part of your patch series. Acked-by: H Hartley Sweeten <hsweeten-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org> > --- > arch/arm/mach-ep93xx/core.c | 14 ++++++++++++++ > arch/arm/mach-ep93xx/include/mach/platform.h | 8 ++++++++ > 2 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c > index 90fb591..07572bb 100644 > --- a/arch/arm/mach-ep93xx/core.c > +++ b/arch/arm/mach-ep93xx/core.c > @@ -222,6 +222,20 @@ void ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int clear_bits) > } > EXPORT_SYMBOL(ep93xx_devcfg_set_clear); > > +/** > + * ep93xx_chip_revision() - returns the EP93xx chip revision > + * > + * See <mach/platform.h> for more information. > + */ > +unsigned int ep93xx_chip_revision(void) > +{ > + unsigned int v; > + > + v = __raw_readl(EP93XX_SYSCON_SYSCFG); > + v &= EP93XX_SYSCON_SYSCFG_REV_MASK; > + v >>= EP93XX_SYSCON_SYSCFG_REV_SHIFT; > + return v; > +} > > /************************************************************************* > * EP93xx peripheral handling > diff --git a/arch/arm/mach-ep93xx/include/mach/platform.h b/arch/arm/mach-ep93xx/include/mach/platform.h > index c6dc14d..b663390 100644 > --- a/arch/arm/mach-ep93xx/include/mach/platform.h > +++ b/arch/arm/mach-ep93xx/include/mach/platform.h > @@ -33,6 +33,14 @@ static inline void ep93xx_devcfg_clear_bits(unsigned int bits) > ep93xx_devcfg_set_clear(0x00, bits); > } > > +#define EP93XX_CHIP_REV_D0 3 > +#define EP93XX_CHIP_REV_D1 4 > +#define EP93XX_CHIP_REV_E0 5 > +#define EP93XX_CHIP_REV_E1 6 > +#define EP93XX_CHIP_REV_E2 7 > + > +unsigned int ep93xx_chip_revision(void); > + > void ep93xx_register_eth(struct ep93xx_eth_data *data, int copy_addr); > void ep93xx_register_i2c(struct i2c_gpio_platform_data *data, > struct i2c_board_info *devices, int num); ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
WARNING: multiple messages have this Message-ID (diff)
From: hartleys@visionengravers.com (H Hartley Sweeten) To: linux-arm-kernel@lists.infradead.org Subject: [spi-devel-general] [PATCH v2 2/3] ep93xx: added chip revision reading function Date: Thu, 18 Mar 2010 12:27:15 -0500 [thread overview] Message-ID: <0D753D10438DA54287A00B02708426976368AC725D@AUSP01VMBX24.collaborationhost.net> (raw) In-Reply-To: <c222c3df9c94d9ec919817f640a953e4f45ae99b.1268930557.git.mika.westerberg@iki.fi> On Thursday, March 18, 2010 10:00 AM, Mika Westerberg wrote: > Added a new function: ep93xx_chip_revision() which reads chip revision from the > sysconfig register. > > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi> Hello Mika, I'm ok with this part of your patch series. Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> > --- > arch/arm/mach-ep93xx/core.c | 14 ++++++++++++++ > arch/arm/mach-ep93xx/include/mach/platform.h | 8 ++++++++ > 2 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c > index 90fb591..07572bb 100644 > --- a/arch/arm/mach-ep93xx/core.c > +++ b/arch/arm/mach-ep93xx/core.c > @@ -222,6 +222,20 @@ void ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int clear_bits) > } > EXPORT_SYMBOL(ep93xx_devcfg_set_clear); > > +/** > + * ep93xx_chip_revision() - returns the EP93xx chip revision > + * > + * See <mach/platform.h> for more information. > + */ > +unsigned int ep93xx_chip_revision(void) > +{ > + unsigned int v; > + > + v = __raw_readl(EP93XX_SYSCON_SYSCFG); > + v &= EP93XX_SYSCON_SYSCFG_REV_MASK; > + v >>= EP93XX_SYSCON_SYSCFG_REV_SHIFT; > + return v; > +} > > /************************************************************************* > * EP93xx peripheral handling > diff --git a/arch/arm/mach-ep93xx/include/mach/platform.h b/arch/arm/mach-ep93xx/include/mach/platform.h > index c6dc14d..b663390 100644 > --- a/arch/arm/mach-ep93xx/include/mach/platform.h > +++ b/arch/arm/mach-ep93xx/include/mach/platform.h > @@ -33,6 +33,14 @@ static inline void ep93xx_devcfg_clear_bits(unsigned int bits) > ep93xx_devcfg_set_clear(0x00, bits); > } > > +#define EP93XX_CHIP_REV_D0 3 > +#define EP93XX_CHIP_REV_D1 4 > +#define EP93XX_CHIP_REV_E0 5 > +#define EP93XX_CHIP_REV_E1 6 > +#define EP93XX_CHIP_REV_E2 7 > + > +unsigned int ep93xx_chip_revision(void); > + > void ep93xx_register_eth(struct ep93xx_eth_data *data, int copy_addr); > void ep93xx_register_i2c(struct i2c_gpio_platform_data *data, > struct i2c_board_info *devices, int num);
next prev parent reply other threads:[~2010-03-18 17:27 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-18 16:59 [PATCH v2 0/3] spi: driver for Cirrus EP93xx SPI controller Mika Westerberg 2010-03-18 16:59 ` Mika Westerberg [not found] ` <cover.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org> 2010-03-18 17:00 ` [PATCH v2 1/3] spi: implemented " Mika Westerberg 2010-03-18 17:00 ` Mika Westerberg [not found] ` <c222c3df9c94d9ec919817f640a953e4f45ae99b.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org> 2010-03-18 17:00 ` [PATCH v2 3/3] ep93xx: SPI driver platform support code Mika Westerberg 2010-03-18 17:00 ` Mika Westerberg 2010-03-18 17:27 ` H Hartley Sweeten [this message] 2010-03-18 17:27 ` [spi-devel-general] [PATCH v2 2/3] ep93xx: added chip revision reading function H Hartley Sweeten [not found] ` <0D753D10438DA54287A00B02708426976368AC725D-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org> 2010-03-25 9:06 ` Mika Westerberg 2010-03-25 9:06 ` [spi-devel-general] " Mika Westerberg [not found] ` <20100325090638.GA20512-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> 2010-03-25 17:20 ` H Hartley Sweeten 2010-03-25 17:20 ` [spi-devel-general] " H Hartley Sweeten [not found] ` <0D753D10438DA54287A00B02708426976368F66FD1-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org> 2010-03-26 15:40 ` Martin Guy 2010-03-26 15:40 ` [spi-devel-general] " Martin Guy [not found] ` <9de3769ae253830fb0eebc98d299137c59c69b8c.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org> 2010-03-18 17:00 ` Mika Westerberg 2010-03-18 17:00 ` Mika Westerberg 2010-03-20 18:07 ` Martin Guy 2010-03-20 18:25 ` Daniel Mack 2010-03-20 18:40 ` Martin Guy 2010-03-20 19:31 ` H Hartley Sweeten 2010-03-20 19:48 ` Martin Guy 2010-03-20 18:31 ` Mika Westerberg 2010-03-20 19:42 ` H Hartley Sweeten 2010-03-21 18:45 ` Mika Westerberg 2010-03-25 13:49 ` [PATCH v2 1/3] spi: implemented driver for Cirrus EP93xx SPI controller Martin Guy 2010-03-25 13:49 ` Martin Guy [not found] ` <56d259a01003250649ubf0e32ejc15e4f3b45ec43cd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-03-25 18:43 ` Mika Westerberg 2010-03-25 18:43 ` Mika Westerberg [not found] ` <20100325184316.GB20512-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> 2010-04-01 0:15 ` Martin Guy 2010-04-01 0:15 ` Martin Guy [not found] ` <s2n56d259a01003311715ke5b93a96v9d453ec32f08ec29-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-04-01 3:00 ` Ryan Mallon 2010-04-01 3:00 ` Ryan Mallon 2010-04-01 6:26 ` Mika Westerberg 2010-04-01 6:26 ` Mika Westerberg 2010-04-06 5:44 ` Mika Westerberg 2010-04-06 5:44 ` Mika Westerberg [not found] ` <20100406054418.GA27465-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> 2010-04-06 12:50 ` Martin Guy 2010-04-06 12:50 ` Martin Guy [not found] ` <s2g56d259a01004060550me72bd64cr35e4a83c495d6909-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-04-06 18:18 ` Mika Westerberg 2010-04-06 18:18 ` Mika Westerberg [not found] ` <20100406181839.GA2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> 2010-04-06 21:28 ` Martin Guy 2010-04-06 21:28 ` Martin Guy [not found] ` <x2r56d259a01004061428raffb32e9o1d42570c79c0ee56-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-04-09 17:56 ` Martin Guy 2010-04-09 17:56 ` Martin Guy [not found] ` <l2j56d259a01004091056i91598adub4201b47c4a86a90-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-04-09 18:08 ` Martin Guy 2010-04-09 18:08 ` Martin Guy 2010-04-10 15:54 ` Mika Westerberg 2010-04-10 15:54 ` Mika Westerberg [not found] ` <20100410155443.GG2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> 2010-04-11 14:24 ` Martin Guy 2010-04-11 14:24 ` Martin Guy 2010-04-12 10:03 ` Martin Guy 2010-04-12 10:03 ` Martin Guy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0D753D10438DA54287A00B02708426976368AC725D@AUSP01VMBX24.collaborationhost.net \ --to=hartleys-3ff4nkcrg1de2c76skzgb0eocmrvltnr@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mika.westerberg-X3B1VOXEql0@public.gmane.org \ --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.