From: Khalid Masum <khalid.masum.92@gmail.com> To: Hawkins Jiawei <yin31149@gmail.com>, dan.carpenter@oracle.com Cc: davem@davemloft.net, dhowells@redhat.com, edumazet@google.com, kuba@kernel.org, linux-afs@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, pabeni@redhat.com, paskripkin@gmail.com, syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, yin31149@gmail.com Subject: Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg Date: Mon, 22 Aug 2022 22:00:37 +0600 [thread overview] Message-ID: <0ED076C1-6250-43EA-A7BE-948DFAEE851A@gmail.com> (raw) In-Reply-To: <20220822153944.6204-1-yin31149@gmail.com> On August 22, 2022 9:39:43 PM GMT+06:00, Hawkins Jiawei <yin31149@gmail.com> wrote: >On Mon, 22 Aug 2022 at 22:06, Dan Carpenter <dan.carpenter@oracle.com> wrote: >I trid this before, it doesn't work as Dan points out. I think >it seems that mutex_is_locked() only checks whether there is a task I see. >holding the mutex, but do not check whether it is current task holding >mutex. I also tried lockdep_is_held(), lockdep_is_held() seems can detect Ok. >call->user_mutex is still held accurately, although this cannot be the patch. Useful to know! Thanks for the information. -- Khalid Masum
WARNING: multiple messages have this Message-ID (diff)
From: Khalid Masum <khalid.masum.92@gmail.com> To: Hawkins Jiawei <yin31149@gmail.com>, dan.carpenter@oracle.com Cc: netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, dhowells@redhat.com, syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com, edumazet@google.com, yin31149@gmail.com, paskripkin@gmail.com, marc.dionne@auristor.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel-mentees@lists.linuxfoundation.org, davem@davemloft.net Subject: Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg Date: Mon, 22 Aug 2022 22:00:37 +0600 [thread overview] Message-ID: <0ED076C1-6250-43EA-A7BE-948DFAEE851A@gmail.com> (raw) In-Reply-To: <20220822153944.6204-1-yin31149@gmail.com> On August 22, 2022 9:39:43 PM GMT+06:00, Hawkins Jiawei <yin31149@gmail.com> wrote: >On Mon, 22 Aug 2022 at 22:06, Dan Carpenter <dan.carpenter@oracle.com> wrote: >I trid this before, it doesn't work as Dan points out. I think >it seems that mutex_is_locked() only checks whether there is a task I see. >holding the mutex, but do not check whether it is current task holding >mutex. I also tried lockdep_is_held(), lockdep_is_held() seems can detect Ok. >call->user_mutex is still held accurately, although this cannot be the patch. Useful to know! Thanks for the information. -- Khalid Masum _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-08-22 16:01 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-10 10:37 [syzbot] WARNING: bad unlock balance in rxrpc_do_sendmsg syzbot 2022-08-21 12:57 ` [PATCH] rxrpc: fix " Hawkins Jiawei 2022-08-21 12:57 ` Hawkins Jiawei 2022-08-21 15:58 ` Khalid Masum 2022-08-21 15:58 ` Khalid Masum 2022-08-21 16:42 ` Khalid Masum 2022-08-21 16:42 ` Khalid Masum 2022-08-22 5:19 ` Hawkins Jiawei 2022-08-22 5:19 ` Hawkins Jiawei 2022-08-21 19:17 ` [syzbot] WARNING: " Khalid Masum 2022-08-21 19:17 ` Khalid Masum 2022-08-21 22:29 ` syzbot 2022-08-21 22:29 ` syzbot 2022-08-22 8:48 ` [PATCH] rxrpc: fix " David Howells 2022-08-22 8:48 ` David Howells 2022-08-22 9:21 ` David Howells 2022-08-22 9:21 ` David Howells 2022-08-22 11:29 ` Hawkins Jiawei 2022-08-22 11:29 ` Hawkins Jiawei 2022-08-22 11:29 ` Hawkins Jiawei 2022-08-22 11:29 ` Hawkins Jiawei 2022-08-22 13:04 ` Hawkins Jiawei 2022-08-22 13:04 ` Hawkins Jiawei 2022-08-22 13:44 ` Dan Carpenter 2022-08-22 13:44 ` Dan Carpenter 2022-08-22 13:55 ` Khalid Masum 2022-08-22 13:55 ` Khalid Masum 2022-08-22 14:05 ` Dan Carpenter 2022-08-22 14:05 ` Dan Carpenter 2022-08-22 15:39 ` Hawkins Jiawei 2022-08-22 15:39 ` Hawkins Jiawei 2022-08-22 16:00 ` Khalid Masum [this message] 2022-08-22 16:00 ` Khalid Masum 2022-08-22 14:24 ` [syzbot] WARNING: " David Howells 2022-08-22 15:45 ` David Howells 2022-08-22 16:23 ` syzbot 2022-08-24 16:30 ` Marc Dionne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ED076C1-6250-43EA-A7BE-948DFAEE851A@gmail.com \ --to=khalid.masum.92@gmail.com \ --cc=dan.carpenter@oracle.com \ --cc=davem@davemloft.net \ --cc=dhowells@redhat.com \ --cc=edumazet@google.com \ --cc=kuba@kernel.org \ --cc=linux-afs@lists.infradead.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.dionne@auristor.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=paskripkin@gmail.com \ --cc=syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com \ --cc=syzkaller-bugs@googlegroups.com \ --cc=yin31149@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.