* [PATCH v3 0/2] Adjustments in function call
@ 2019-10-20 21:25 Javier F. Arias
2019-10-20 21:27 ` [PATCH v3 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
2019-10-20 21:32 ` [PATCH v3 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
0 siblings, 2 replies; 3+ messages in thread
From: Javier F. Arias @ 2019-10-20 21:25 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
This patchset fixes a warning and simplify a boolean expression in a
function call.
V2: Update the message of the second commit to include the updated
patch version and to use the Suggested-By tag.
V3: Update the first commit to include the Suggested-By tag and
the second commit to update the patch version.
Javier F. Arias (2):
staging: rtl8723bs: Fix line over 80 characters
staging: rtl8723bs: Simplify boolean expression
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] staging: rtl8723bs: Fix line over 80 characters
2019-10-20 21:25 [PATCH v3 0/2] Adjustments in function call Javier F. Arias
@ 2019-10-20 21:27 ` Javier F. Arias
2019-10-20 21:32 ` [PATCH v3 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
1 sibling, 0 replies; 3+ messages in thread
From: Javier F. Arias @ 2019-10-20 21:27 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Fix line over 80 characters by wrapping arguments in function call.
Suggested-by: Julia Lawall <julia.lawall@lip6.fr>.
Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
Changes in V2:
- Edit the commit message to use the Suggested-by tag.
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index c514cb735afd..0c2f3b2d4326 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -188,7 +188,9 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
bBtDisabled = hal_btcoex_IsBtDisabled(Adapter);
- ODM_CmnInfoUpdate(&pHalData->odmpriv, ODM_CMNINFO_BT_ENABLED, ((bBtDisabled == true)?false:true));
+ ODM_CmnInfoUpdate(&pHalData->odmpriv,
+ ODM_CMNINFO_BT_ENABLED,
+ ((bBtDisabled == true)?false:true));
ODM_DMWatchdog(&pHalData->odmpriv);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] staging: rtl8723bs: Simplify boolean expression
2019-10-20 21:25 [PATCH v3 0/2] Adjustments in function call Javier F. Arias
2019-10-20 21:27 ` [PATCH v3 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
@ 2019-10-20 21:32 ` Javier F. Arias
1 sibling, 0 replies; 3+ messages in thread
From: Javier F. Arias @ 2019-10-20 21:32 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Simplify expression that it's inverting a boolean value.
Issue found by Coccinelle.
Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
Changes in V2:
- Remove the parentheses around the variable.
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
index 0c2f3b2d4326..6f341d52afb6 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c
@@ -190,7 +190,7 @@ void rtl8723b_HalDmWatchDog(struct adapter *Adapter)
ODM_CmnInfoUpdate(&pHalData->odmpriv,
ODM_CMNINFO_BT_ENABLED,
- ((bBtDisabled == true)?false:true));
+ !bBtDisabled);
ODM_DMWatchdog(&pHalData->odmpriv);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-20 21:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-20 21:25 [PATCH v3 0/2] Adjustments in function call Javier F. Arias
2019-10-20 21:27 ` [PATCH v3 1/2] staging: rtl8723bs: Fix line over 80 characters Javier F. Arias
2019-10-20 21:32 ` [PATCH v3 2/2] staging: rtl8723bs: Simplify boolean expression Javier F. Arias
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.