All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Filipe Laíns" <lains@riseup.net>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming
Date: Sat, 30 Jan 2021 21:27:44 +0100	[thread overview]
Message-ID: <0a3aa6fb-3f22-d6f5-1748-42430f6e7ccc@redhat.com> (raw)
In-Reply-To: <265604c19e2e875ca17e4cf713000492b9ffd8d8.camel@riseup.net>

Hi,

On 1/30/21 8:14 PM, Filipe Laíns wrote:
> Hans,
> 
> You added support for non unifying receivers in
> 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure
> this cause any breakage with your devices?
> 
> AFAIK, they could only break if they have a 0x01 report which is different from
> kbd_descriptor.

I don't have any receivers hitting the "case 7" which you are modifying,
so I don't expect to see any effects of this change on my hw.

Regards,

Hans


  parent reply	other threads:[~2021-01-30 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 19:10 [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming Filipe Laíns
2021-01-30 19:14 ` Filipe Laíns
2021-01-30 19:29   ` Filipe Laíns
2021-01-30 20:27   ` Hans de Goede [this message]
2021-01-30 20:40     ` Filipe Laíns
2021-02-05  9:18 ` Jiri Kosina
2021-02-05 14:36   ` Filipe Laíns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a3aa6fb-3f22-d6f5-1748-42430f6e7ccc@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=lains@riseup.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.