From: Jiri Kosina <jikos@kernel.org>
To: "Filipe Laíns" <lains@archlinux.org>
Cc: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Filipe Laíns" <lains@riseup.net>
Subject: Re: [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming
Date: Fri, 5 Feb 2021 10:18:57 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2102051018370.28696@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210130191027.1225465-1-lains@archlinux.org>
On Sat, 30 Jan 2021, Filipe Laíns wrote:
> From: Filipe Laíns <lains@riseup.net>
>
> In e400071a805d6229223a98899e9da8c6233704a1 I added support for the
> receiver that comes with the G602 device, but unfortunately I screwed up
> during testing and it seems the keyboard events were actually not being
> sent to userspace.
> This resulted in keyboard events being broken in userspace, please
> backport the fix.
>
> The receiver uses the normal 0x01 Logitech keyboard report descriptor,
> as expected, so it is just a matter of flagging it as supported.
>
> Reported in
> https://github.com/libratbag/libratbag/issues/1124
>
> Signed-off-by: Filipe Laíns <lains@riseup.net>
Given this is a regression, could you please add proper Fixes: and Cc:
stable tags?
Thank you,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-02-05 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 19:10 [PATCH] HID: logitech-dj: add support for keyboard events in eQUAD step 4 Gaming Filipe Laíns
2021-01-30 19:14 ` Filipe Laíns
2021-01-30 19:29 ` Filipe Laíns
2021-01-30 20:27 ` Hans de Goede
2021-01-30 20:40 ` Filipe Laíns
2021-02-05 9:18 ` Jiri Kosina [this message]
2021-02-05 14:36 ` Filipe Laíns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2102051018370.28696@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=lains@archlinux.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.