All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Obbard <chris.obbard@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marc Zyngier <maz@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588 boards
Date: Mon, 09 Jan 2023 14:27:21 +0000	[thread overview]
Message-ID: <0a3c520c75dcfe6ff86e96aa18fc5b52ce1e3f30.camel@collabora.com> (raw)
In-Reply-To: <20230107002854.2kok76qdvl4a3hzw@mercury.elektranox.org>

> 
> 
Hi Sebastian,

> > To better match other boards from this vendor (e.g. RADXA ROCK 4)
> > 
> > would it be best to capitalise this (and obviously the model field
> > in
> > the respective DTS patches) the same?
> > 
> > So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".
> > 
> > It's also capitalised this way on the documentation website [1].
> > 
> > (I think the vendor has specifically dropped the Pi reference from
> > these boards, but I don't know why)
> > 
> > Thanks!
> > Chris
> > 
> > [1]: https://wiki.radxa.com/Rock5/5B
> 
> The current format has been requested by Radxa:
> 
> https://lore.kernel.org/all/892CB3E963AEF095+eaed7498-2324-9476-6a24-f940d62adb74@radxa.com/
> 

The comment there suggests to use "Radxa ROCK 5 Model A" and "Radxa
ROCK 5 Model B", so can we make the following changes before the next
revision, to align on the model names?

PS. I think "board" is a terrible suffix, it's almost like when people
say "PCB Board". But maybe I am missing some historical context here ?


- Patch 4: "description: Radxa Rock 5 Model A" > "description: Radxa
ROCK 5 Model A"
- Patch 4: "description: Radxa Rock 5 Model B" > "description: Radxa
ROCK 5 Model B"
- Patch 6: "Radxa Rock 5A Board" > "Radxa ROCK 5 Model A"
- Patch 7: "Radxa Rock 5B Board" > "Radxa ROCK 5 Model B"


Thanks!
Chris

WARNING: multiple messages have this Message-ID (diff)
From: Christopher Obbard <chris.obbard@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marc Zyngier <maz@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	 linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, kernel@collabora.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588 boards
Date: Mon, 09 Jan 2023 14:27:21 +0000	[thread overview]
Message-ID: <0a3c520c75dcfe6ff86e96aa18fc5b52ce1e3f30.camel@collabora.com> (raw)
In-Reply-To: <20230107002854.2kok76qdvl4a3hzw@mercury.elektranox.org>

> 
> 
Hi Sebastian,

> > To better match other boards from this vendor (e.g. RADXA ROCK 4)
> > 
> > would it be best to capitalise this (and obviously the model field
> > in
> > the respective DTS patches) the same?
> > 
> > So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".
> > 
> > It's also capitalised this way on the documentation website [1].
> > 
> > (I think the vendor has specifically dropped the Pi reference from
> > these boards, but I don't know why)
> > 
> > Thanks!
> > Chris
> > 
> > [1]: https://wiki.radxa.com/Rock5/5B
> 
> The current format has been requested by Radxa:
> 
> https://lore.kernel.org/all/892CB3E963AEF095+eaed7498-2324-9476-6a24-f940d62adb74@radxa.com/
> 

The comment there suggests to use "Radxa ROCK 5 Model A" and "Radxa
ROCK 5 Model B", so can we make the following changes before the next
revision, to align on the model names?

PS. I think "board" is a terrible suffix, it's almost like when people
say "PCB Board". But maybe I am missing some historical context here ?


- Patch 4: "description: Radxa Rock 5 Model A" > "description: Radxa
ROCK 5 Model A"
- Patch 4: "description: Radxa Rock 5 Model B" > "description: Radxa
ROCK 5 Model B"
- Patch 6: "Radxa Rock 5A Board" > "Radxa ROCK 5 Model A"
- Patch 7: "Radxa Rock 5B Board" > "Radxa ROCK 5 Model B"


Thanks!
Chris

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2023-01-09 14:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 18:22 [PATCHv6 0/7] Initial rk3588 DT Sebastian Reichel
2022-12-14 18:22 ` Sebastian Reichel
2022-12-14 18:22 ` [PATCHv6 1/7] dt-bindings: soc: rockchip: add initial rk3588 syscon compatibles Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-14 18:22 ` [PATCHv6 2/7] arm64: dts: rockchip: Add rk3588 pinctrl data Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-14 18:22 ` [PATCHv6 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-15  9:22   ` Marc Zyngier
2022-12-15  9:22     ` Marc Zyngier
2022-12-15 14:00     ` Sebastian Reichel
2022-12-15 14:00       ` Sebastian Reichel
2022-12-15 10:45   ` Jagan Teki
2022-12-15 10:45     ` Jagan Teki
2022-12-15 10:50     ` Marc Zyngier
2022-12-15 10:50       ` Marc Zyngier
2022-12-15 10:55       ` Jagan Teki
2022-12-15 10:55         ` Jagan Teki
2022-12-14 18:22 ` [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588 boards Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2023-01-05 19:20   ` Christopher Obbard
2023-01-05 19:20     ` Christopher Obbard
2023-01-07  0:28     ` Sebastian Reichel
2023-01-07  0:28       ` Sebastian Reichel
2023-01-09 14:27       ` Christopher Obbard [this message]
2023-01-09 14:27         ` Christopher Obbard
2022-12-14 18:22 ` [PATCHv6 5/7] arm64: dts: rockchip: Add rk3588-evb1 board Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-15 13:07   ` Jagan Teki
2022-12-15 13:07     ` Jagan Teki
2022-12-15 13:56     ` Sebastian Reichel
2022-12-15 13:56       ` Sebastian Reichel
2022-12-14 18:22 ` [PATCHv6 6/7] arm64: dts: rockchip: Add rock-5a board Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-14 18:22 ` [PATCHv6 7/7] arm64: dts: rockchip: Add rock-5b board Sebastian Reichel
2022-12-14 18:22   ` Sebastian Reichel
2022-12-15 17:18 ` [PATCHv6 0/7] Initial rk3588 DT Rob Herring
2022-12-15 17:18   ` Rob Herring
2022-12-15 18:17   ` Sebastian Reichel
2022-12-15 18:17     ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a3c520c75dcfe6ff86e96aa18fc5b52ce1e3f30.camel@collabora.com \
    --to=chris.obbard@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.