All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Swapnil Jakhade <sjakhade@cadence.com>
Cc: <airlied@linux.ie>, <daniel@ffwll.ch>, <robh+dt@kernel.org>,
	<a.hajda@samsung.com>, <narmstrong@baylibre.com>,
	<jonas@kwiboo.se>, <jernej.skrabec@siol.net>,
	<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <mparab@cadence.com>,
	<yamonkar@cadence.com>, <jsarha@ti.com>, <nsekhar@ti.com>,
	<praneeth@ti.com>
Subject: Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge
Date: Wed, 26 Aug 2020 10:26:22 +0300	[thread overview]
Message-ID: <0a6e7550-67ca-c72f-7c3a-1ed4586381a7@ti.com> (raw)
In-Reply-To: <20200811023622.GC13513@pendragon.ideasonboard.com>

Hi,

On 11/08/2020 05:36, Laurent Pinchart wrote:
>> +{
>> +	u32 max_bw, req_bw, bpp;
>> +
>> +	bpp = cdns_mhdp_get_bpp(&mhdp->display_fmt);
>> +	req_bw = mode->clock * bpp / 8;
>> +	max_bw = lanes * rate;
> mode->clock is in kHz, while rate is expressed in 10kHz unit if I'm not
> mistaken.

Rate is in 10 kbps units. And 10 bits in DP gives you one byte (8b/10b encoding). So max_bw is in
kBps, the same as req_bw.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Swapnil Jakhade <sjakhade@cadence.com>
Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net,
	praneeth@ti.com, yamonkar@cadence.com, jonas@kwiboo.se,
	airlied@linux.ie, narmstrong@baylibre.com, nsekhar@ti.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	a.hajda@samsung.com, robh+dt@kernel.org, jsarha@ti.com,
	mparab@cadence.com
Subject: Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge
Date: Wed, 26 Aug 2020 10:26:22 +0300	[thread overview]
Message-ID: <0a6e7550-67ca-c72f-7c3a-1ed4586381a7@ti.com> (raw)
In-Reply-To: <20200811023622.GC13513@pendragon.ideasonboard.com>

Hi,

On 11/08/2020 05:36, Laurent Pinchart wrote:
>> +{
>> +	u32 max_bw, req_bw, bpp;
>> +
>> +	bpp = cdns_mhdp_get_bpp(&mhdp->display_fmt);
>> +	req_bw = mode->clock * bpp / 8;
>> +	max_bw = lanes * rate;
> mode->clock is in kHz, while rate is expressed in 10kHz unit if I'm not
> mistaken.

Rate is in 10 kbps units. And 10 bits in DP gives you one byte (8b/10b encoding). So max_bw is in
kBps, the same as req_bw.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-08-26  7:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 11:34 [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper Swapnil Jakhade
2020-08-06 11:34 ` Swapnil Jakhade
2020-08-06 11:34 ` [PATCH v8 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings Swapnil Jakhade
2020-08-06 11:34   ` Swapnil Jakhade
2020-08-11  0:36   ` Laurent Pinchart
2020-08-11  0:36     ` Laurent Pinchart
2020-08-14  7:13     ` Tomi Valkeinen
2020-08-14  7:13       ` Tomi Valkeinen
2020-08-06 11:34 ` [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge Swapnil Jakhade
2020-08-06 11:34   ` Swapnil Jakhade
2020-08-07  1:15   ` kernel test robot
2020-08-07  1:15     ` kernel test robot
2020-08-07  1:15     ` kernel test robot
2020-08-07  9:38   ` Tomi Valkeinen
2020-08-07  9:38     ` Tomi Valkeinen
2020-08-11  2:36   ` Laurent Pinchart
2020-08-11  2:36     ` Laurent Pinchart
2020-08-14  8:22     ` Tomi Valkeinen
2020-08-14  8:22       ` Tomi Valkeinen
2020-08-24  2:17       ` Laurent Pinchart
2020-08-24  2:17         ` Laurent Pinchart
2020-08-14  9:29     ` Tomi Valkeinen
2020-08-14  9:29       ` Tomi Valkeinen
2020-08-24  2:18       ` Laurent Pinchart
2020-08-24  2:18         ` Laurent Pinchart
2020-08-26  7:26     ` Tomi Valkeinen [this message]
2020-08-26  7:26       ` Tomi Valkeinen
2020-08-06 11:34 ` [PATCH v8 3/3] drm: bridge: cdns-mhdp: Add j721e wrapper Swapnil Jakhade
2020-08-06 11:34   ` Swapnil Jakhade
2020-08-11  2:41   ` Laurent Pinchart
2020-08-11  2:41     ` Laurent Pinchart
2020-08-12  8:39 ` [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper Guido Günther
2020-08-12  8:39   ` Guido Günther
2020-08-12 10:47   ` Tomi Valkeinen
2020-08-12 10:47     ` Tomi Valkeinen
2020-08-12 13:56     ` Guido Günther
2020-08-12 13:56       ` Guido Günther
2020-08-24  7:16       ` Swapnil Kashinath Jakhade
2020-08-24  7:16         ` Swapnil Kashinath Jakhade
2020-08-25  7:32         ` Guido Günther
2020-08-25  7:32           ` Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a6e7550-67ca-c72f-7c3a-1ed4586381a7@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mparab@cadence.com \
    --cc=narmstrong@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sjakhade@cadence.com \
    --cc=yamonkar@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.