From: Jens Axboe <axboe@fb.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
Mike Christie <mchristi@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Hannes Reinecke <hare@suse.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@hgst.com>,
Mike Snitzer <snitzer@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset()
Date: Thu, 23 Mar 2017 08:16:35 -0600 [thread overview]
Message-ID: <0a6f04c4-7006-397f-21ac-4e8b35363a8b@fb.com> (raw)
In-Reply-To: <20170323102455.GA20154@mwanda>
On 03/23/2017 04:24 AM, Dan Carpenter wrote:
> There isn't a bug here, but Smatch is not smart enough to know that
> "nr_iovecs" can't be negative so it complains about underflows.
> Really, it's slightly cleaner to make this parameter unsigned.
Applied, thanks Dan.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
Mike Christie <mchristi@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Hannes Reinecke <hare@suse.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@hgst.com>,
Mike Snitzer <snitzer@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset()
Date: Thu, 23 Mar 2017 14:16:35 +0000 [thread overview]
Message-ID: <0a6f04c4-7006-397f-21ac-4e8b35363a8b@fb.com> (raw)
In-Reply-To: <20170323102455.GA20154@mwanda>
On 03/23/2017 04:24 AM, Dan Carpenter wrote:
> There isn't a bug here, but Smatch is not smart enough to know that
> "nr_iovecs" can't be negative so it complains about underflows.
> Really, it's slightly cleaner to make this parameter unsigned.
Applied, thanks Dan.
--
Jens Axboe
next prev parent reply other threads:[~2017-03-23 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 10:24 [PATCH] block: make nr_iovecs unsigned in bio_alloc_bioset() Dan Carpenter
2017-03-23 10:24 ` Dan Carpenter
2017-03-23 14:07 ` Christoph Hellwig
2017-03-23 14:07 ` Christoph Hellwig
2017-03-23 14:16 ` Jens Axboe [this message]
2017-03-23 14:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a6f04c4-7006-397f-21ac-4e8b35363a8b@fb.com \
--to=axboe@fb.com \
--cc=adrian.hunter@intel.com \
--cc=chaitanya.kulkarni@hgst.com \
--cc=dan.carpenter@oracle.com \
--cc=hare@suse.com \
--cc=kent.overstreet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=snitzer@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.