From: Konrad Dybcio <konrad.dybcio@somainline.org> To: Sricharan Ramabadhran <sricharan@codeaurora.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Manivannan Sadhasivam <mani@kernel.org> Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mdalam@codeaurora.org Subject: Re: [PATCH] mtd: nand: raw: qcom_nandc: Don't clear_bam_transaction on READID Date: Mon, 31 Jan 2022 11:09:54 +0100 [thread overview] Message-ID: <0a8d6550-aa19-0af1-abae-66bf34c91ea8@somainline.org> (raw) In-Reply-To: <a6fcc533-e7cd-7b55-4db0-cec80c07b46a@codeaurora.org> On 28/01/2022 18:50, Sricharan Ramabadhran wrote: > Hi Konrad, > > On 1/28/2022 9:55 AM, Sricharan Ramabadhran wrote: >> Hi Miquel, >> >> On 1/26/2022 4:12 PM, Miquel Raynal wrote: >>> Hi Mani, >>> >>> mani@kernel.org wrote on Wed, 26 Jan 2022 16:03:16 +0530: >>> >>>> On Wed, Jan 26, 2022 at 11:16:13AM +0100, Miquel Raynal wrote: >>>>> Hello, >>>>> >>>>> miquel.raynal@bootlin.com wrote on Fri, 14 Jan 2022 08:27:18 +0100: >>>>>> Hi Konrad, >>>>>> >>>>>> konrad.dybcio@somainline.org wrote on Thu, 13 Jan 2022 19:44:26 >>>>>> +0100: >>>>>>> While I have absolutely 0 idea why and how, running >>>>>>> clear_bam_transaction >>>>>>> when READID is issued makes the DMA totally clog up and refuse >>>>>>> to function >>>>>>> at all on mdm9607. In fact, it is so bad that all the data gets >>>>>>> garbled >>>>>>> and after a short while in the nand probe flow, the CPU decides >>>>>>> that >>>>>>> sepuku is the only option. >>>>>>> >>>>>>> Removing _READID from the if condition makes it work like a >>>>>>> charm, I can >>>>>>> read data and mount partitions without a problem. >>>>>>> >>>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>>>> --- >>>>>>> This is totally just an observation which took me an inhumane >>>>>>> amount of >>>>>>> debug prints to find.. perhaps there's a better reason behind >>>>>>> this, but >>>>>>> I can't seem to find any answers.. Therefore, this is a BIG RFC! >>>>>> I'm adding two people from codeaurora who worked a lot on this >>>>>> driver. >>>>>> Hopefully they will have an idea :) >>>>> Sadre, I've spent a significant amount of time reviewing your >>>>> patches, >>>>> now it's your turn to not take a month to answer to your peers >>>>> proposals. >>>>> >>>>> Please help reviewing this patch. >>>> Sorry. I was hoping that Qcom folks would chime in as I don't have >>>> any idea >>>> about the mdm9607 platform. It could be that the mail server >>>> migration from >>>> codeaurora to quicinc put a barrier here. >>>> >>>> Let me ping them internally. >>> Oh, ok, I didn't know. Thanks! >> >> Sorry Miquel, somehow we did not get this email in our inbox. >> Thanks to Mani for pinging us, we will test this up today and get >> back. >> > While we could not reproduce this issue on our ipq boards (do > not have a mdm9607 right now) and > issue does not look any obvious. > can you please give the debug logs that you did for the above > stage by stage ? I won't have access to the board for about two weeks, sorry. When I get to it, I'll surely try to send you the logs, though there wasn't much more than just something jumping to who-knows-where after clear_bam_transaction was called, resulting in values associated with the NAND being all zeroed out in pr_err/_debug/etc. Konrad > > Regards, > Sricharan >
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Dybcio <konrad.dybcio@somainline.org> To: Sricharan Ramabadhran <sricharan@codeaurora.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Manivannan Sadhasivam <mani@kernel.org> Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mdalam@codeaurora.org Subject: Re: [PATCH] mtd: nand: raw: qcom_nandc: Don't clear_bam_transaction on READID Date: Mon, 31 Jan 2022 11:09:54 +0100 [thread overview] Message-ID: <0a8d6550-aa19-0af1-abae-66bf34c91ea8@somainline.org> (raw) In-Reply-To: <a6fcc533-e7cd-7b55-4db0-cec80c07b46a@codeaurora.org> On 28/01/2022 18:50, Sricharan Ramabadhran wrote: > Hi Konrad, > > On 1/28/2022 9:55 AM, Sricharan Ramabadhran wrote: >> Hi Miquel, >> >> On 1/26/2022 4:12 PM, Miquel Raynal wrote: >>> Hi Mani, >>> >>> mani@kernel.org wrote on Wed, 26 Jan 2022 16:03:16 +0530: >>> >>>> On Wed, Jan 26, 2022 at 11:16:13AM +0100, Miquel Raynal wrote: >>>>> Hello, >>>>> >>>>> miquel.raynal@bootlin.com wrote on Fri, 14 Jan 2022 08:27:18 +0100: >>>>>> Hi Konrad, >>>>>> >>>>>> konrad.dybcio@somainline.org wrote on Thu, 13 Jan 2022 19:44:26 >>>>>> +0100: >>>>>>> While I have absolutely 0 idea why and how, running >>>>>>> clear_bam_transaction >>>>>>> when READID is issued makes the DMA totally clog up and refuse >>>>>>> to function >>>>>>> at all on mdm9607. In fact, it is so bad that all the data gets >>>>>>> garbled >>>>>>> and after a short while in the nand probe flow, the CPU decides >>>>>>> that >>>>>>> sepuku is the only option. >>>>>>> >>>>>>> Removing _READID from the if condition makes it work like a >>>>>>> charm, I can >>>>>>> read data and mount partitions without a problem. >>>>>>> >>>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> >>>>>>> --- >>>>>>> This is totally just an observation which took me an inhumane >>>>>>> amount of >>>>>>> debug prints to find.. perhaps there's a better reason behind >>>>>>> this, but >>>>>>> I can't seem to find any answers.. Therefore, this is a BIG RFC! >>>>>> I'm adding two people from codeaurora who worked a lot on this >>>>>> driver. >>>>>> Hopefully they will have an idea :) >>>>> Sadre, I've spent a significant amount of time reviewing your >>>>> patches, >>>>> now it's your turn to not take a month to answer to your peers >>>>> proposals. >>>>> >>>>> Please help reviewing this patch. >>>> Sorry. I was hoping that Qcom folks would chime in as I don't have >>>> any idea >>>> about the mdm9607 platform. It could be that the mail server >>>> migration from >>>> codeaurora to quicinc put a barrier here. >>>> >>>> Let me ping them internally. >>> Oh, ok, I didn't know. Thanks! >> >> Sorry Miquel, somehow we did not get this email in our inbox. >> Thanks to Mani for pinging us, we will test this up today and get >> back. >> > While we could not reproduce this issue on our ipq boards (do > not have a mdm9607 right now) and > issue does not look any obvious. > can you please give the debug logs that you did for the above > stage by stage ? I won't have access to the board for about two weeks, sorry. When I get to it, I'll surely try to send you the logs, though there wasn't much more than just something jumping to who-knows-where after clear_bam_transaction was called, resulting in values associated with the NAND being all zeroed out in pr_err/_debug/etc. Konrad > > Regards, > Sricharan > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-31 10:09 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-13 18:44 [PATCH] mtd: nand: raw: qcom_nandc: Don't clear_bam_transaction on READID Konrad Dybcio 2022-01-13 18:44 ` Konrad Dybcio 2022-01-13 18:45 ` Konrad Dybcio 2022-01-13 18:45 ` Konrad Dybcio 2022-01-14 7:27 ` Miquel Raynal 2022-01-14 7:27 ` Miquel Raynal 2022-01-26 10:16 ` Miquel Raynal 2022-01-26 10:16 ` Miquel Raynal 2022-01-26 10:33 ` Manivannan Sadhasivam 2022-01-26 10:33 ` Manivannan Sadhasivam 2022-01-26 10:42 ` Miquel Raynal 2022-01-26 10:42 ` Miquel Raynal 2022-01-26 11:36 ` Manivannan Sadhasivam 2022-01-26 11:36 ` Manivannan Sadhasivam 2022-01-28 4:25 ` Sricharan Ramabadhran 2022-01-28 4:25 ` Sricharan Ramabadhran 2022-01-28 17:50 ` Sricharan Ramabadhran 2022-01-28 17:50 ` Sricharan Ramabadhran 2022-01-31 9:52 ` Miquel Raynal 2022-01-31 9:52 ` Miquel Raynal 2022-01-31 10:09 ` Konrad Dybcio [this message] 2022-01-31 10:09 ` Konrad Dybcio 2022-01-31 14:13 ` Sricharan Ramabadhran 2022-01-31 14:13 ` Sricharan Ramabadhran 2022-01-31 19:54 ` Konrad Dybcio 2022-01-31 19:54 ` Konrad Dybcio 2022-02-01 13:52 ` Miquel Raynal 2022-02-01 13:52 ` Miquel Raynal 2022-02-01 15:51 ` Konrad Dybcio 2022-02-01 15:51 ` Konrad Dybcio 2022-02-02 7:24 ` Sricharan Ramabadhran 2022-02-02 7:24 ` Sricharan Ramabadhran 2022-02-04 17:17 ` Sricharan Ramabadhran 2022-02-04 17:17 ` Sricharan Ramabadhran 2022-02-08 16:45 ` Konrad Dybcio 2022-02-08 16:45 ` Konrad Dybcio 2022-02-24 7:33 ` Sricharan Ramabadhran 2022-02-24 7:33 ` Sricharan Ramabadhran 2022-03-11 21:22 ` Konrad Dybcio 2022-03-11 21:22 ` Konrad Dybcio 2022-04-08 13:29 ` Manivannan Sadhasivam 2022-04-08 13:29 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0a8d6550-aa19-0af1-abae-66bf34c91ea8@somainline.org \ --to=konrad.dybcio@somainline.org \ --cc=angelogioacchino.delregno@somainline.org \ --cc=jamipkettunen@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=mani@kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=martin.botka@somainline.org \ --cc=mdalam@codeaurora.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=sricharan@codeaurora.org \ --cc=vigneshr@ti.com \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.