All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virtio-gpu: Add spaces around operator
@ 2021-03-09  7:42 lijiejun
  2021-03-09  9:08 ` Philippe Mathieu-Daudé
  2021-03-09 15:43 ` Eric Blake
  0 siblings, 2 replies; 6+ messages in thread
From: lijiejun @ 2021-03-09  7:42 UTC (permalink / raw)
  To: kraxel; +Cc: lijiejun, qemu-devel

Fix code style. Operator needs spaces forend sides, and delete line space.

Signed-off-by: lijiejun <a_lijiejun@163.com>
---
 hw/display/virtio-gpu-3d.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 9eb4890..d989648 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
         break;
     case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
         virgl_cmd_resource_flush(g, cmd);
-       break;
+        break;
     case VIRTIO_GPU_CMD_RESOURCE_UNREF:
         virgl_cmd_resource_unref(g, cmd);
         break;
@@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
     case VIRTIO_GPU_CMD_GET_CAPSET:
         virgl_cmd_get_capset(g, cmd);
         break;
-
     case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
         virtio_gpu_get_display_info(g, cmd);
         break;
-- 
1.8.3.1




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-gpu: Add spaces around operator
  2021-03-09  7:42 [PATCH] virtio-gpu: Add spaces around operator lijiejun
@ 2021-03-09  9:08 ` Philippe Mathieu-Daudé
  2021-03-09 12:27   ` 李皆俊
  2021-03-09 15:43 ` Eric Blake
  1 sibling, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-09  9:08 UTC (permalink / raw)
  To: lijiejun, kraxel, QEMU Trivial; +Cc: qemu-devel

(Cc'ing qemu-trivial@)

On 3/9/21 8:42 AM, lijiejun wrote:
> Fix code style. Operator needs spaces forend sides, and delete line space.

"forend"?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Signed-off-by: lijiejun <a_lijiejun@163.com>
> ---
>  hw/display/virtio-gpu-3d.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
> index 9eb4890..d989648 100644
> --- a/hw/display/virtio-gpu-3d.c
> +++ b/hw/display/virtio-gpu-3d.c
> @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>          break;
>      case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
>          virgl_cmd_resource_flush(g, cmd);
> -       break;
> +        break;
>      case VIRTIO_GPU_CMD_RESOURCE_UNREF:
>          virgl_cmd_resource_unref(g, cmd);
>          break;
> @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>      case VIRTIO_GPU_CMD_GET_CAPSET:
>          virgl_cmd_get_capset(g, cmd);
>          break;
> -
>      case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
>          virtio_gpu_get_display_info(g, cmd);
>          break;
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re:Re: [PATCH] virtio-gpu: Add spaces around operator
  2021-03-09  9:08 ` Philippe Mathieu-Daudé
@ 2021-03-09 12:27   ` 李皆俊
  0 siblings, 0 replies; 6+ messages in thread
From: 李皆俊 @ 2021-03-09 12:27 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: QEMU Trivial, kraxel, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]




















At 2021-03-09 17:08:08, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote:
>(Cc'ing qemu-trivial@)
>
>On 3/9/21 8:42 AM, lijiejun wrote:
>> Fix code style. Operator needs spaces forend sides, and delete line space.
>

>"forend"?


done with:
Fix code style. Operator needs align with eight spaces, and delete line space.


>
>Otherwise:
>Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>> 
>> Signed-off-by: lijiejun <a_lijiejun@163.com>
>> ---
>>  hw/display/virtio-gpu-3d.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
>> index 9eb4890..d989648 100644
>> --- a/hw/display/virtio-gpu-3d.c
>> +++ b/hw/display/virtio-gpu-3d.c
>> @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>>          break;
>>      case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
>>          virgl_cmd_resource_flush(g, cmd);
>> -       break;
>> +        break;
>>      case VIRTIO_GPU_CMD_RESOURCE_UNREF:
>>          virgl_cmd_resource_unref(g, cmd);
>>          break;
>> @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>>      case VIRTIO_GPU_CMD_GET_CAPSET:
>>          virgl_cmd_get_capset(g, cmd);
>>          break;
>> -
>>      case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
>>          virtio_gpu_get_display_info(g, cmd);
>>          break;
>> 

[-- Attachment #2: Type: text/html, Size: 2036 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-gpu: Add spaces around operator
  2021-03-09  7:42 [PATCH] virtio-gpu: Add spaces around operator lijiejun
  2021-03-09  9:08 ` Philippe Mathieu-Daudé
@ 2021-03-09 15:43 ` Eric Blake
  1 sibling, 0 replies; 6+ messages in thread
From: Eric Blake @ 2021-03-09 15:43 UTC (permalink / raw)
  To: lijiejun, kraxel; +Cc: qemu-devel

On 3/9/21 1:42 AM, lijiejun wrote:
> Fix code style. Operator needs spaces forend sides, and delete line space.

What operator?  'break' is a statement, not an operator.

> 
> Signed-off-by: lijiejun <a_lijiejun@163.com>
> ---
>  hw/display/virtio-gpu-3d.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
> index 9eb4890..d989648 100644
> --- a/hw/display/virtio-gpu-3d.c
> +++ b/hw/display/virtio-gpu-3d.c
> @@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>          break;
>      case VIRTIO_GPU_CMD_RESOURCE_FLUSH:
>          virgl_cmd_resource_flush(g, cmd);
> -       break;
> +        break;
>      case VIRTIO_GPU_CMD_RESOURCE_UNREF:
>          virgl_cmd_resource_unref(g, cmd);
>          break;
> @@ -456,7 +456,6 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
>      case VIRTIO_GPU_CMD_GET_CAPSET:
>          virgl_cmd_get_capset(g, cmd);
>          break;
> -
>      case VIRTIO_GPU_CMD_GET_DISPLAY_INFO:
>          virtio_gpu_get_display_info(g, cmd);
>          break;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] virtio-gpu: Add spaces around operator
  2021-03-09  3:57 李皆俊
@ 2021-03-09  7:02 ` Gerd Hoffmann
  0 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2021-03-09  7:02 UTC (permalink / raw)
  To: 李皆俊; +Cc: qemu-devel, mst

On Tue, Mar 09, 2021 at 11:57:02AM +0800, 李皆俊 wrote:
> From 0512d1cbe5c01844b4aca260024006e058dc1b6c Mon Sep 17 00:00:00 2001
> 
> From: lijiejun <a_lijiejun@163.com>
> 
> Date: Tue, 9 Mar 2021 11:17:59 +0800
> 
> Subject: [PATCH] virtio-gpu: Add spaces around operator

Patch is mangled by your mailer.
Please use 'git send-email' to submit patches.

thanks,
  Gerd



^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] virtio-gpu: Add spaces around operator
@ 2021-03-09  3:57 李皆俊
  2021-03-09  7:02 ` Gerd Hoffmann
  0 siblings, 1 reply; 6+ messages in thread
From: 李皆俊 @ 2021-03-09  3:57 UTC (permalink / raw)
  To: kraxel, mst; +Cc: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

From 0512d1cbe5c01844b4aca260024006e058dc1b6c Mon Sep 17 00:00:00 2001

From: lijiejun <a_lijiejun@163.com>

Date: Tue, 9 Mar 2021 11:17:59 +0800

Subject: [PATCH] virtio-gpu: Add spaces around operator




Fix code style. Operator needs spaces forend sides.




Signed-off-by: lijiejun <a_lijiejun@163.com>

---

 hw/display/virtio-gpu-3d.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)




diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c

index 9eb4890..fb11e5f 100644

--- a/hw/display/virtio-gpu-3d.c

+++ b/hw/display/virtio-gpu-3d.c

@@ -438,7 +438,7 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,

         break;

     case VIRTIO_GPU_CMD_RESOURCE_FLUSH:

         virgl_cmd_resource_flush(g, cmd);

-       break;

+        break;

     case VIRTIO_GPU_CMD_RESOURCE_UNREF:

         virgl_cmd_resource_unref(g, cmd);

         break;

--

1.8.3.1

[-- Attachment #2: Type: text/html, Size: 1851 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-09 16:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09  7:42 [PATCH] virtio-gpu: Add spaces around operator lijiejun
2021-03-09  9:08 ` Philippe Mathieu-Daudé
2021-03-09 12:27   ` 李皆俊
2021-03-09 15:43 ` Eric Blake
  -- strict thread matches above, loose matches on Subject: below --
2021-03-09  3:57 李皆俊
2021-03-09  7:02 ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.