[PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[Wei Liu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="y", Size: 718 bytes --]

That function can return a whole slew of error codes. Translate them
to EXIT_FAILURE.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Roger Pau Monné <roger.pau@citrix.com> 
---
 tools/xl/xl_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
index 9037e2b2f0..9c6227af23 100644
--- a/tools/xl/xl_misc.c
+++ b/tools/xl/xl_misc.c
@@ -182,7 +182,7 @@ int main_devd(int argc, char **argv)
         }
     }
 
-    libxl_device_events_handler(ctx, 0);
+    ret = libxl_device_events_handler(ctx, 0) ? EXIT_FAILURE : EXIT_SUCCESS;
 
 out:
     return ret;
-- 
2.11.0



[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[Roger Pau Monné]

On Thu, May 11, 2017 at 01:57:19PM +0100, Wei Liu wrote:
> That function can return a whole slew of error codes. Translate them
> to EXIT_FAILURE.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[Ian Jackson]

Wei Liu writes ("[PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler"):
> That function can return a whole slew of error codes. Translate them
> to EXIT_FAILURE.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH for-4.9] xl: don't ignore return value from libxl_device_events_handler

[Julien Grall]

Hi Wei,

On 11/05/17 13:57, Wei Liu wrote:
> That function can return a whole slew of error codes. Translate them
> to EXIT_FAILURE.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Release-acked-by: Julien Grall <julien.grall@arm.com>

Cheers,

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  tools/xl/xl_misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
> index 9037e2b2f0..9c6227af23 100644
> --- a/tools/xl/xl_misc.c
> +++ b/tools/xl/xl_misc.c
> @@ -182,7 +182,7 @@ int main_devd(int argc, char **argv)
>          }
>      }
>
> -    libxl_device_events_handler(ctx, 0);
> +    ret = libxl_device_events_handler(ctx, 0) ? EXIT_FAILURE : EXIT_SUCCESS;
>
>  out:
>      return ret;
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel