[PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[Sergio Sota]

 From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
From: Sergio Sota <pikaslabs@gmail.com>
Date: Wed, 23 Dec 2020 20:03:55 +0100
Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
  fallback

The A10s/A13 display frontend driver is not implemented
The A10 has a compatible display frontend driver
Set A10 display frontend driver as a fallback for A10s/A13

Signed-off-by: Sergio Sota <pikaslabs@gmail.com>
---
  arch/arm/boot/dts/sun5i.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index c2b4fbf552a3..4ef14a8695ef 100644
--- a/arch/arm/boot/dts/sun5i.dtsi
+++ b/arch/arm/boot/dts/sun5i.dtsi
@@ -734,7 +734,8 @@ timer@1c60000 {
          };

          fe0: display-frontend@1e00000 {
-            compatible = "allwinner,sun5i-a13-display-frontend";
+            compatible = "allwinner,sun5i-a13-display-frontend",
+                     "allwinner,sun4i-a10-display-frontend";
              reg = <0x01e00000 0x20000>;
              interrupts = <47>;
              clocks = <&ccu CLK_DE_FE>, <&ccu CLK_DE_FE>,
-- 
2.25.1

[PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[Sergio Sota]

 From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
From: Sergio Sota <pikaslabs@gmail.com>
Date: Wed, 23 Dec 2020 20:03:55 +0100
Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
  fallback

The A10s/A13 display frontend driver is not implemented
The A10 has a compatible display frontend driver
Set A10 display frontend driver as a fallback for A10s/A13

Signed-off-by: Sergio Sota <pikaslabs@gmail.com>
---
  arch/arm/boot/dts/sun5i.dtsi | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
index c2b4fbf552a3..4ef14a8695ef 100644
--- a/arch/arm/boot/dts/sun5i.dtsi
+++ b/arch/arm/boot/dts/sun5i.dtsi
@@ -734,7 +734,8 @@ timer@1c60000 {
          };

          fe0: display-frontend@1e00000 {
-            compatible = "allwinner,sun5i-a13-display-frontend";
+            compatible = "allwinner,sun5i-a13-display-frontend",
+                     "allwinner,sun4i-a10-display-frontend";
              reg = <0x01e00000 0x20000>;
              interrupts = <47>;
              clocks = <&ccu CLK_DE_FE>, <&ccu CLK_DE_FE>,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

Hi!

Thanks for your patch

The prefix in your commit title should be ARM: dts: sun5i

It looks like your patch has been wrapped. Make sure you send it through
git send-email, or at least that your mailer don't mangle it.

On Wed, Dec 23, 2020 at 08:58:15PM +0100, Sergio Sota wrote:
> From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
> From: Sergio Sota <pikaslabs@gmail.com>
> Date: Wed, 23 Dec 2020 20:03:55 +0100
> Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
>  fallback
> 
> The A10s/A13 display frontend driver is not implemented
> The A10 has a compatible display frontend driver

You should expand a bit on this one. At the DT level, compatible means
that the entire A13 controller can be driven just like the one found on
the A10, for every feature (including the ones we don't support).

Given that the documentation for it is sparse on the A10, I'm assuming
that you instead tested the current driver and found that it was working
for you. However, it doesn't mean that it's the case for each feature
supported by the controller and thus we can't really make that claim.

We should instead add the support for the A13 compatible in the driver.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support fallback

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1243 bytes --]

Hi!

Thanks for your patch

The prefix in your commit title should be ARM: dts: sun5i

It looks like your patch has been wrapped. Make sure you send it through
git send-email, or at least that your mailer don't mangle it.

On Wed, Dec 23, 2020 at 08:58:15PM +0100, Sergio Sota wrote:
> From d5fcc1d4aec82ffe6de78cc40a6f53910e2e88ba Mon Sep 17 00:00:00 2001
> From: Sergio Sota <pikaslabs@gmail.com>
> Date: Wed, 23 Dec 2020 20:03:55 +0100
> Subject: [PATCH] ARM: dts sunxi: add A10s/A13 display frontend support
>  fallback
> 
> The A10s/A13 display frontend driver is not implemented
> The A10 has a compatible display frontend driver

You should expand a bit on this one. At the DT level, compatible means
that the entire A13 controller can be driven just like the one found on
the A10, for every feature (including the ones we don't support).

Given that the documentation for it is sparse on the A10, I'm assuming
that you instead tested the current driver and found that it was working
for you. However, it doesn't mean that it's the case for each feature
supported by the controller and thus we can't really make that claim.

We should instead add the support for the A13 compatible in the driver.

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel