From: Neil Armstrong <narmstrong@baylibre.com> To: Enric Balletbo Serra <eballetbo@gmail.com>, Hans Verkuil <hverkuil@xs4all.nl> Cc: "David Airlie" <airlied@linux.ie>, "Hans Verkuil" <hans.verkuil@cisco.com>, "Lee Jones" <lee.jones@linaro.org>, "Olof Johansson" <olof@lixom.net>, seanpaul@google.com, sadolfsson@google.com, intel-gfx@lists.freedesktop.org, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Fabien Parent" <fparent@baylibre.com>, felixe@google.com, "Stéphane Marchesin" <marcheu@chromium.org>, "Benson Leung" <bleung@google.com>, darekm@google.com, linux-media@vger.kernel.org Subject: Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration Date: Wed, 16 May 2018 09:42:22 +0200 [thread overview] Message-ID: <0ac61992-3946-63f2-02ed-0dcfa3058a1a@baylibre.com> (raw) In-Reply-To: <CAFqH_52nkk=ATeNoOdhmfAioD30sbg_kyAxr259bydLj9Z6xJg@mail.gmail.com> Hi Enric, On 15/05/2018 18:40, Enric Balletbo Serra wrote: > Hi Neil, > > I suspect that this patch will conflict with some patches that will be > queued for 4.18 that also introduces new devices, well, for now I > don't see these merged in the Lee's tree. Indeed, I found your patches, I'll rebase this one when Lee pushes them in his tree. > > Based on some reviews I got when I send a patch to this file ... > > 2018-05-15 17:29 GMT+02:00 Hans Verkuil <hverkuil@xs4all.nl>: >> On 05/15/2018 04:42 PM, Neil Armstrong wrote: >>> The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device >>> when the CEC feature bit is present. >>> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> >> For what it is worth (not an MFD expert): >> >> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> >> >> Thanks! >> >> Hans >> >>> --- >>> drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c >>> index eafd06f..57064ec 100644 >>> --- a/drivers/mfd/cros_ec_dev.c >>> +++ b/drivers/mfd/cros_ec_dev.c >>> @@ -383,6 +383,18 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec) >>> kfree(msg); >>> } >>> >>> +static void cros_ec_cec_register(struct cros_ec_dev *ec) >>> +{ >>> + int ret; >>> + struct mfd_cell cec_cell = { >>> + .name = "cros-ec-cec", >>> + }; >>> + >>> + ret = mfd_add_devices(ec->dev, 0, &cec_cell, 1, NULL, 0, NULL); >>> + if (ret) >>> + dev_err(ec->dev, "failed to add EC CEC\n"); >>> +} >>> + > > Do not create a single function to only call mfd_add_devices, instead > do the following on top: > > static const struct mfd_cell cros_ec_cec_cells[] = { > { .name = "cros-ec-cec" } > }; OK > > >>> static int ec_device_probe(struct platform_device *pdev) >>> { >>> int retval = -ENOMEM; >>> @@ -422,6 +434,10 @@ static int ec_device_probe(struct platform_device *pdev) >>> if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) >>> cros_ec_sensors_register(ec); >>> >>> + /* check whether this EC handles CEC. */ >>> + if (cros_ec_check_features(ec, EC_FEATURE_CEC)) >>> + cros_ec_cec_register(ec); >>> + > > and use PLATFORM_DEVID_AUTO and the ARRAY_SIZE macro, something like this. > > /* Check whether this EC instance handles CEC */ > if (cros_ec_check_features(ec, EC_FEATURE_CEC)) { > retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO, > cros_ec_cec_cells, > ARRAY_SIZE(cros_ec_cec_cells), > NULL, 0, NULL); > if (retval) > dev_err(ec->dev, "failed to add cros-ec-cec device: %d\n", > retval); > } Ok, like the RTC registration. Thanks, Neil > > Best regards, > Enric > >>> /* Take control of the lightbar from the EC. */ >>> lb_manual_suspend_ctrl(ec, 1); >>> >>> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com> To: Enric Balletbo Serra <eballetbo@gmail.com>, Hans Verkuil <hverkuil@xs4all.nl> Cc: felixe@google.com, seanpaul@google.com, David Airlie <airlied@linux.ie>, sadolfsson@google.com, intel-gfx@lists.freedesktop.org, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Fabien Parent <fparent@baylibre.com>, Hans Verkuil <hans.verkuil@cisco.com>, Olof Johansson <olof@lixom.net>, Benson Leung <bleung@google.com>, darekm@google.com, Lee Jones <lee.jones@linaro.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration Date: Wed, 16 May 2018 09:42:22 +0200 [thread overview] Message-ID: <0ac61992-3946-63f2-02ed-0dcfa3058a1a@baylibre.com> (raw) In-Reply-To: <CAFqH_52nkk=ATeNoOdhmfAioD30sbg_kyAxr259bydLj9Z6xJg@mail.gmail.com> Hi Enric, On 15/05/2018 18:40, Enric Balletbo Serra wrote: > Hi Neil, > > I suspect that this patch will conflict with some patches that will be > queued for 4.18 that also introduces new devices, well, for now I > don't see these merged in the Lee's tree. Indeed, I found your patches, I'll rebase this one when Lee pushes them in his tree. > > Based on some reviews I got when I send a patch to this file ... > > 2018-05-15 17:29 GMT+02:00 Hans Verkuil <hverkuil@xs4all.nl>: >> On 05/15/2018 04:42 PM, Neil Armstrong wrote: >>> The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device >>> when the CEC feature bit is present. >>> >>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> >> For what it is worth (not an MFD expert): >> >> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> >> >> Thanks! >> >> Hans >> >>> --- >>> drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c >>> index eafd06f..57064ec 100644 >>> --- a/drivers/mfd/cros_ec_dev.c >>> +++ b/drivers/mfd/cros_ec_dev.c >>> @@ -383,6 +383,18 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec) >>> kfree(msg); >>> } >>> >>> +static void cros_ec_cec_register(struct cros_ec_dev *ec) >>> +{ >>> + int ret; >>> + struct mfd_cell cec_cell = { >>> + .name = "cros-ec-cec", >>> + }; >>> + >>> + ret = mfd_add_devices(ec->dev, 0, &cec_cell, 1, NULL, 0, NULL); >>> + if (ret) >>> + dev_err(ec->dev, "failed to add EC CEC\n"); >>> +} >>> + > > Do not create a single function to only call mfd_add_devices, instead > do the following on top: > > static const struct mfd_cell cros_ec_cec_cells[] = { > { .name = "cros-ec-cec" } > }; OK > > >>> static int ec_device_probe(struct platform_device *pdev) >>> { >>> int retval = -ENOMEM; >>> @@ -422,6 +434,10 @@ static int ec_device_probe(struct platform_device *pdev) >>> if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) >>> cros_ec_sensors_register(ec); >>> >>> + /* check whether this EC handles CEC. */ >>> + if (cros_ec_check_features(ec, EC_FEATURE_CEC)) >>> + cros_ec_cec_register(ec); >>> + > > and use PLATFORM_DEVID_AUTO and the ARRAY_SIZE macro, something like this. > > /* Check whether this EC instance handles CEC */ > if (cros_ec_check_features(ec, EC_FEATURE_CEC)) { > retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO, > cros_ec_cec_cells, > ARRAY_SIZE(cros_ec_cec_cells), > NULL, 0, NULL); > if (retval) > dev_err(ec->dev, "failed to add cros-ec-cec device: %d\n", > retval); > } Ok, like the RTC registration. Thanks, Neil > > Best regards, > Enric > >>> /* Take control of the lightbar from the EC. */ >>> lb_manual_suspend_ctrl(ec, 1); >>> >>> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-16 7:42 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-15 14:42 [PATCH v2 0/5] Add ChromeOS EC CEC Support Neil Armstrong 2018-05-15 14:42 ` Neil Armstrong 2018-05-15 14:42 ` [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name Neil Armstrong 2018-05-15 14:42 ` Neil Armstrong 2018-05-15 15:22 ` Hans Verkuil 2018-05-15 15:22 ` Hans Verkuil 2018-05-15 16:10 ` Neil Armstrong 2018-05-15 16:10 ` Neil Armstrong 2018-05-15 14:42 ` [PATCH v2 2/5] drm/i915: hdmi: add CEC notifier to intel_hdmi Neil Armstrong 2018-05-15 14:42 ` Neil Armstrong 2018-05-15 15:23 ` Hans Verkuil 2018-05-15 15:23 ` Hans Verkuil 2018-05-15 15:35 ` [Intel-gfx] " Ville Syrjälä 2018-05-15 15:35 ` Ville Syrjälä 2018-05-16 7:31 ` [Intel-gfx] " Neil Armstrong 2018-05-16 7:31 ` Neil Armstrong 2018-05-16 7:40 ` [Intel-gfx] " Neil Armstrong 2018-05-16 7:40 ` Neil Armstrong 2018-05-16 14:07 ` Ville Syrjälä 2018-05-16 14:07 ` Ville Syrjälä 2018-05-16 18:53 ` Neil Armstrong 2018-05-16 18:53 ` Neil Armstrong 2018-05-15 14:42 ` [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions Neil Armstrong 2018-05-15 14:42 ` Neil Armstrong 2018-05-15 15:28 ` Hans Verkuil 2018-05-15 15:28 ` Hans Verkuil 2018-05-16 7:45 ` Neil Armstrong 2018-05-16 7:45 ` Neil Armstrong 2018-05-15 14:42 ` [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration Neil Armstrong 2018-05-15 14:42 ` Neil Armstrong 2018-05-15 15:29 ` Hans Verkuil 2018-05-15 15:29 ` Hans Verkuil 2018-05-15 16:40 ` Enric Balletbo Serra 2018-05-15 16:40 ` Enric Balletbo Serra 2018-05-16 7:42 ` Neil Armstrong [this message] 2018-05-16 7:42 ` Neil Armstrong 2018-05-15 14:42 ` [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver Neil Armstrong 2018-05-15 15:35 ` Hans Verkuil 2018-05-15 15:35 ` Hans Verkuil 2018-05-17 19:59 ` [Intel-gfx] " kbuild test robot 2018-05-17 19:59 ` kbuild test robot 2018-05-15 15:20 ` ✗ Fi.CI.CHECKPATCH: warning for Add ChromeOS EC CEC Support (rev3) Patchwork 2018-05-15 15:36 ` ✓ Fi.CI.BAT: success " Patchwork 2018-05-16 2:04 ` ✓ Fi.CI.IGT: " Patchwork 2018-05-18 13:04 [PATCH v2 0/5] Add ChromeOS EC CEC Support Neil Armstrong 2018-05-18 13:05 ` [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration Neil Armstrong 2018-05-18 13:05 ` Neil Armstrong 2018-05-18 13:41 ` Enric Balletbo Serra 2018-05-18 13:41 ` Enric Balletbo Serra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0ac61992-3946-63f2-02ed-0dcfa3058a1a@baylibre.com \ --to=narmstrong@baylibre.com \ --cc=airlied@linux.ie \ --cc=bleung@google.com \ --cc=darekm@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eballetbo@gmail.com \ --cc=felixe@google.com \ --cc=fparent@baylibre.com \ --cc=hans.verkuil@cisco.com \ --cc=hverkuil@xs4all.nl \ --cc=intel-gfx@lists.freedesktop.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=marcheu@chromium.org \ --cc=olof@lixom.net \ --cc=sadolfsson@google.com \ --cc=seanpaul@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.