Re: [Buildroot] [PATCH 000/107] Drop python 2.7

[Andreas Ziegler <br015@umbiko.net>]

Hi Peter,

On 2022-02-10 07:24, Peter Korsgaard wrote:
>>>>>> "Andreas" == Andreas Ziegler <br015@umbiko.net> writes:
> 
>  > Hi Yann,
>  > Hi Peter,
> 
>  > On 2022-02-09 21:34, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>  >> Peter ,All,
>  >>
>  >> On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
>  >>> Python 2.7 is EOL since April 2020 and almost all packages support
>  >>> python 3, so drop it before the 2022.02 release.
>  >>>
>  >>> It is a big series, but the changes are mainly mechanical in 
> nature.
>  >>>
>  >>> There is still some cleanup to do, E.G. the python2 support in
>  >>> pkg-python and the host python-setuptools package - But this is 
> IMHO
>  >>> the minimum changes before -rc1.
> 
>  > There seem to be some more references to python(2) in packages; this
>  > build failure is from package/crda:
> 
>  > # make clean && make
>  >   ...
>  > make[1]: *** No rule to make target 'host-python', needed by
>  >
> '/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'.
> Stop.
>  > make: *** [Makefile:23: _all] Error 2
> 
> Ahh yes, that is because we end up in package/pkg-python.mk with:
> 
> ifeq ($$($(2)_NEEDS_HOST_PYTHON),)
> $(2)_DEPENDENCIES += $$(if 
> $$(BR2_PACKAGE_PYTHON3),host-python3,host-python)

Ah, this may be the reason I have two sets of host-python packages in my 
build tree :-D

> 
> And you (presumably) don't have python3 enabled. I'll send a fix.

Correct, I do not use Python on the target, but (at lest) one package 
insists on having host-python.

I'm currently testing by changing host-python to host-python3 in 
package/crda, and found another issue; this probably also needs a 
change:

[python3.mk]
# Some packages may have build scripts requiring python3, whatever is 
the
# python version chosen for the target.
# Only install the python symlink in the host tree if python3 is enabled
# for the target.
ifeq ($(BR2_PACKAGE_PYTHON3),y)
define HOST_PYTHON3_INSTALL_SYMLINK
	ln -fs python3 $(HOST_DIR)/bin/python
	ln -fs python3-config $(HOST_DIR)/bin/python-config
endef

Is there any need of keeping separate python3 packages, now that python 
== python3?

Kind regards,
Andreas

> --
> Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot