* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
[not found] <mailman.6747.1644442447.66748.buildroot@buildroot.org>
@ 2022-02-10 6:42 ` Andreas Ziegler
2022-02-10 7:24 ` Peter Korsgaard
0 siblings, 1 reply; 11+ messages in thread
From: Andreas Ziegler @ 2022-02-10 6:42 UTC (permalink / raw)
To: Peter Korsgaard, Yann E. MORIN; +Cc: buildroot
Hi Yann,
Hi Peter,
On 2022-02-09 21:34, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Peter ,All,
>
> On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
>> Python 2.7 is EOL since April 2020 and almost all packages support
>> python 3, so drop it before the 2022.02 release.
>>
>> It is a big series, but the changes are mainly mechanical in nature.
>>
>> There is still some cleanup to do, E.G. the python2 support in
>> pkg-python and the host python-setuptools package - But this is IMHO
>> the minimum changes before -rc1.
There seem to be some more references to python(2) in packages; this
build failure is from package/crda:
# make clean && make
...
make[1]: *** No rule to make target 'host-python', needed by
'/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'.
Stop.
make: *** [Makefile:23: _all] Error 2
$ grep python-pycryptodomex */*.mk
crda/crda.mk:CRDA_DEPENDENCIES = host-pkgconf host-python-pycryptodomex
libnl libgcrypt
python3-pycryptodomex/python3-pycryptodomex.mk:# Please keep in sync
with package/python-pycryptodomex/python-pycryptodomex.mk
python3-pycryptodomex/python3-pycryptodomex.mk:HOST_PYTHON3_PYCRYPTODOMEX_DL_SUBDIR
= python-pycryptodomex
python-pycryptodomex/python-pycryptodomex.mk:# python-pycryptodomex
Kind regards,
Andreas
>> Peter Korsgaard (107):
> ...
>> package/python: drop target package
> ...
>> package/python: drop host package
> ...
>> docs/manual: drop python2 references
>
> All 107 patches applied, thanks!
>
> I'll reply further to two of them, with ultra-minor nits.
>
> Pfew, 21st century, here we come at last! ;-)
>
> Regards,
> Yann E. MORIN.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 6:42 ` [Buildroot] [PATCH 000/107] Drop python 2.7 Andreas Ziegler
@ 2022-02-10 7:24 ` Peter Korsgaard
2022-02-10 7:56 ` Andreas Ziegler
0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2022-02-10 7:24 UTC (permalink / raw)
To: Andreas Ziegler; +Cc: Yann E. MORIN, buildroot
>>>>> "Andreas" == Andreas Ziegler <br015@umbiko.net> writes:
> Hi Yann,
> Hi Peter,
> On 2022-02-09 21:34, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> Peter ,All,
>>
>> On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
>>> Python 2.7 is EOL since April 2020 and almost all packages support
>>> python 3, so drop it before the 2022.02 release.
>>>
>>> It is a big series, but the changes are mainly mechanical in nature.
>>>
>>> There is still some cleanup to do, E.G. the python2 support in
>>> pkg-python and the host python-setuptools package - But this is IMHO
>>> the minimum changes before -rc1.
> There seem to be some more references to python(2) in packages; this
> build failure is from package/crda:
> # make clean && make
> ...
> make[1]: *** No rule to make target 'host-python', needed by
> '/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'. Stop.
> make: *** [Makefile:23: _all] Error 2
Ahh yes, that is because we end up in package/pkg-python.mk with:
ifeq ($$($(2)_NEEDS_HOST_PYTHON),)
$(2)_DEPENDENCIES += $$(if $$(BR2_PACKAGE_PYTHON3),host-python3,host-python)
And you (presumably) don't have python3 enabled. I'll send a fix.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 7:24 ` Peter Korsgaard
@ 2022-02-10 7:56 ` Andreas Ziegler
0 siblings, 0 replies; 11+ messages in thread
From: Andreas Ziegler @ 2022-02-10 7:56 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Yann E. MORIN, buildroot
Hi Peter,
On 2022-02-10 07:24, Peter Korsgaard wrote:
>>>>>> "Andreas" == Andreas Ziegler <br015@umbiko.net> writes:
>
> > Hi Yann,
> > Hi Peter,
>
> > On 2022-02-09 21:34, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >> Peter ,All,
> >>
> >> On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
> >>> Python 2.7 is EOL since April 2020 and almost all packages support
> >>> python 3, so drop it before the 2022.02 release.
> >>>
> >>> It is a big series, but the changes are mainly mechanical in
> nature.
> >>>
> >>> There is still some cleanup to do, E.G. the python2 support in
> >>> pkg-python and the host python-setuptools package - But this is
> IMHO
> >>> the minimum changes before -rc1.
>
> > There seem to be some more references to python(2) in packages; this
> > build failure is from package/crda:
>
> > # make clean && make
> > ...
> > make[1]: *** No rule to make target 'host-python', needed by
> >
> '/home/data/buildroot.x86_64/build/host-python-pycryptodomex-3.13.0/.stamp_configured'.
> Stop.
> > make: *** [Makefile:23: _all] Error 2
>
> Ahh yes, that is because we end up in package/pkg-python.mk with:
>
> ifeq ($$($(2)_NEEDS_HOST_PYTHON),)
> $(2)_DEPENDENCIES += $$(if
> $$(BR2_PACKAGE_PYTHON3),host-python3,host-python)
Ah, this may be the reason I have two sets of host-python packages in my
build tree :-D
>
> And you (presumably) don't have python3 enabled. I'll send a fix.
Correct, I do not use Python on the target, but (at lest) one package
insists on having host-python.
I'm currently testing by changing host-python to host-python3 in
package/crda, and found another issue; this probably also needs a
change:
[python3.mk]
# Some packages may have build scripts requiring python3, whatever is
the
# python version chosen for the target.
# Only install the python symlink in the host tree if python3 is enabled
# for the target.
ifeq ($(BR2_PACKAGE_PYTHON3),y)
define HOST_PYTHON3_INSTALL_SYMLINK
ln -fs python3 $(HOST_DIR)/bin/python
ln -fs python3-config $(HOST_DIR)/bin/python-config
endef
Is there any need of keeping separate python3 packages, now that python
== python3?
Kind regards,
Andreas
> --
> Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 21:18 ` Peter Korsgaard
@ 2022-02-10 21:59 ` James Hilliard
0 siblings, 0 replies; 11+ messages in thread
From: James Hilliard @ 2022-02-10 21:59 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Yann E. MORIN, buildroot
On Thu, Feb 10, 2022 at 2:19 PM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> Hi,
>
> > Arnout, All,
> > On 2022-02-10 18:15 +0100, Arnout Vandecappelle spake thusly:
> >> On 09/02/2022 22:33, Yann E. MORIN wrote:
> >> >On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
> >> >>Python 2.7 is EOL since April 2020 and almost all packages support
> >> >>python 3, so drop it before the 2022.02 release.
> > [--SNIP--]
> >> I did a bit of grepping for leftovers and found these:
> > [--SNIP--]
>
> > Yeah, I knew we had missed a few things, and Peter had already noticed a
> > few in the cover-letter, but we needed to move forward quick, at the
> > risk of breaking things.
>
> > After all, the post-rc1 period is actually to fix things we broke! ;-)
>
> Indeed ;)
>
> >> The ones in gst1-devtools.mk and omniorb.mk look important, the rest is just
> >> cleanup. qt5webengine is also a bit worrisome...
>
> > For qt5webengine, IIRC James and Adam were working on it, and may have a
> > pending change ready?
>
> > I was thinking maybe about this:
> > https://patchwork.ozlabs.org/project/buildroot/list/?series=284619
>
> Yes, I guess we'll need something like that. I did a quick test to see
> if the current qt5webengine version works with python3 - But it doesn't
Yeah, that should get qt5webengine working on python3, there's a bunch of other
issues it should fix as well relating to handling the host/target
pkg-config split.
> :/
>
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 17:31 ` Marcus Hoffmann
@ 2022-02-10 21:55 ` Peter Korsgaard
0 siblings, 0 replies; 11+ messages in thread
From: Peter Korsgaard @ 2022-02-10 21:55 UTC (permalink / raw)
To: Marcus Hoffmann; +Cc: buildroot
>>>>> "Marcus" == Marcus Hoffmann <marcus.hoffmann@othermo.de> writes:
> Hi all!
> On 10.02.22 18:15, Arnout Vandecappelle wrote:
> [...]
>>
>>
>> The ones in gst1-devtools.mk and omniorb.mk look important, the rest
>> is just cleanup. qt5webengine is also a bit worrisome...
>>
>> Also, some cleanups that I think are needed:
>> - get rid of HOST_PYTHON_FOO_NEEDS_HOST_PYTHON
>> - symlink $(HOST_DIR)/bin/python to python3, and get rid of the
>> workarounds in e.g. nodejs
> This last bit would actually supersede the patch I send yesterday :-)
> http://patchwork.ozlabs.org/project/buildroot/patch/20220209214305.314272-1-marcus.hoffmann@othermo.de/
Yes, I've sent a patch doing that and marked your patch as superseeded:
https://patchwork.ozlabs.org/project/buildroot/patch/20220210212429.31856-1-peter@korsgaard.com/
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 20:37 ` Yann E. MORIN
@ 2022-02-10 21:18 ` Peter Korsgaard
2022-02-10 21:59 ` James Hilliard
0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2022-02-10 21:18 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
> Arnout, All,
> On 2022-02-10 18:15 +0100, Arnout Vandecappelle spake thusly:
>> On 09/02/2022 22:33, Yann E. MORIN wrote:
>> >On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
>> >>Python 2.7 is EOL since April 2020 and almost all packages support
>> >>python 3, so drop it before the 2022.02 release.
> [--SNIP--]
>> I did a bit of grepping for leftovers and found these:
> [--SNIP--]
> Yeah, I knew we had missed a few things, and Peter had already noticed a
> few in the cover-letter, but we needed to move forward quick, at the
> risk of breaking things.
> After all, the post-rc1 period is actually to fix things we broke! ;-)
Indeed ;)
>> The ones in gst1-devtools.mk and omniorb.mk look important, the rest is just
>> cleanup. qt5webengine is also a bit worrisome...
> For qt5webengine, IIRC James and Adam were working on it, and may have a
> pending change ready?
> I was thinking maybe about this:
> https://patchwork.ozlabs.org/project/buildroot/list/?series=284619
Yes, I guess we'll need something like that. I did a quick test to see
if the current qt5webengine version works with python3 - But it doesn't
:/
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 17:15 ` Arnout Vandecappelle
2022-02-10 17:31 ` Marcus Hoffmann
@ 2022-02-10 20:37 ` Yann E. MORIN
2022-02-10 21:18 ` Peter Korsgaard
1 sibling, 1 reply; 11+ messages in thread
From: Yann E. MORIN @ 2022-02-10 20:37 UTC (permalink / raw)
To: Arnout Vandecappelle; +Cc: buildroot
Arnout, All,
On 2022-02-10 18:15 +0100, Arnout Vandecappelle spake thusly:
> On 09/02/2022 22:33, Yann E. MORIN wrote:
> >On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
> >>Python 2.7 is EOL since April 2020 and almost all packages support
> >>python 3, so drop it before the 2022.02 release.
[--SNIP--]
> I did a bit of grepping for leftovers and found these:
[--SNIP--]
Yeah, I knew we had missed a few things, and Peter had already noticed a
few in the cover-letter, but we needed to move forward quick, at the
risk of breaking things.
After all, the post-rc1 period is actually to fix things we broke! ;-)
> The ones in gst1-devtools.mk and omniorb.mk look important, the rest is just
> cleanup. qt5webengine is also a bit worrisome...
For qt5webengine, IIRC James and Adam were working on it, and may have a
pending change ready?
I was thinking maybe about this:
https://patchwork.ozlabs.org/project/buildroot/list/?series=284619
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-10 17:15 ` Arnout Vandecappelle
@ 2022-02-10 17:31 ` Marcus Hoffmann
2022-02-10 21:55 ` Peter Korsgaard
2022-02-10 20:37 ` Yann E. MORIN
1 sibling, 1 reply; 11+ messages in thread
From: Marcus Hoffmann @ 2022-02-10 17:31 UTC (permalink / raw)
To: buildroot
Hi all!
On 10.02.22 18:15, Arnout Vandecappelle wrote:
[...]
>
>
> The ones in gst1-devtools.mk and omniorb.mk look important, the rest is
> just cleanup. qt5webengine is also a bit worrisome...
>
> Also, some cleanups that I think are needed:
> - get rid of HOST_PYTHON_FOO_NEEDS_HOST_PYTHON
> - symlink $(HOST_DIR)/bin/python to python3, and get rid of the
> workarounds in e.g. nodejs
This last bit would actually supersede the patch I send yesterday :-)
http://patchwork.ozlabs.org/project/buildroot/patch/20220209214305.314272-1-marcus.hoffmann@othermo.de/
>
>
> Regards,
> Arnout
Best,
Marcus
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-09 21:33 ` Yann E. MORIN
@ 2022-02-10 17:15 ` Arnout Vandecappelle
2022-02-10 17:31 ` Marcus Hoffmann
2022-02-10 20:37 ` Yann E. MORIN
0 siblings, 2 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2022-02-10 17:15 UTC (permalink / raw)
To: Yann E. MORIN, Peter Korsgaard; +Cc: buildroot
On 09/02/2022 22:33, Yann E. MORIN wrote:
> Peter ,All,
>
> On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
>> Python 2.7 is EOL since April 2020 and almost all packages support
>> python 3, so drop it before the 2022.02 release.
>>
>> It is a big series, but the changes are mainly mechanical in nature.
>>
>> There is still some cleanup to do, E.G. the python2 support in
>> pkg-python and the host python-setuptools package - But this is IMHO
>> the minimum changes before -rc1.
>>
>> Peter Korsgaard (107):
> ...
>> package/python: drop target package
> ...
>> package/python: drop host package
> ...
>> docs/manual: drop python2 references
>
> All 107 patches applied, thanks!
>
> I'll reply further to two of them, with ultra-minor nits.
>
> Pfew, 21st century, here we come at last! ;-)
Thank you Peter and Yann for handling this!
I did a bit of grepping for leftovers and found these:
package/pkg-python.mk:# BR2_PACKAGE_PYTHON=y, or a host-package with neither
package/pkg-python.mk:# BR2_PACKAGE_PYTHON3=y or BR2_PACKAGE_PYTHON=y.
docs/manual/adding-packages-python.txt: * It is not necessary to add +python+ or
+host-python+ in the
package/gstreamer1/gst1-devtools/gst1-devtools.mk:GST1_DEVTOOLS_DEPENDENCIES +=
host-python python
package/omniorb/omniorb.mk:# omniorb is not python3 friendly, so force the
python interpreter
package/omniorb/omniorb.mk:OMNIORB_CONF_OPTS =
ac_cv_path_PYTHON=$(HOST_DIR)/bin/python2
package/omniorb/omniorb.mk:HOST_OMNIORB_CONF_OPTS =
ac_cv_path_PYTHON=$(HOST_DIR)/bin/python2
package/pkg-python.mk:$(2)_DEPENDENCIES += $$(if
$$(BR2_PACKAGE_PYTHON3),host-python3 python3,host-python python)
package/pkg-python.mk:ifeq ($$($(2)_NEEDS_HOST_PYTHON),python2)
package/pkg-python.mk:# setuptools for python2.
package/pkg-python.mk:# In all other cases, we install setuptools for python2.
Those other
package/pkg-python.mk:else ifeq ($(4):$$($(2)_NEEDS_HOST_PYTHON),host:python2)
package/pkg-python.mk:# We may want to specify the python interpreter to be used
for building a
package/pkg-python.mk:# - for target packages, we always use the default python
interpreter (which
package/python-pyrex/python-pyrex.mk:HOST_PYTHON_PYREX_NEEDS_HOST_PYTHON = python2
package/python-setuptools/python-setuptools.mk:HOST_PYTHON_SETUPTOOLS_NEEDS_HOST_PYTHON
= python2
package/python-web2py/python-web2py.mk:PYTHON_WEB2PY_DEPENDENCIES = $(if
$(BR2_PACKAGE_PYTHON3),host-python3 python3,host-python python) \
package/python3/python3.mk:# python version chosen for the target.
package/python3/python3.mk:# Only install the python symlink in the host tree if
python3 is enabled
package/python3/python3.mk: ln -fs python3 $(HOST_DIR)/bin/python
package/qt5/qt5webengine/qt5webengine.mk:# QtWebengine's build system uses
python, but only supports python2. We work
package/qt5/qt5webengine/qt5webengine.mk:# around this by forcing python2 early
in the PATH, via a python->python2
package/qt5/qt5webengine/qt5webengine.mk: ln -sf $(HOST_DIR)/bin/python2
$(@D)/host-bin/python
package/rust/rust.mk: echo 'python =
"$(HOST_DIR)/bin/python$(HOST_RUST_PYTHON_VERSION)"'; \
The ones in gst1-devtools.mk and omniorb.mk look important, the rest is just
cleanup. qt5webengine is also a bit worrisome...
Also, some cleanups that I think are needed:
- get rid of HOST_PYTHON_FOO_NEEDS_HOST_PYTHON
- symlink $(HOST_DIR)/bin/python to python3, and get rid of the workarounds in
e.g. nodejs
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Buildroot] [PATCH 000/107] Drop python 2.7
2022-02-09 16:50 Peter Korsgaard
@ 2022-02-09 21:33 ` Yann E. MORIN
2022-02-10 17:15 ` Arnout Vandecappelle
0 siblings, 1 reply; 11+ messages in thread
From: Yann E. MORIN @ 2022-02-09 21:33 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: buildroot
Peter ,All,
On 2022-02-09 17:50 +0100, Peter Korsgaard spake thusly:
> Python 2.7 is EOL since April 2020 and almost all packages support
> python 3, so drop it before the 2022.02 release.
>
> It is a big series, but the changes are mainly mechanical in nature.
>
> There is still some cleanup to do, E.G. the python2 support in
> pkg-python and the host python-setuptools package - But this is IMHO
> the minimum changes before -rc1.
>
> Peter Korsgaard (107):
...
> package/python: drop target package
...
> package/python: drop host package
...
> docs/manual: drop python2 references
All 107 patches applied, thanks!
I'll reply further to two of them, with ultra-minor nits.
Pfew, 21st century, here we come at last! ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 000/107] Drop python 2.7
@ 2022-02-09 16:50 Peter Korsgaard
2022-02-09 21:33 ` Yann E. MORIN
0 siblings, 1 reply; 11+ messages in thread
From: Peter Korsgaard @ 2022-02-09 16:50 UTC (permalink / raw)
To: buildroot
Python 2.7 is EOL since April 2020 and almost all packages support
python 3, so drop it before the 2022.02 release.
It is a big series, but the changes are mainly mechanical in nature.
There is still some cleanup to do, E.G. the python2 support in
pkg-python and the host python-setuptools package - But this is IMHO
the minimum changes before -rc1.
Peter Korsgaard (107):
support/testing: drop python2 tests
package/python: drop target package
package/alsa-lib: drop python2 support
package/bmap-tools: drop python2 support
package/boost: drop python2 support
package/cifs-utils: drop python2 support
package/cracklib: move python support to python3
package/crudini: drop python2 support
package/dbus-python: drop python2 support
package/docker-compose: drop reference to BR2_PACKAGE_PYTHON
package/dstat: drop python2 support
package/evemu: drop python2 support
package/fail2ban: drop python2 support
package/glsandbox-player: drop reference to python2
package/gpsd: drop python2 support
package/gst1-devtools: drop python2 support
package/i2c-tools: drop python2 support
package/iotop: drop python2 support
package/jack2: drop python2 support
package/kmod: drop python2 support
package/libcec: drop python2 support
package/libevent: drop python2 support
package/libftdi1: drop python2 support
package/libiio: drop python2 support
package/libpwquality: drop python2 support
package/libsigrokdecode: drop reference to python2
package/libsoc: drop python2 support
package/lttng-libust: drop python2 support
package/networkd-dispatcher: drop reference to python2
package/nftables: drop python2 support
package/ogre: drop python2 support
package/opkg-utils: drop reference to python2
package/owfs: drop python support
package/python-aenum: drop python2 support
package/python-argon2-cffi: drop python2 support
package/python-bsdiff4: drop python2 support
package/python-can: drop python2 support
package/python-couchdb: drop python2 support
package/python-dicttoxml: drop python2 support
package/python-dpkt: drop python2 support
package/python-esptool: drop python2 support
package/python-fire: drop python2 support
package/python-flask: drop python2 support
package/python-jsonschema: drop python2 support
package/python-libconfig: drop python2 support
package/python-logbook: drop python2 support
package/python-lxml: drop python2 support
package/python-m2crypto: drop python2 support
package/python-pexpect: drop python2 support
package/python-pickleshare: drop python2 support
package/python-pymodbus: drop python2 support
package/python-pyqrcode: drop python2 support
package/python-pyqt5: drop python2 support
package/python-pyroute2: drop python2 support
package/python-pyudev: drop python2 support
package/python-raven: drop python2 support
package/python-reentry: drop python2 support
package/python-remi: drop python2 support
package/python-scapy: drop python2 support
package/python-sentry-sdk: drop python2 support
package/python-setuptools: drop python2 support
package/python-sip: drop python2 support
package/python-txtorcon: drop python2 support
package/python-typing-extensions: drop python2 support
package/python-urllib3: drop python2 support
package/python-web2py: drop python2 support
package/python-webob: drop python2 support
package/python-websocket-client: drop python2 support
package/python-werkzeug: drop python2 support
package/python-whoosh: drop python2 support
package/python-xlrd: drop python2 support
package/python-xmltodict: drop python2 support
package/python3: drop references to python2
package/ranger: drop python2 support
package/selinux-python: drop reference to python2
package/snmpclitools: drop python2 support
package/supervisor: drop python2 support
package/suricata: drop python2 support
package/syslog-ng: drop python2 support
package/tovid: drop python2 support
package/trace-cmd: drop python2 support
package/util-linux: drop python2 support
package/zfs: drop python2 support
package/python: drop host package
package/python-backports-abc: drop python2 specific package
package/python-backports-shutil-get-terminal-size: drop python2
specific package
package/python-backports-ssl-match-hostname: drop python2 specific
package
package/python-futures: drop python2 specific package
package/python-id3: drop python2 specific package
package/python-ipaddr: drop python2 specific package
package/python-ipaddress: drop python2 specific package
package/python-mad: drop python2 specific package
package/python-nfc: drop python2 specific package
package/python-pam: drop python2 specific package
package/python-pathlib2: drop python2 specific package
package/python-pypcap: drop python2 specific package
package/python-pyro: drop python2 specific package
package/python-singledispatch: drop python2 specific package
package/python-subprocess32: drop python2 specific package
package/python-typing: drop python2 specific package
package/python-yieldfrom: drop python2 specific package
package/python-configobj: drop python2 specific package
package/python-dialog: drop python2 specific package
package/python-enum: drop python2 specific package
package/python-enum34: drop python2 specific package
package/python-functools32: drop python2 specific package
docs/manual: drop python2 references
Config.in.legacy | 140 ++++++++
DEVELOPERS | 15 -
docs/manual/adding-packages-python.txt | 8 -
docs/manual/writing-rules.txt | 8 +-
package/Config.in | 25 +-
package/Config.in.host | 1 -
package/alsa-lib/Config.in | 2 +-
package/alsa-lib/alsa-lib.mk | 11 +-
package/bmap-tools/Config.in | 5 +-
package/boost/Config.in | 2 +-
package/boost/boost.mk | 11 +-
package/cifs-utils/Config.in | 2 +-
package/cracklib/cracklib.mk | 7 +-
package/crudini/Config.in | 2 +-
package/dbus-python/Config.in | 8 +-
package/dbus-python/dbus-python.mk | 28 +-
package/docker-compose/Config.in | 9 +-
package/dstat/Config.in | 10 +-
package/evemu/evemu.mk | 4 +-
package/fail2ban/Config.in | 2 +-
package/fail2ban/fail2ban.mk | 7 +-
package/glslsandbox-player/Config.in | 1 -
package/gpsd/Config.in | 4 +-
package/gpsd/gpsd.mk | 4 -
package/gstreamer1/gst1-devtools/Config.in | 6 +-
package/i2c-tools/i2c-tools.mk | 8 +-
package/iotop/Config.in | 9 +-
package/jack2/Config.in | 5 +-
package/kmod/kmod.mk | 4 +-
package/libcec/libcec.mk | 4 +-
package/libevent/libevent.mk | 2 +-
package/libftdi1/Config.in | 2 +-
package/libftdi1/libftdi1.mk | 2 +-
package/libiio/Config.in | 2 +-
package/libiio/libiio.mk | 10 +-
package/libpwquality/libpwquality.mk | 4 +-
package/libsigrokdecode/Config.in | 6 -
package/libsoc/libsoc.mk | 6 +-
package/lttng-libust/lttng-libust.mk | 5 +-
package/networkd-dispatcher/Config.in | 2 -
package/nftables/nftables.mk | 4 +-
package/ogre/ogre.mk | 5 +-
package/opkg-utils/Config.in | 6 -
package/owfs/owfs.mk | 24 +-
package/python-aenum/python-aenum.mk | 9 -
package/python-argon2-cffi/Config.in | 1 -
package/python-backports-abc/Config.in | 8 -
.../python-backports-abc.hash | 5 -
.../python-backports-abc.mk | 14 -
.../Config.in | 8 -
...on-backports-shutil-get-terminal-size.hash | 5 -
...thon-backports-shutil-get-terminal-size.mk | 14 -
.../Config.in | 7 -
.../python-backports-ssl-match-hostname.hash | 5 -
.../python-backports-ssl-match-hostname.mk | 14 -
package/python-bsdiff4/Config.in | 3 +-
package/python-can/Config.in | 7 +-
package/python-configobj/Config.in | 10 -
.../python-configobj/python-configobj.hash | 3 -
package/python-configobj/python-configobj.mk | 14 -
package/python-couchdb/Config.in | 3 +-
package/python-dialog/Config.in | 10 -
package/python-dialog/python-dialog.hash | 5 -
package/python-dialog/python-dialog.mk | 15 -
package/python-dicttoxml/Config.in | 3 +-
package/python-dpkt/Config.in | 3 +-
package/python-enum/Config.in | 12 -
package/python-enum/python-enum.hash | 5 -
package/python-enum/python-enum.mk | 14 -
package/python-enum34/Config.in | 12 -
package/python-enum34/python-enum34.hash | 5 -
package/python-enum34/python-enum34.mk | 17 -
package/python-esptool/Config.in | 3 +-
package/python-fire/Config.in | 1 -
package/python-fire/python-fire.mk | 9 -
package/python-flask/Config.in | 7 +-
package/python-functools32/Config.in | 8 -
.../python-functools32.hash | 4 -
.../python-functools32/python-functools32.mk | 14 -
package/python-futures/Config.in | 7 -
package/python-futures/python-futures.hash | 5 -
package/python-futures/python-futures.mk | 14 -
package/python-id3/Config.in | 9 -
package/python-id3/python-id3.hash | 3 -
package/python-id3/python-id3.mk | 14 -
package/python-ipaddr/Config.in | 9 -
package/python-ipaddr/python-ipaddr.hash | 5 -
package/python-ipaddr/python-ipaddr.mk | 14 -
package/python-ipaddress/Config.in | 7 -
.../python-ipaddress/python-ipaddress.hash | 5 -
package/python-ipaddress/python-ipaddress.mk | 14 -
package/python-jsonschema/Config.in | 1 -
package/python-libconfig/python-libconfig.mk | 8 +-
package/python-logbook/Config.in | 3 +-
package/python-lxml/Config.in | 3 +-
package/python-m2crypto/Config.in | 7 +-
package/python-mad/Config.in | 9 -
package/python-mad/python-mad.hash | 3 -
package/python-mad/python-mad.mk | 29 --
package/python-nfc/Config.in | 16 -
package/python-nfc/python-nfc.hash | 3 -
package/python-nfc/python-nfc.mk | 14 -
package/python-pam/0001-dealloc.patch | 25 --
package/python-pam/0002-nofree.patch | 68 ----
.../0003-memory-errors-CVE2012-1502.patch | 136 --------
package/python-pam/Config.in | 16 -
package/python-pam/python-pam.hash | 3 -
package/python-pam/python-pam.mk | 16 -
package/python-pathlib2/Config.in | 13 -
package/python-pathlib2/python-pathlib2.hash | 5 -
package/python-pathlib2/python-pathlib2.mk | 14 -
package/python-pexpect/python-pexpect.mk | 10 -
package/python-pickleshare/Config.in | 1 -
package/python-pymodbus/python-pymodbus.mk | 9 -
package/python-pypcap/Config.in | 9 -
package/python-pypcap/python-pypcap.hash | 3 -
package/python-pypcap/python-pypcap.mk | 21 --
package/python-pyqrcode/Config.in | 6 +-
package/python-pyqt5/python-pyqt5.mk | 14 +-
package/python-pyro/Config.in | 10 -
package/python-pyro/python-pyro.hash | 5 -
package/python-pyro/python-pyro.mk | 16 -
package/python-pyroute2/Config.in | 3 +-
package/python-pyudev/Config.in | 3 +-
package/python-raven/Config.in | 9 +-
package/python-reentry/Config.in | 1 -
package/python-remi/Config.in | 3 +-
package/python-scapy/Config.in | 3 +-
.../python-sentry-sdk/python-sentry-sdk.mk | 10 -
package/python-setuptools/Config.in | 6 +-
.../python-setuptools/python-setuptools.mk | 16 -
package/python-singledispatch/Config.in | 9 -
.../python-singledispatch.hash | 5 -
.../python-singledispatch.mk | 14 -
package/python-sip/python-sip.mk | 19 +-
package/python-subprocess32/Config.in | 13 -
.../python-subprocess32.hash | 5 -
.../python-subprocess32.mk | 31 --
package/python-txtorcon/python-txtorcon.mk | 9 -
package/python-typing-extensions/Config.in | 1 -
package/python-typing/Config.in | 8 -
package/python-typing/python-typing.hash | 5 -
package/python-typing/python-typing.mk | 15 -
package/python-urllib3/Config.in | 3 +-
package/python-web2py/Config.in | 9 +-
package/python-webob/Config.in | 4 +-
package/python-websocket-client/Config.in | 3 +-
package/python-werkzeug/Config.in | 3 +-
package/python-whoosh/Config.in | 3 +-
package/python-xlrd/Config.in | 6 +-
package/python-xmltodict/Config.in | 3 +-
package/python-yieldfrom/Config.in | 8 -
.../python-yieldfrom/python-yieldfrom.hash | 5 -
package/python-yieldfrom/python-yieldfrom.mk | 15 -
...-do-not-add-invalid-header-locations.patch | 42 ---
...get_python_inc-for-cross-compilation.patch | 48 ---
...nstall-location-of-_sysconfigdata.py.patch | 88 -----
...ilation-of-.pyc-and-.pyo-conditional.patch | 78 -----
...taddrinfo-test-for-cross-compilation.patch | 31 --
...astructure-to-be-able-to-disable-ext.patch | 81 -----
...y-header-paths-for-cross-compilation.patch | 64 ----
...ook-in-usr-lib-termcap-for-libraries.patch | 31 --
...9-Fix-python-config-for-cross-builds.patch | 229 -------------
...ove-the-python-symlink-install-rules.patch | 43 ---
.../0011-Don-t-add-multiarch-paths.patch | 36 ---
.../0012-Abort-on-failed-module-build.patch | 30 --
...d-when-threads-are-not-used-availabl.patch | 58 ----
.../python/0014-Serial-ioctl-workaround.patch | 33 --
...e-shebang-of-Python-scripts-for-cros.patch | 35 --
...-disable-installation-of-test-module.patch | 105 ------
.../0017-Add-an-option-to-disable-pydoc.patch | 89 ------
...018-Add-an-option-to-disable-lib2to3.patch | 92 ------
...option-to-disable-the-sqlite3-module.patch | 69 ----
...d-an-option-to-disable-the-tk-module.patch | 73 -----
...-option-to-disable-the-curses-module.patch | 61 ----
.../0022-Add-an-option-to-disable-expat.patch | 92 ------
...-Add-an-option-to-disable-CJK-codecs.patch | 32 --
.../0024-Add-an-option-to-disable-NIS.patch | 35 --
...Add-an-option-to-disable-unicodedata.patch | 32 --
.../0026-Add-an-option-to-disable-bsddb.patch | 87 -----
...-an-option-to-disable-the-ssl-module.patch | 32 --
...-an-option-to-disable-the-bz2-module.patch | 32 --
...an-option-to-disable-the-zlib-module.patch | 32 --
.../0030-Do-not-install-the-idle-editor.patch | 55 ----
...on-to-disable-the-ossaudiodev-module.patch | 32 --
...option-to-disable-the-hashlib-module.patch | 32 --
...an-option-to-disable-readline-module.patch | 32 --
...locale-and-set-to-default-when-addin.patch | 37 ---
package/python/Config.in | 139 --------
package/python/Config.in.host | 16 -
package/python/python.hash | 5 -
package/python/python.mk | 302 ------------------
package/python3/Config.in | 1 -
package/python3/python3.mk | 2 -
package/ranger/Config.in | 5 +-
package/selinux-python/Config.in | 5 -
package/snmpclitools/Config.in | 2 +-
package/supervisor/Config.in | 3 +-
package/suricata/suricata.mk | 4 +-
package/syslog-ng/syslog-ng.mk | 7 +-
package/tovid/Config.in | 6 +-
package/trace-cmd/trace-cmd.mk | 5 +-
package/util-linux/util-linux.mk | 4 +-
package/zfs/zfs.mk | 12 +-
.../package/sample_python_subprocess32.py | 6 -
.../testing/tests/package/test_bmap_tools.py | 8 -
support/testing/tests/package/test_crudini.py | 8 -
.../testing/tests/package/test_libftdi1.py | 12 -
support/testing/tests/package/test_python.py | 14 -
.../testing/tests/package/test_python_argh.py | 9 -
.../tests/package/test_python_bitstring.py | 10 -
.../testing/tests/package/test_python_can.py | 11 -
.../testing/tests/package/test_python_cbor.py | 11 -
.../tests/package/test_python_click.py | 9 -
.../tests/package/test_python_constantly.py | 10 -
.../tests/package/test_python_gnupg.py | 10 -
.../tests/package/test_python_incremental.py | 11 -
.../tests/package/test_python_passlib.py | 11 -
.../tests/package/test_python_pexpect.py | 10 -
.../tests/package/test_python_pynacl.py | 11 -
.../tests/package/test_python_pyyaml.py | 11 -
.../tests/package/test_python_subprocess32.py | 11 -
.../tests/package/test_python_ubjson.py | 11 -
223 files changed, 270 insertions(+), 3981 deletions(-)
delete mode 100644 package/python-backports-abc/Config.in
delete mode 100644 package/python-backports-abc/python-backports-abc.hash
delete mode 100644 package/python-backports-abc/python-backports-abc.mk
delete mode 100644 package/python-backports-shutil-get-terminal-size/Config.in
delete mode 100644 package/python-backports-shutil-get-terminal-size/python-backports-shutil-get-terminal-size.hash
delete mode 100644 package/python-backports-shutil-get-terminal-size/python-backports-shutil-get-terminal-size.mk
delete mode 100644 package/python-backports-ssl-match-hostname/Config.in
delete mode 100644 package/python-backports-ssl-match-hostname/python-backports-ssl-match-hostname.hash
delete mode 100644 package/python-backports-ssl-match-hostname/python-backports-ssl-match-hostname.mk
delete mode 100644 package/python-configobj/Config.in
delete mode 100644 package/python-configobj/python-configobj.hash
delete mode 100644 package/python-configobj/python-configobj.mk
delete mode 100644 package/python-dialog/Config.in
delete mode 100644 package/python-dialog/python-dialog.hash
delete mode 100644 package/python-dialog/python-dialog.mk
delete mode 100644 package/python-enum/Config.in
delete mode 100644 package/python-enum/python-enum.hash
delete mode 100644 package/python-enum/python-enum.mk
delete mode 100644 package/python-enum34/Config.in
delete mode 100644 package/python-enum34/python-enum34.hash
delete mode 100644 package/python-enum34/python-enum34.mk
delete mode 100644 package/python-functools32/Config.in
delete mode 100644 package/python-functools32/python-functools32.hash
delete mode 100644 package/python-functools32/python-functools32.mk
delete mode 100644 package/python-futures/Config.in
delete mode 100644 package/python-futures/python-futures.hash
delete mode 100644 package/python-futures/python-futures.mk
delete mode 100644 package/python-id3/Config.in
delete mode 100644 package/python-id3/python-id3.hash
delete mode 100644 package/python-id3/python-id3.mk
delete mode 100644 package/python-ipaddr/Config.in
delete mode 100644 package/python-ipaddr/python-ipaddr.hash
delete mode 100644 package/python-ipaddr/python-ipaddr.mk
delete mode 100644 package/python-ipaddress/Config.in
delete mode 100644 package/python-ipaddress/python-ipaddress.hash
delete mode 100644 package/python-ipaddress/python-ipaddress.mk
delete mode 100644 package/python-mad/Config.in
delete mode 100644 package/python-mad/python-mad.hash
delete mode 100644 package/python-mad/python-mad.mk
delete mode 100644 package/python-nfc/Config.in
delete mode 100644 package/python-nfc/python-nfc.hash
delete mode 100644 package/python-nfc/python-nfc.mk
delete mode 100644 package/python-pam/0001-dealloc.patch
delete mode 100644 package/python-pam/0002-nofree.patch
delete mode 100644 package/python-pam/0003-memory-errors-CVE2012-1502.patch
delete mode 100644 package/python-pam/Config.in
delete mode 100644 package/python-pam/python-pam.hash
delete mode 100644 package/python-pam/python-pam.mk
delete mode 100644 package/python-pathlib2/Config.in
delete mode 100644 package/python-pathlib2/python-pathlib2.hash
delete mode 100644 package/python-pathlib2/python-pathlib2.mk
delete mode 100644 package/python-pypcap/Config.in
delete mode 100644 package/python-pypcap/python-pypcap.hash
delete mode 100644 package/python-pypcap/python-pypcap.mk
delete mode 100644 package/python-pyro/Config.in
delete mode 100644 package/python-pyro/python-pyro.hash
delete mode 100644 package/python-pyro/python-pyro.mk
delete mode 100644 package/python-singledispatch/Config.in
delete mode 100644 package/python-singledispatch/python-singledispatch.hash
delete mode 100644 package/python-singledispatch/python-singledispatch.mk
delete mode 100644 package/python-subprocess32/Config.in
delete mode 100644 package/python-subprocess32/python-subprocess32.hash
delete mode 100644 package/python-subprocess32/python-subprocess32.mk
delete mode 100644 package/python-typing/Config.in
delete mode 100644 package/python-typing/python-typing.hash
delete mode 100644 package/python-typing/python-typing.mk
delete mode 100644 package/python-yieldfrom/Config.in
delete mode 100644 package/python-yieldfrom/python-yieldfrom.hash
delete mode 100644 package/python-yieldfrom/python-yieldfrom.mk
delete mode 100644 package/python/0001-setup.py-do-not-add-invalid-header-locations.patch
delete mode 100644 package/python/0002-Fix-get_python_inc-for-cross-compilation.patch
delete mode 100644 package/python/0003-Change-the-install-location-of-_sysconfigdata.py.patch
delete mode 100644 package/python/0004-Make-the-compilation-of-.pyc-and-.pyo-conditional.patch
delete mode 100644 package/python/0005-Adjust-getaddrinfo-test-for-cross-compilation.patch
delete mode 100644 package/python/0006-Add-minimal-infrastructure-to-be-able-to-disable-ext.patch
delete mode 100644 package/python/0007-Adjust-library-header-paths-for-cross-compilation.patch
delete mode 100644 package/python/0008-Don-t-look-in-usr-lib-termcap-for-libraries.patch
delete mode 100644 package/python/0009-Fix-python-config-for-cross-builds.patch
delete mode 100644 package/python/0010-Remove-the-python-symlink-install-rules.patch
delete mode 100644 package/python/0011-Don-t-add-multiarch-paths.patch
delete mode 100644 package/python/0012-Abort-on-failed-module-build.patch
delete mode 100644 package/python/0013-sqlite3-fix-build-when-threads-are-not-used-availabl.patch
delete mode 100644 package/python/0014-Serial-ioctl-workaround.patch
delete mode 100644 package/python/0015-Do-not-adjust-the-shebang-of-Python-scripts-for-cros.patch
delete mode 100644 package/python/0016-Add-an-option-to-disable-installation-of-test-module.patch
delete mode 100644 package/python/0017-Add-an-option-to-disable-pydoc.patch
delete mode 100644 package/python/0018-Add-an-option-to-disable-lib2to3.patch
delete mode 100644 package/python/0019-Add-option-to-disable-the-sqlite3-module.patch
delete mode 100644 package/python/0020-Add-an-option-to-disable-the-tk-module.patch
delete mode 100644 package/python/0021-Add-an-option-to-disable-the-curses-module.patch
delete mode 100644 package/python/0022-Add-an-option-to-disable-expat.patch
delete mode 100644 package/python/0023-Add-an-option-to-disable-CJK-codecs.patch
delete mode 100644 package/python/0024-Add-an-option-to-disable-NIS.patch
delete mode 100644 package/python/0025-Add-an-option-to-disable-unicodedata.patch
delete mode 100644 package/python/0026-Add-an-option-to-disable-bsddb.patch
delete mode 100644 package/python/0027-Add-an-option-to-disable-the-ssl-module.patch
delete mode 100644 package/python/0028-Add-an-option-to-disable-the-bz2-module.patch
delete mode 100644 package/python/0029-Add-an-option-to-disable-the-zlib-module.patch
delete mode 100644 package/python/0030-Do-not-install-the-idle-editor.patch
delete mode 100644 package/python/0031-Add-an-option-to-disable-the-ossaudiodev-module.patch
delete mode 100644 package/python/0032-Add-option-to-disable-the-hashlib-module.patch
delete mode 100644 package/python/0033-Add-an-option-to-disable-readline-module.patch
delete mode 100644 package/python/0034-Override-system-locale-and-set-to-default-when-addin.patch
delete mode 100644 package/python/Config.in
delete mode 100644 package/python/Config.in.host
delete mode 100644 package/python/python.hash
delete mode 100644 package/python/python.mk
delete mode 100644 support/testing/tests/package/sample_python_subprocess32.py
delete mode 100644 support/testing/tests/package/test_python_subprocess32.py
--
2.20.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-02-10 21:59 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <mailman.6747.1644442447.66748.buildroot@buildroot.org>
2022-02-10 6:42 ` [Buildroot] [PATCH 000/107] Drop python 2.7 Andreas Ziegler
2022-02-10 7:24 ` Peter Korsgaard
2022-02-10 7:56 ` Andreas Ziegler
2022-02-09 16:50 Peter Korsgaard
2022-02-09 21:33 ` Yann E. MORIN
2022-02-10 17:15 ` Arnout Vandecappelle
2022-02-10 17:31 ` Marcus Hoffmann
2022-02-10 21:55 ` Peter Korsgaard
2022-02-10 20:37 ` Yann E. MORIN
2022-02-10 21:18 ` Peter Korsgaard
2022-02-10 21:59 ` James Hilliard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.