All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions
@ 2017-05-22  6:54 ` SF Markus Elfring
  0 siblings, 0 replies; 5+ messages in thread
From: SF Markus Elfring @ 2017-05-22  6:54 UTC (permalink / raw)
  To: linux-bluetooth, netdev, David S. Miller, Gustavo Padovan,
	Johan Hedberg, Marcel Holtmann
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 22 May 2017 08:42:28 +0200

Omit two extra messages for memory allocation failures in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/bluetooth/ecdh_helper.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
index 24d4e60f8c48..c7b1a9aee579 100644
--- a/net/bluetooth/ecdh_helper.c
+++ b/net/bluetooth/ecdh_helper.c
@@ -92,8 +92,6 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8 private_key[32],
-	if (!buf) {
-		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-		       buf_len);
+	if (!buf)
 		goto free_req;
-	}
+
 	crypto_ecdh_encode_key(buf, buf_len, &p);
 
 	/* Set A private Key */
@@ -173,8 +171,5 @@ bool generate_ecdh_keys(u8 public_key[64], u8 private_key[32])
-	if (!buf) {
-		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-		       buf_len);
+	if (!buf)
 		goto free_req;
-	}
 
 	do {
 		if (tries++ >= max_tries)
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions
@ 2017-05-22  6:54 ` SF Markus Elfring
  0 siblings, 0 replies; 5+ messages in thread
From: SF Markus Elfring @ 2017-05-22  6:54 UTC (permalink / raw)
  To: linux-bluetooth, netdev, David S. Miller, Gustavo Padovan,
	Johan Hedberg, Marcel Holtmann
  Cc: LKML, kernel-janitors

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 22 May 2017 08:42:28 +0200

Omit two extra messages for memory allocation failures in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 net/bluetooth/ecdh_helper.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/net/bluetooth/ecdh_helper.c b/net/bluetooth/ecdh_helper.c
index 24d4e60f8c48..c7b1a9aee579 100644
--- a/net/bluetooth/ecdh_helper.c
+++ b/net/bluetooth/ecdh_helper.c
@@ -92,8 +92,6 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8 private_key[32],
-	if (!buf) {
-		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-		       buf_len);
+	if (!buf)
 		goto free_req;
-	}
+
 	crypto_ecdh_encode_key(buf, buf_len, &p);
 
 	/* Set A private Key */
@@ -173,8 +171,5 @@ bool generate_ecdh_keys(u8 public_key[64], u8 private_key[32])
-	if (!buf) {
-		pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-		       buf_len);
+	if (!buf)
 		goto free_req;
-	}
 
 	do {
 		if (tries++ >= max_tries)
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions
@ 2017-05-22  8:25   ` Marcel Holtmann
  0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2017-05-22  8:25 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: open list:BLUETOOTH DRIVERS, Network Development,
	David S. Miller, Gustavo F. Padovan, Johan Hedberg, LKML,
	kernel-janitors

Hallo Markus,

> Omit two extra messages for memory allocation failures in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> net/bluetooth/ecdh_helper.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions
@ 2017-05-22  8:25   ` Marcel Holtmann
  0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2017-05-22  8:25 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: open list:BLUETOOTH DRIVERS, Network Development,
	David S. Miller, Gustavo F. Padovan, Johan Hedberg, LKML,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA

Hallo Markus,

> Omit two extra messages for memory allocation failures in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> ---
> net/bluetooth/ecdh_helper.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions
@ 2017-05-22  8:25   ` Marcel Holtmann
  0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2017-05-22  8:25 UTC (permalink / raw)
  To: SF Markus Elfring
  Cc: open list:BLUETOOTH DRIVERS, Network Development,
	David S. Miller, Gustavo F. Padovan, Johan Hedberg, LKML,
	kernel-janitors

Hallo Markus,

> Omit two extra messages for memory allocation failures in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> net/bluetooth/ecdh_helper.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-22  8:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22  6:54 [PATCH] Bluetooth: Delete error messages for failed memory allocations in two functions SF Markus Elfring
2017-05-22  6:54 ` SF Markus Elfring
2017-05-22  8:25 ` Marcel Holtmann
2017-05-22  8:25   ` Marcel Holtmann
2017-05-22  8:25   ` Marcel Holtmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.