From: Markus Elfring <Markus.Elfring@web.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH v2] tools/bootconfig: Completion of error handling
Date: Fri, 8 May 2020 10:23:36 +0200 [thread overview]
Message-ID: <0b2612c1-28ca-2bb0-14f1-4befea09cede@web.de> (raw)
In-Reply-To: <189d719f-a8b8-6e10-ae2f-8120c3d2b7a9@huawei.com>
…
> +++ b/tools/bootconfig/main.c
> @@ -314,31 +314,33 @@ int apply_xbc(const char *path, const char *xbc_path)
…
> +close_fd:
> close(fd);
> +free_data:
> free(data);
…
Do you find unchecked return values from calls of functions like close()
and printf() suspicious?
https://cwe.mitre.org/data/definitions/252.html
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH v2] tools/bootconfig: Completion of error handling
Date: Fri, 08 May 2020 08:23:36 +0000 [thread overview]
Message-ID: <0b2612c1-28ca-2bb0-14f1-4befea09cede@web.de> (raw)
In-Reply-To: <189d719f-a8b8-6e10-ae2f-8120c3d2b7a9@huawei.com>
…
> +++ b/tools/bootconfig/main.c
> @@ -314,31 +314,33 @@ int apply_xbc(const char *path, const char *xbc_path)
…
> +close_fd:
> close(fd);
> +free_data:
> free(data);
…
Do you find unchecked return values from calls of functions like close()
and printf() suspicious?
https://cwe.mitre.org/data/definitions/252.html
Regards,
Markus
next prev parent reply other threads:[~2020-05-08 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:51 [PATCH v2] tools/bootconfig: fix resource leak in apply_xbc() Yunfeng Ye
2020-05-08 6:51 ` Yunfeng Ye
2020-05-08 8:23 ` Markus Elfring [this message]
2020-05-08 8:23 ` [PATCH v2] tools/bootconfig: Completion of error handling Markus Elfring
2020-05-08 9:30 ` [PATCH v2] tools/bootconfig: fix resource leak in apply_xbc() Dan Carpenter
2020-05-08 9:30 ` Dan Carpenter
2020-05-08 10:17 ` [v2] " Markus Elfring
2020-05-08 10:17 ` Markus Elfring
2020-05-08 10:32 ` [PATCH v2] " Yunfeng Ye
2020-05-08 10:32 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b2612c1-28ca-2bb0-14f1-4befea09cede@web.de \
--to=markus.elfring@web.de \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.