From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Cc: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>,
Doug Ledford <dledford@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations
Date: Wed, 19 May 2021 07:56:32 -0400 [thread overview]
Message-ID: <0b3cc247-b67b-6151-2a32-e4682ff9af22@cornelisnetworks.com> (raw)
In-Reply-To: <YKTDPm6j29jziSxT@unreal>
On 5/19/21 3:50 AM, Leon Romanovsky wrote:
> On Fri, May 14, 2021 at 12:02:37PM -0300, Jason Gunthorpe wrote:
>> On Fri, May 14, 2021 at 03:00:37PM +0000, Marciniszyn, Mike wrote:
>>>> The core stuff in ib_qp is not performance sensitive and has no obvious node
>>>> affinity since it relates primarily to simple control stuff.
>>>>
>>>
>>> The current rvt_qp "inherits" from ib_qp, so the fields in the
>>> "control" stuff are performance critical especially for receive
>>> processing and have historically live in the same allocation.
>>
>> This is why I said "core stuff in ib_qp" if drivers are adding
>> performance stuff to their own structs then that is the driver's
>> responsibility to handle.
>
> Can I learn from this response that node aware allocation is not needed,
> and this patch can go as is.
It's pretty clearly a NAK from us. The code was purposely written this
way, it was done years ago (from day 1 basically), changing it now is
concerning for performance.
Perhaps the code can be enhanced to move more stuff into the driver's
own structs as Jason points out, but that should happen first. For now I
still don't understand why the core can't optionally make the allocation
per node.
-Denny
next prev parent reply other threads:[~2021-05-19 11:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 10:36 [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations Leon Romanovsky
2021-05-11 10:59 ` Haakon Bugge
2021-05-11 12:34 ` Leon Romanovsky
2021-05-11 19:15 ` Marciniszyn, Mike
2021-05-11 19:27 ` Leon Romanovsky
2021-05-11 19:39 ` Marciniszyn, Mike
2021-05-12 4:08 ` Dennis Dalessandro
2021-05-12 12:13 ` Leon Romanovsky
2021-05-12 12:45 ` Dennis Dalessandro
2021-05-11 12:26 ` Dennis Dalessandro
2021-05-11 12:34 ` Leon Romanovsky
2021-05-12 12:25 ` Marciniszyn, Mike
2021-05-12 12:50 ` Leon Romanovsky
2021-05-13 19:03 ` Dennis Dalessandro
2021-05-13 19:15 ` Jason Gunthorpe
2021-05-13 19:31 ` Dennis Dalessandro
2021-05-14 13:02 ` Jason Gunthorpe
2021-05-14 14:07 ` Dennis Dalessandro
2021-05-14 14:35 ` Jason Gunthorpe
2021-05-14 15:00 ` Marciniszyn, Mike
2021-05-14 15:02 ` Jason Gunthorpe
2021-05-19 7:50 ` Leon Romanovsky
2021-05-19 11:56 ` Dennis Dalessandro [this message]
2021-05-19 18:29 ` Jason Gunthorpe
2021-05-19 19:49 ` Dennis Dalessandro
2021-05-19 20:26 ` Jason Gunthorpe
2021-05-20 22:02 ` Dennis Dalessandro
2021-05-21 6:29 ` Leon Romanovsky
2021-05-25 13:13 ` Jason Gunthorpe
2021-05-25 14:10 ` Dennis Dalessandro
2021-05-25 14:20 ` Jason Gunthorpe
2021-05-25 14:29 ` Dennis Dalessandro
2021-06-28 21:59 ` Marciniszyn, Mike
2021-06-28 23:19 ` Jason Gunthorpe
2021-07-04 6:34 ` Leon Romanovsky
2021-06-02 4:33 ` Leon Romanovsky
2021-05-16 10:56 ` Leon Romanovsky
2021-05-12 12:23 ` Marciniszyn, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b3cc247-b67b-6151-2a32-e4682ff9af22@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.