* [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines
@ 2017-10-09 11:51 Arvind Yadav
2017-10-09 12:33 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Arvind Yadav @ 2017-10-09 11:51 UTC (permalink / raw)
To: rui.zhang, edubezval; +Cc: linux-pm, linux-kernel
pr_err()/pr_info() messages should end with a new-line to avoid
other messages being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/thermal/intel_powerclamp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
index d718cd1..4540e89 100644
--- a/drivers/thermal/intel_powerclamp.c
+++ b/drivers/thermal/intel_powerclamp.c
@@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
{
if (!x86_match_cpu(intel_powerclamp_ids)) {
- pr_err("CPU does not support MWAIT");
+ pr_err("CPU does not support MWAIT\n");
return -ENODEV;
}
/* The goal for idle time alignment is to achieve package cstate. */
if (!has_pkg_state_counter()) {
- pr_info("No package C-state available");
+ pr_info("No package C-state available\n");
return -ENODEV;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines
2017-10-09 11:51 [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines Arvind Yadav
@ 2017-10-09 12:33 ` Daniel Lezcano
2017-10-10 4:37 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2017-10-09 12:33 UTC (permalink / raw)
To: Arvind Yadav, rui.zhang, edubezval; +Cc: linux-pm, linux-kernel
On 09/10/2017 13:51, Arvind Yadav wrote:
> pr_err()/pr_info() messages should end with a new-line to avoid
> other messages being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/thermal/intel_powerclamp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> index d718cd1..4540e89 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
> {
>
> if (!x86_match_cpu(intel_powerclamp_ids)) {
> - pr_err("CPU does not support MWAIT");
> + pr_err("CPU does not support MWAIT\n");
> return -ENODEV;
> }
>
> /* The goal for idle time alignment is to achieve package cstate. */
> if (!has_pkg_state_counter()) {
> - pr_info("No package C-state available");
> + pr_info("No package C-state available\n");
> return -ENODEV;
> }
Hi Arvind,
you are sending these fixes for all the drivers around. There is a way
to fix this once and for all: use the coccinelle tools [1], add the
script in the changelog with a big patchset and add the script in the
coccinelle scripts directory [2].
-- Daniel
[1] Documentation/dev-tools/coccinelle.rst
[2] scripts/coccinelle/misc
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines
2017-10-09 12:33 ` Daniel Lezcano
@ 2017-10-10 4:37 ` Joe Perches
2017-10-10 8:24 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-10-10 4:37 UTC (permalink / raw)
To: Daniel Lezcano, Arvind Yadav, rui.zhang, edubezval; +Cc: linux-pm, linux-kernel
On Mon, 2017-10-09 at 14:33 +0200, Daniel Lezcano wrote:
> On 09/10/2017 13:51, Arvind Yadav wrote:
> > pr_err()/pr_info() messages should end with a new-line to avoid
> > other messages being concatenated.
[]
> > diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> > @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
> > {
> >
> > if (!x86_match_cpu(intel_powerclamp_ids)) {
> > - pr_err("CPU does not support MWAIT");
> > + pr_err("CPU does not support MWAIT\n");
[etc...]
> Hi Arvind,
>
> you are sending these fixes for all the drivers around. There is a way
> to fix this once and for all: use the coccinelle tools [1], add the
> script in the changelog with a big patchset and add the script in the
> coccinelle scripts directory [2].
That can't work as any printk without a newline termination
could be followed by a printk(KERN_CONT/pr_cont( in another
function.
All of these must be hand-verified.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines
2017-10-10 4:37 ` Joe Perches
@ 2017-10-10 8:24 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2017-10-10 8:24 UTC (permalink / raw)
To: Joe Perches, Arvind Yadav, rui.zhang, edubezval; +Cc: linux-pm, linux-kernel
On 10/10/2017 06:37, Joe Perches wrote:
> On Mon, 2017-10-09 at 14:33 +0200, Daniel Lezcano wrote:
>> On 09/10/2017 13:51, Arvind Yadav wrote:
>>> pr_err()/pr_info() messages should end with a new-line to avoid
>>> other messages being concatenated.
> []
>>> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
>>> @@ -675,13 +675,13 @@ static int __init powerclamp_probe(void)
>>> {
>>>
>>> if (!x86_match_cpu(intel_powerclamp_ids)) {
>>> - pr_err("CPU does not support MWAIT");
>>> + pr_err("CPU does not support MWAIT\n");
>
> [etc...]
>
>> Hi Arvind,
>>
>> you are sending these fixes for all the drivers around. There is a way
>> to fix this once and for all: use the coccinelle tools [1], add the
>> script in the changelog with a big patchset and add the script in the
>> coccinelle scripts directory [2].
>
> That can't work as any printk without a newline termination
> could be followed by a printk(KERN_CONT/pr_cont( in another
> function.
>
> All of these must be hand-verified.
Ouch!
Fair enough. Thanks for the info.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-10 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-09 11:51 [PATCH] thermal/intel_powerclamp: pr_err()/pr_info() strings should end with newlines Arvind Yadav
2017-10-09 12:33 ` Daniel Lezcano
2017-10-10 4:37 ` Joe Perches
2017-10-10 8:24 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.