* [PATCH] clk: gpio: Add debug messages for clock ops
@ 2017-02-04 20:22 Sergej Sawazki
2017-02-06 19:41 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Sergej Sawazki @ 2017-02-04 20:22 UTC (permalink / raw)
To: mturquette, sboyd; +Cc: linux-clk, Sergej Sawazki, Jyri Sarha
Debug messages are helpful when debugging the clock tree setup.
Cc: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
---
drivers/clk/clk-gpio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
index 86b2457..012c289 100644
--- a/drivers/clk/clk-gpio.c
+++ b/drivers/clk/clk-gpio.c
@@ -38,6 +38,7 @@ static int clk_gpio_gate_enable(struct clk_hw *hw)
struct clk_gpio *clk = to_clk_gpio(hw);
gpiod_set_value(clk->gpiod, 1);
+ pr_debug("%s clock enabled\n", clk_hw_get_name(hw));
return 0;
}
@@ -47,6 +48,7 @@ static void clk_gpio_gate_disable(struct clk_hw *hw)
struct clk_gpio *clk = to_clk_gpio(hw);
gpiod_set_value(clk->gpiod, 0);
+ pr_debug("%s clock disabled\n", clk_hw_get_name(hw));
}
static int clk_gpio_gate_is_enabled(struct clk_hw *hw)
@@ -83,6 +85,7 @@ static int clk_gpio_mux_set_parent(struct clk_hw *hw, u8 index)
struct clk_gpio *clk = to_clk_gpio(hw);
gpiod_set_value(clk->gpiod, index);
+ pr_debug("%s set parent %d\n", clk_hw_get_name(hw), index);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: gpio: Add debug messages for clock ops
2017-02-04 20:22 [PATCH] clk: gpio: Add debug messages for clock ops Sergej Sawazki
@ 2017-02-06 19:41 ` Stephen Boyd
2017-02-06 20:46 ` Sergej Sawazki
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2017-02-06 19:41 UTC (permalink / raw)
To: Sergej Sawazki, mturquette; +Cc: linux-clk, Jyri Sarha
On 02/04/2017 12:22 PM, Sergej Sawazki wrote:
> Debug messages are helpful when debugging the clock tree setup.
>
> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
>
Can you use clk tracepoints instead?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: gpio: Add debug messages for clock ops
2017-02-06 19:41 ` Stephen Boyd
@ 2017-02-06 20:46 ` Sergej Sawazki
0 siblings, 0 replies; 3+ messages in thread
From: Sergej Sawazki @ 2017-02-06 20:46 UTC (permalink / raw)
To: Stephen Boyd, mturquette; +Cc: linux-clk, Jyri Sarha
On Mon, 6 Feb 2017 11:41:44 -0800, Stephen Boyd wrote:
> On 02/04/2017 12:22 PM, Sergej Sawazki wrote:
>> Debug messages are helpful when debugging the clock tree setup.
> Can you use clk tracepoints instead?
>
Probably yes, but I have been debugging the rest of the system with
the help of dynamic debug (dmesg) and found it pretty simple.
The si5351 driver, for example, has a lot dev_dbg()'s, which were
very helpful.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-04 20:22 [PATCH] clk: gpio: Add debug messages for clock ops Sergej Sawazki
2017-02-06 19:41 ` Stephen Boyd
2017-02-06 20:46 ` Sergej Sawazki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.