From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] arm64: dts: mt8183: Fix Mali GPU clock
Date: Mon, 23 May 2022 12:04:46 +0200 [thread overview]
Message-ID: <0b46efc0-bc06-5416-f24b-c53ff79736c8@collabora.com> (raw)
In-Reply-To: <20220523085923.1430470-2-wenst@chromium.org>
Il 23/05/22 10:59, Chen-Yu Tsai ha scritto:
> The actual clock feeding into the Mali GPU on the MT8183 is from the
> clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN
> block, which itself is simply a pass-through placeholder for the MFGPLL
> in the APMIXEDSYS block.
>
> Fix the hardware description with the correct clock reference.
>
> Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 01e650251928..6ced76a60aab 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 {
> <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>;
> interrupt-names = "job", "mmu", "gpu";
>
> - clocks = <&topckgen CLK_TOP_MFGPLL_CK>;
> + clocks = <&mfgcfg CLK_MFG_BG3D>;
>
> power-domains =
> <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] arm64: dts: mt8183: Fix Mali GPU clock
Date: Mon, 23 May 2022 12:04:46 +0200 [thread overview]
Message-ID: <0b46efc0-bc06-5416-f24b-c53ff79736c8@collabora.com> (raw)
In-Reply-To: <20220523085923.1430470-2-wenst@chromium.org>
Il 23/05/22 10:59, Chen-Yu Tsai ha scritto:
> The actual clock feeding into the Mali GPU on the MT8183 is from the
> clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN
> block, which itself is simply a pass-through placeholder for the MFGPLL
> in the APMIXEDSYS block.
>
> Fix the hardware description with the correct clock reference.
>
> Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 01e650251928..6ced76a60aab 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 {
> <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>;
> interrupt-names = "job", "mmu", "gpu";
>
> - clocks = <&topckgen CLK_TOP_MFGPLL_CK>;
> + clocks = <&mfgcfg CLK_MFG_BG3D>;
>
> power-domains =
> <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] arm64: dts: mt8183: Fix Mali GPU clock
Date: Mon, 23 May 2022 12:04:46 +0200 [thread overview]
Message-ID: <0b46efc0-bc06-5416-f24b-c53ff79736c8@collabora.com> (raw)
In-Reply-To: <20220523085923.1430470-2-wenst@chromium.org>
Il 23/05/22 10:59, Chen-Yu Tsai ha scritto:
> The actual clock feeding into the Mali GPU on the MT8183 is from the
> clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN
> block, which itself is simply a pass-through placeholder for the MFGPLL
> in the APMIXEDSYS block.
>
> Fix the hardware description with the correct clock reference.
>
> Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 01e650251928..6ced76a60aab 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 {
> <GIC_SPI 278 IRQ_TYPE_LEVEL_LOW>;
> interrupt-names = "job", "mmu", "gpu";
>
> - clocks = <&topckgen CLK_TOP_MFGPLL_CK>;
> + clocks = <&mfgcfg CLK_MFG_BG3D>;
>
> power-domains =
> <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 10:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 8:59 [PATCH v2 0/4] clk: mediatek: mt8183: Fix GPU/MFG clock rate changing Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` [PATCH v2 1/4] arm64: dts: mt8183: Fix Mali GPU clock Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 10:04 ` AngeloGioacchino Del Regno [this message]
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 8:59 ` [PATCH v2 2/4] clk: mediatek: mt8183: mfgcfg: Propagate rate changes to parent Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 8:59 ` [PATCH v2 3/4] clk: mediatek: mux: add clk notifier functions Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:04 ` AngeloGioacchino Del Regno
2022-05-23 10:20 ` Chen-Yu Tsai
2022-05-23 10:20 ` Chen-Yu Tsai
2022-05-23 10:20 ` Chen-Yu Tsai
2022-05-23 8:59 ` [PATCH v2 4/4] clk: mediatek: mt8183: Add clk mux notifier for MFG mux Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 8:59 ` Chen-Yu Tsai
2022-05-23 10:05 ` AngeloGioacchino Del Regno
2022-05-23 10:05 ` AngeloGioacchino Del Regno
2022-05-23 10:05 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b46efc0-bc06-5416-f24b-c53ff79736c8@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.