All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
@ 2016-10-18 10:39 ` Jeremy Kim
  2016-10-18 10:51   ` Jaehoon Chung
  0 siblings, 1 reply; 6+ messages in thread
From: Jeremy Kim @ 2016-10-18 10:39 UTC (permalink / raw)
  To: ulf.hansson, linux-mmc; +Cc: jh4u.kim


It is used for limitation of buffer size during IOCTL such as FFU. However,
eMMC FW size is bigger than (512L*256).
(For instance, currently, Samsung eMMC FW size is over 300KB.)
So, it needs to increase to execute FFU.


Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>
---
 ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ioctl.h b/ioctl.h
index 7e385b8..700a551 100644
--- a/ioctl.h
+++ b/ioctl.h
@@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
  * is enforced per ioctl call.  For larger data transfers, use the normal
  * block device operations.
  */
-#define MMC_IOC_MAX_BYTES  (512L * 256)
+#define MMC_IOC_MAX_BYTES  (512L * 1024)
 #define MMC_IOC_MAX_CMDS    255
 #endif /* LINUX_MMC_IOCTL_H */
--
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
  2016-10-18 10:39 ` [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES Jeremy Kim
@ 2016-10-18 10:51   ` Jaehoon Chung
  2016-10-18 10:54     ` Jeremy Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Jaehoon Chung @ 2016-10-18 10:51 UTC (permalink / raw)
  To: Jeremy Kim, ulf.hansson, linux-mmc

Hi,

On 10/18/2016 07:39 PM, Jeremy Kim wrote:
> 
> It is used for limitation of buffer size during IOCTL such as FFU. However,
> eMMC FW size is bigger than (512L*256).
> (For instance, currently, Samsung eMMC FW size is over 300KB.)
> So, it needs to increase to execute FFU.
> 
> 
> Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>
> ---
>  ioctl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Where is ioctl.h? "include/uapi/linux/mmc/ioctl.h"?

Best Regards,
Jaehoon Chung

> 
> diff --git a/ioctl.h b/ioctl.h
> index 7e385b8..700a551 100644
> --- a/ioctl.h
> +++ b/ioctl.h
> @@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
>   * is enforced per ioctl call.  For larger data transfers, use the normal
>   * block device operations.
>   */
> -#define MMC_IOC_MAX_BYTES  (512L * 256)
> +#define MMC_IOC_MAX_BYTES  (512L * 1024)
>  #define MMC_IOC_MAX_CMDS    255
>  #endif /* LINUX_MMC_IOCTL_H */
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
  2016-10-18 10:51   ` Jaehoon Chung
@ 2016-10-18 10:54     ` Jeremy Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Jeremy Kim @ 2016-10-18 10:54 UTC (permalink / raw)
  To: 'Jaehoon Chung', ulf.hansson, linux-mmc

Hi,

Yes, right. "include/uapi/linux/mmc/ioctl.h"


-----Original Message-----
From: linux-mmc-owner@vger.kernel.org
[mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Jaehoon Chung
Sent: Tuesday, October 18, 2016 7:52 PM
To: Jeremy Kim; ulf.hansson@linaro.org; linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES

Hi,

On 10/18/2016 07:39 PM, Jeremy Kim wrote:
> 
> It is used for limitation of buffer size during IOCTL such as FFU. 
> However, eMMC FW size is bigger than (512L*256).
> (For instance, currently, Samsung eMMC FW size is over 300KB.) So, it 
> needs to increase to execute FFU.
> 
> 
> Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>
> ---
>  ioctl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Where is ioctl.h? "include/uapi/linux/mmc/ioctl.h"?

Best Regards,
Jaehoon Chung

> 
> diff --git a/ioctl.h b/ioctl.h
> index 7e385b8..700a551 100644
> --- a/ioctl.h
> +++ b/ioctl.h
> @@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
>   * is enforced per ioctl call.  For larger data transfers, use the normal
>   * block device operations.
>   */
> -#define MMC_IOC_MAX_BYTES  (512L * 256)
> +#define MMC_IOC_MAX_BYTES  (512L * 1024)
>  #define MMC_IOC_MAX_CMDS    255
>  #endif /* LINUX_MMC_IOCTL_H */
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" 
> in the body of a message to majordomo@vger.kernel.org More majordomo 
> info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the
body of a message to majordomo@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
  2016-10-19 11:31 ` Jeremy Kim
  2016-10-21  6:38   ` Jaehoon Chung
@ 2016-10-21  8:21   ` Ulf Hansson
  1 sibling, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2016-10-21  8:21 UTC (permalink / raw)
  To: Jeremy Kim; +Cc: linux-mmc, Jaehoon Chung

On 19 October 2016 at 13:31, Jeremy Kim <jh4u.kim@samsung.com> wrote:
> From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001
> From: Jeonghan Kim <jh4u.kim@samsung.com>
> Date: Wed, 19 Oct 2016 19:48:02 +0900
> Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
>
> It is used for limitation of buffer size during IOCTL such as FFU.
> However, eMMC FW size is bigger than (512L*256).
> (For instance, currently, Samsung eMMC FW size is over 300KB.)
> So, it needs to increase to execute FFU.
>
> Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  include/uapi/linux/mmc/ioctl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h
> index 7e385b8..700a551 100644
> --- a/include/uapi/linux/mmc/ioctl.h
> +++ b/include/uapi/linux/mmc/ioctl.h
> @@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
>   * is enforced per ioctl call.  For larger data transfers, use the normal
>   * block device operations.
>   */
> -#define MMC_IOC_MAX_BYTES  (512L * 256)
> +#define MMC_IOC_MAX_BYTES  (512L * 1024)
>  #define MMC_IOC_MAX_CMDS    255
>  #endif /* LINUX_MMC_IOCTL_H */
> --
> 1.9.1
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
  2016-10-19 11:31 ` Jeremy Kim
@ 2016-10-21  6:38   ` Jaehoon Chung
  2016-10-21  8:21   ` Ulf Hansson
  1 sibling, 0 replies; 6+ messages in thread
From: Jaehoon Chung @ 2016-10-21  6:38 UTC (permalink / raw)
  To: Jeremy Kim, linux-mmc; +Cc: ulf.hansson

Hi,

On 10/19/2016 08:31 PM, Jeremy Kim wrote:
>>From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001
> From: Jeonghan Kim <jh4u.kim@samsung.com>
> Date: Wed, 19 Oct 2016 19:48:02 +0900
> Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
> 
> It is used for limitation of buffer size during IOCTL such as FFU.
> However, eMMC FW size is bigger than (512L*256).
> (For instance, currently, Samsung eMMC FW size is over 300KB.)
> So, it needs to increase to execute FFU.
> 
> Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>

Looks good to me.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  include/uapi/linux/mmc/ioctl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h
> index 7e385b8..700a551 100644
> --- a/include/uapi/linux/mmc/ioctl.h
> +++ b/include/uapi/linux/mmc/ioctl.h
> @@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
>   * is enforced per ioctl call.  For larger data transfers, use the normal
>   * block device operations.
>   */
> -#define MMC_IOC_MAX_BYTES  (512L * 256)
> +#define MMC_IOC_MAX_BYTES  (512L * 1024)
>  #define MMC_IOC_MAX_CMDS    255
>  #endif /* LINUX_MMC_IOCTL_H */
> --
> 1.9.1
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES
@ 2016-10-19 11:31 ` Jeremy Kim
  2016-10-21  6:38   ` Jaehoon Chung
  2016-10-21  8:21   ` Ulf Hansson
  0 siblings, 2 replies; 6+ messages in thread
From: Jeremy Kim @ 2016-10-19 11:31 UTC (permalink / raw)
  To: linux-mmc; +Cc: ulf.hansson, 'Jaehoon Chung'

>From 27d46f5697434542ad9cafbc6a9630dc14915f91 Mon Sep 17 00:00:00 2001
From: Jeonghan Kim <jh4u.kim@samsung.com>
Date: Wed, 19 Oct 2016 19:48:02 +0900
Subject: [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES

It is used for limitation of buffer size during IOCTL such as FFU.
However, eMMC FW size is bigger than (512L*256).
(For instance, currently, Samsung eMMC FW size is over 300KB.)
So, it needs to increase to execute FFU.

Signed-off-by: Jeonghan Kim <jh4u.kim@samsung.com>
---
 include/uapi/linux/mmc/ioctl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h
index 7e385b8..700a551 100644
--- a/include/uapi/linux/mmc/ioctl.h
+++ b/include/uapi/linux/mmc/ioctl.h
@@ -69,6 +69,6 @@ struct mmc_ioc_multi_cmd {
  * is enforced per ioctl call.  For larger data transfers, use the normal
  * block device operations.
  */
-#define MMC_IOC_MAX_BYTES  (512L * 256)
+#define MMC_IOC_MAX_BYTES  (512L * 1024)
 #define MMC_IOC_MAX_CMDS    255
 #endif /* LINUX_MMC_IOCTL_H */
--
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-21  8:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20161018103940epcas1p1da351e49f18c5707eea3b817a5d2f865@epcas1p1.samsung.com>
2016-10-18 10:39 ` [PATCH] mmc: block: Change MMC_IOC_MAX_BYTES Jeremy Kim
2016-10-18 10:51   ` Jaehoon Chung
2016-10-18 10:54     ` Jeremy Kim
     [not found] <CGME20161019113147epcas1p23270c03a8ea440a88dd0d6ab85af8051@epcas1p2.samsung.com>
2016-10-19 11:31 ` Jeremy Kim
2016-10-21  6:38   ` Jaehoon Chung
2016-10-21  8:21   ` Ulf Hansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.