All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Appana Durga Kedareswara rao 
	<appana.durga.kedareswara.rao@amd.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	michal.simek@xilinx.com, derek.kiernan@xilinx.com,
	dragan.cvetic@xilinx.com, arnd@arndb.de,
	gregkh@linuxfoundation.org
Cc: appanad@amd.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, git@amd.com,
	git@xilinx.com,
	Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager
Date: Wed, 20 Jul 2022 08:15:26 +0200	[thread overview]
Message-ID: <0bc494bc-8788-46e6-a485-cdefdb8682a4@linaro.org> (raw)
In-Reply-To: <20220720060016.1646317-2-appana.durga.kedareswara.rao@amd.com>

On 20/07/2022 08:00, Appana Durga Kedareswara rao wrote:
> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> 
> Triple Modular Redundancy(TMR) subsystem contains three microblaze cores,
> subsystem is fault-tolerant and continues to operate nominally after
> encountering an error. Together with the capability to detect and recover
> from errors, the implementation ensures the reliability of the entire
> subsystem.  TMR Manager is responsible for performing recovery of the
> subsystem detects the fault via a break signal it invokes microblaze
> software break handler which calls the tmr manager driver api to
> update the error count and status.
> 
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>

Use one identity, not two.

> ---
> Changes for v2:
> --> Improved description for xlnx,magic1 property as suggested by Krzysztof.
> --> Fixed style issues (indentation of example node title description
> etc..)
>  .../bindings/misc/xlnx,tmr-manager.yaml       | 47 +++++++++++++++++++

It's a pity it was put into misc, but since we did not reach consensus
during last discussion and there is no fault-handler-like subsystem yet,
we might move it there later:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Appana Durga Kedareswara rao
	<appana.durga.kedareswara.rao@amd.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	michal.simek@xilinx.com, derek.kiernan@xilinx.com,
	dragan.cvetic@xilinx.com, arnd@arndb.de,
	gregkh@linuxfoundation.org
Cc: appanad@amd.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, git@amd.com,
	git@xilinx.com,
	Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager
Date: Wed, 20 Jul 2022 08:15:26 +0200	[thread overview]
Message-ID: <0bc494bc-8788-46e6-a485-cdefdb8682a4@linaro.org> (raw)
In-Reply-To: <20220720060016.1646317-2-appana.durga.kedareswara.rao@amd.com>

On 20/07/2022 08:00, Appana Durga Kedareswara rao wrote:
> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> 
> Triple Modular Redundancy(TMR) subsystem contains three microblaze cores,
> subsystem is fault-tolerant and continues to operate nominally after
> encountering an error. Together with the capability to detect and recover
> from errors, the implementation ensures the reliability of the entire
> subsystem.  TMR Manager is responsible for performing recovery of the
> subsystem detects the fault via a break signal it invokes microblaze
> software break handler which calls the tmr manager driver api to
> update the error count and status.
> 
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.kedareswara.rao@amd.com>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>

Use one identity, not two.

> ---
> Changes for v2:
> --> Improved description for xlnx,magic1 property as suggested by Krzysztof.
> --> Fixed style issues (indentation of example node title description
> etc..)
>  .../bindings/misc/xlnx,tmr-manager.yaml       | 47 +++++++++++++++++++

It's a pity it was put into misc, but since we did not reach consensus
during last discussion and there is no fault-handler-like subsystem yet,
we might move it there later:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-20  6:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  6:00 [PATCH v2 0/4] drivers: misc: Add support for TMR Manager and Inject IPs Appana Durga Kedareswara rao
2022-07-20  6:00 ` Appana Durga Kedareswara rao
2022-07-20  6:00 ` [PATCH v2 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager Appana Durga Kedareswara rao
2022-07-20  6:00   ` Appana Durga Kedareswara rao
2022-07-20  6:15   ` Krzysztof Kozlowski [this message]
2022-07-20  6:15     ` Krzysztof Kozlowski
2022-07-20  6:00 ` [PATCH v2 2/4] drivers: misc: Add Support " Appana Durga Kedareswara rao
2022-07-20  6:00   ` Appana Durga Kedareswara rao
2022-07-28 14:27   ` Greg KH
2022-07-28 14:27     ` Greg KH
2022-07-29  8:13     ` Rao, Appana Durga Kedareswara
2022-07-29  8:13       ` Rao, Appana Durga Kedareswara
2022-07-20  6:00 ` [PATCH v2 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject Appana Durga Kedareswara rao
2022-07-20  6:00   ` Appana Durga Kedareswara rao
2022-07-20  6:15   ` Krzysztof Kozlowski
2022-07-20  6:15     ` Krzysztof Kozlowski
2022-07-20  8:26     ` Michal Simek
2022-07-20  8:26       ` Michal Simek
2022-07-20  9:35       ` Krzysztof Kozlowski
2022-07-20  9:35         ` Krzysztof Kozlowski
2022-07-20 12:09         ` Michal Simek
2022-07-20 12:09           ` Michal Simek
2022-07-20 12:21           ` Krzysztof Kozlowski
2022-07-20 12:21             ` Krzysztof Kozlowski
2022-07-20 12:35             ` Michal Simek
2022-07-20 12:35               ` Michal Simek
2022-07-20 13:21           ` Rao, Appana Durga Kedareswara
2022-07-20 13:21             ` Rao, Appana Durga Kedareswara
2022-07-20  6:00 ` [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP Appana Durga Kedareswara rao
2022-07-20  6:00   ` Appana Durga Kedareswara rao
2022-07-28 14:24   ` Greg KH
2022-07-28 14:24     ` Greg KH
2022-07-29  8:13     ` Rao, Appana Durga Kedareswara
2022-07-29  8:13       ` Rao, Appana Durga Kedareswara
2022-07-29  9:02       ` Greg KH
2022-07-29  9:02         ` Greg KH
2022-08-03  6:35         ` Rao, Appana Durga Kedareswara
2022-08-03  6:35           ` Rao, Appana Durga Kedareswara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bc494bc-8788-46e6-a485-cdefdb8682a4@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=appana.durga.kedareswara.rao@amd.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=appanad@amd.com \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=git@amd.com \
    --cc=git@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.