From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] mmc: meson-gx: disable HS400
Date: Tue, 30 Apr 2019 22:28:27 +0200 [thread overview]
Message-ID: <0bd1e9c25ab11112c9f2913c2cb3483e8802099d.camel@baylibre.com> (raw)
In-Reply-To: <CAFBinCBpujeLJHr0x9DxqLtRiLt0WLkkOoKcJuh3baWeg_bFeA@mail.gmail.com>
On Tue, 2019-04-30 at 22:02 +0200, Martin Blumenstingl wrote:
> > Thanks for effort but all this just maintain the blur around HS400 on amlogic.
> >
> > Let me rephrase it:
> > Tuning (phase or resampling) is meant to compensate the clock round trip in UHS
> > and HS200 modes. In HS400, this should be taken care of by the data strobe.
> > But we have not been to enable this reliably enable this on amlogic chipset ...
> I wasn't aware of this: so far I assumed that we're not setting the
> phase correctly, end of the story.
> thank you again for taking your time to explain this!
No worries. There is the MMC in general, I think I understand it a bit now but
I might still be mistaken about some stuff. Then there is the HW we have and the
related black magic.
I doubt this is the last update in this driver ...
>
> > ... and I believe we are back to the original commit message.
> no need to update the description just to explain how HS400 works in
> general, so feel free to use my:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 4/7] mmc: meson-gx: disable HS400
Date: Tue, 30 Apr 2019 22:28:27 +0200 [thread overview]
Message-ID: <0bd1e9c25ab11112c9f2913c2cb3483e8802099d.camel@baylibre.com> (raw)
In-Reply-To: <CAFBinCBpujeLJHr0x9DxqLtRiLt0WLkkOoKcJuh3baWeg_bFeA@mail.gmail.com>
On Tue, 2019-04-30 at 22:02 +0200, Martin Blumenstingl wrote:
> > Thanks for effort but all this just maintain the blur around HS400 on amlogic.
> >
> > Let me rephrase it:
> > Tuning (phase or resampling) is meant to compensate the clock round trip in UHS
> > and HS200 modes. In HS400, this should be taken care of by the data strobe.
> > But we have not been to enable this reliably enable this on amlogic chipset ...
> I wasn't aware of this: so far I assumed that we're not setting the
> phase correctly, end of the story.
> thank you again for taking your time to explain this!
No worries. There is the MMC in general, I think I understand it a bit now but
I might still be mistaken about some stuff. Then there is the HW we have and the
related black magic.
I doubt this is the last update in this driver ...
>
> > ... and I believe we are back to the original commit message.
> no need to update the description just to explain how HS400 works in
> general, so feel free to use my:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-30 20:28 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 9:02 [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 1/7] mmc: meson-gx: remove open coded read with timeout Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 2/7] mmc: meson-gx: ack only raised irq Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 19:53 ` Martin Blumenstingl
2019-04-27 19:53 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 3/7] mmc: meson-gx: correct irq flag Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 19:56 ` Martin Blumenstingl
2019-04-27 19:56 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 4/7] mmc: meson-gx: disable HS400 Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 20:02 ` Martin Blumenstingl
2019-04-27 20:02 ` Martin Blumenstingl
2019-04-29 8:29 ` Jerome Brunet
2019-04-29 8:29 ` Jerome Brunet
2019-04-29 18:31 ` Martin Blumenstingl
2019-04-29 18:31 ` Martin Blumenstingl
2019-04-29 18:50 ` Jerome Brunet
2019-04-29 18:50 ` Jerome Brunet
2019-04-30 20:02 ` Martin Blumenstingl
2019-04-30 20:02 ` Martin Blumenstingl
2019-04-30 20:28 ` Jerome Brunet [this message]
2019-04-30 20:28 ` Jerome Brunet
2019-04-23 9:02 ` [PATCH v2 5/7] mmc: meson-gx: avoid clock glitch when switching to DDR modes Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 20:03 ` Martin Blumenstingl
2019-04-27 20:03 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 6/7] mmc: meson-gx: remove Rx phase tuning Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 20:09 ` Martin Blumenstingl
2019-04-27 20:09 ` Martin Blumenstingl
2019-04-23 9:02 ` [PATCH v2 7/7] mmc: meson-gx: add signal resampling tuning Jerome Brunet
2019-04-23 9:02 ` Jerome Brunet
2019-04-27 20:09 ` Martin Blumenstingl
2019-04-27 20:09 ` Martin Blumenstingl
2019-04-29 10:44 ` [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update Ulf Hansson
2019-04-29 10:44 ` Ulf Hansson
2019-04-29 18:40 ` Martin Blumenstingl
2019-04-29 18:40 ` Martin Blumenstingl
2019-04-29 19:12 ` Kevin Hilman
2019-04-29 19:12 ` Kevin Hilman
2019-04-29 19:12 ` Kevin Hilman
2019-04-30 20:03 ` Martin Blumenstingl
2019-04-30 20:03 ` Martin Blumenstingl
2019-05-03 13:28 ` Ulf Hansson
2019-05-03 13:28 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd1e9c25ab11112c9f2913c2cb3483e8802099d.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.