All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-02 12:51 ` Milan P. Gandhi
  0 siblings, 0 replies; 15+ messages in thread
From: Milan P. Gandhi @ 2017-06-02 12:39 UTC (permalink / raw)
  To: Johannes Thumshirn, Julia Lawall, Dan Carpenter,
	Laurence Oberman, linux-scsi
  Cc: kernel-janitors

Simplify the check for return code of fcoe_if_init routine
in fcoe_init function such that we could eliminate need for
extra 'out_free' label and duplicate mutex_unlock statement.

Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
 drivers/scsi/fcoe/fcoe.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ea21e7b..a2cf3d0 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
 	fcoe_dev_setup();
 
 	rc = fcoe_if_init();
+	mutex_unlock(&fcoe_config_mutex);
+
 	if (rc)
-		goto out_free;
+		goto out_destroy;
 
-	mutex_unlock(&fcoe_config_mutex);
 	return 0;
 
-out_free:
-	mutex_unlock(&fcoe_config_mutex);
 out_destroy:
 	destroy_workqueue(fcoe_wq);
 	return rc;

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-02 12:51 ` Milan P. Gandhi
  0 siblings, 0 replies; 15+ messages in thread
From: Milan P. Gandhi @ 2017-06-02 12:51 UTC (permalink / raw)
  To: Johannes Thumshirn, Julia Lawall, Dan Carpenter,
	Laurence Oberman, linux-scsi
  Cc: kernel-janitors

Simplify the check for return code of fcoe_if_init routine
in fcoe_init function such that we could eliminate need for
extra 'out_free' label and duplicate mutex_unlock statement.

Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
 drivers/scsi/fcoe/fcoe.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ea21e7b..a2cf3d0 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
 	fcoe_dev_setup();
 
 	rc = fcoe_if_init();
+	mutex_unlock(&fcoe_config_mutex);
+
 	if (rc)
-		goto out_free;
+		goto out_destroy;
 
-	mutex_unlock(&fcoe_config_mutex);
 	return 0;
 
-out_free:
-	mutex_unlock(&fcoe_config_mutex);
 out_destroy:
 	destroy_workqueue(fcoe_wq);
 	return rc;

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 12:51 ` Milan P. Gandhi
@ 2017-06-02 13:01   ` walter harms
  -1 siblings, 0 replies; 15+ messages in thread
From: walter harms @ 2017-06-02 13:01 UTC (permalink / raw)
  To: mgandhi
  Cc: Johannes Thumshirn, Julia Lawall, Dan Carpenter,
	Laurence Oberman, linux-scsi, kernel-janitors



Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> Simplify the check for return code of fcoe_if_init routine
> in fcoe_init function such that we could eliminate need for
> extra 'out_free' label and duplicate mutex_unlock statement.
> 
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
>  drivers/scsi/fcoe/fcoe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ea21e7b..a2cf3d0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
>  	fcoe_dev_setup();
>  
>  	rc = fcoe_if_init();
> +	mutex_unlock(&fcoe_config_mutex);
> +
>  	if (rc)
> -		goto out_free;
> +		goto out_destroy;
>  
> -	mutex_unlock(&fcoe_config_mutex);
>  	return 0;
>  
if you do that, why not
if (!rc) return 0;

re,
 wh



> -out_free:
> -	mutex_unlock(&fcoe_config_mutex);
>  out_destroy:
>  	destroy_workqueue(fcoe_wq);
>  	return rc;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-02 13:01   ` walter harms
  0 siblings, 0 replies; 15+ messages in thread
From: walter harms @ 2017-06-02 13:01 UTC (permalink / raw)
  To: mgandhi
  Cc: Johannes Thumshirn, Julia Lawall, Dan Carpenter,
	Laurence Oberman, linux-scsi, kernel-janitors



Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> Simplify the check for return code of fcoe_if_init routine
> in fcoe_init function such that we could eliminate need for
> extra 'out_free' label and duplicate mutex_unlock statement.
> 
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
>  drivers/scsi/fcoe/fcoe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ea21e7b..a2cf3d0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
>  	fcoe_dev_setup();
>  
>  	rc = fcoe_if_init();
> +	mutex_unlock(&fcoe_config_mutex);
> +
>  	if (rc)
> -		goto out_free;
> +		goto out_destroy;
>  
> -	mutex_unlock(&fcoe_config_mutex);
>  	return 0;
>  
if you do that, why not
if (!rc) return 0;

re,
 wh



> -out_free:
> -	mutex_unlock(&fcoe_config_mutex);
>  out_destroy:
>  	destroy_workqueue(fcoe_wq);
>  	return rc;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 12:51 ` Milan P. Gandhi
@ 2017-06-02 16:06   ` Julia Lawall
  -1 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-06-02 16:06 UTC (permalink / raw)
  To: Milan P. Gandhi
  Cc: Johannes Thumshirn, Dan Carpenter, Laurence Oberman, linux-scsi,
	kernel-janitors



On Fri, 2 Jun 2017, Milan P. Gandhi wrote:

> Simplify the check for return code of fcoe_if_init routine
> in fcoe_init function such that we could eliminate need for
> extra 'out_free' label and duplicate mutex_unlock statement.
>
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
>  drivers/scsi/fcoe/fcoe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ea21e7b..a2cf3d0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
>  	fcoe_dev_setup();
>
>  	rc = fcoe_if_init();
> +	mutex_unlock(&fcoe_config_mutex);
> +
>  	if (rc)
> -		goto out_free;
> +		goto out_destroy;
>
> -	mutex_unlock(&fcoe_config_mutex);

That's what I was thinking of, but it's not a RESEND, but rather a v2.
You need to explain under the --- what is the change since the original
submission.

julia

>  	return 0;
>
> -out_free:
> -	mutex_unlock(&fcoe_config_mutex);
>  out_destroy:
>  	destroy_workqueue(fcoe_wq);
>  	return rc;
>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-02 16:06   ` Julia Lawall
  0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-06-02 16:06 UTC (permalink / raw)
  To: Milan P. Gandhi
  Cc: Johannes Thumshirn, Dan Carpenter, Laurence Oberman, linux-scsi,
	kernel-janitors



On Fri, 2 Jun 2017, Milan P. Gandhi wrote:

> Simplify the check for return code of fcoe_if_init routine
> in fcoe_init function such that we could eliminate need for
> extra 'out_free' label and duplicate mutex_unlock statement.
>
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
>  drivers/scsi/fcoe/fcoe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index ea21e7b..a2cf3d0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
>  	fcoe_dev_setup();
>
>  	rc = fcoe_if_init();
> +	mutex_unlock(&fcoe_config_mutex);
> +
>  	if (rc)
> -		goto out_free;
> +		goto out_destroy;
>
> -	mutex_unlock(&fcoe_config_mutex);

That's what I was thinking of, but it's not a RESEND, but rather a v2.
You need to explain under the --- what is the change since the original
submission.

julia

>  	return 0;
>
> -out_free:
> -	mutex_unlock(&fcoe_config_mutex);
>  out_destroy:
>  	destroy_workqueue(fcoe_wq);
>  	return rc;
>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 13:01   ` walter harms
@ 2017-06-02 16:07     ` Julia Lawall
  -1 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-06-02 16:07 UTC (permalink / raw)
  To: walter harms
  Cc: mgandhi, Johannes Thumshirn, Dan Carpenter, Laurence Oberman,
	linux-scsi, kernel-janitors



On Fri, 2 Jun 2017, walter harms wrote:

>
>
> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> > Simplify the check for return code of fcoe_if_init routine
> > in fcoe_init function such that we could eliminate need for
> > extra 'out_free' label and duplicate mutex_unlock statement.
> >
> > Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> > ---
> >  drivers/scsi/fcoe/fcoe.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> > index ea21e7b..a2cf3d0 100644
> > --- a/drivers/scsi/fcoe/fcoe.c
> > +++ b/drivers/scsi/fcoe/fcoe.c
> > @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
> >  	fcoe_dev_setup();
> >
> >  	rc = fcoe_if_init();
> > +	mutex_unlock(&fcoe_config_mutex);
> > +
> >  	if (rc)
> > -		goto out_free;
> > +		goto out_destroy;
> >
> > -	mutex_unlock(&fcoe_config_mutex);
> >  	return 0;
> >
> if you do that, why not
> if (!rc) return 0;

I agree with Dan.  If's should be for failures.

julia

>
> re,
>  wh
>
>
>
> > -out_free:
> > -	mutex_unlock(&fcoe_config_mutex);
> >  out_destroy:
> >  	destroy_workqueue(fcoe_wq);
> >  	return rc;
> > --
> > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-02 16:07     ` Julia Lawall
  0 siblings, 0 replies; 15+ messages in thread
From: Julia Lawall @ 2017-06-02 16:07 UTC (permalink / raw)
  To: walter harms
  Cc: mgandhi, Johannes Thumshirn, Dan Carpenter, Laurence Oberman,
	linux-scsi, kernel-janitors



On Fri, 2 Jun 2017, walter harms wrote:

>
>
> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> > Simplify the check for return code of fcoe_if_init routine
> > in fcoe_init function such that we could eliminate need for
> > extra 'out_free' label and duplicate mutex_unlock statement.
> >
> > Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> > ---
> >  drivers/scsi/fcoe/fcoe.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> > index ea21e7b..a2cf3d0 100644
> > --- a/drivers/scsi/fcoe/fcoe.c
> > +++ b/drivers/scsi/fcoe/fcoe.c
> > @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
> >  	fcoe_dev_setup();
> >
> >  	rc = fcoe_if_init();
> > +	mutex_unlock(&fcoe_config_mutex);
> > +
> >  	if (rc)
> > -		goto out_free;
> > +		goto out_destroy;
> >
> > -	mutex_unlock(&fcoe_config_mutex);
> >  	return 0;
> >
> if you do that, why not
> if (!rc) return 0;

I agree with Dan.  If's should be for failures.

julia

>
> re,
>  wh
>
>
>
> > -out_free:
> > -	mutex_unlock(&fcoe_config_mutex);
> >  out_destroy:
> >  	destroy_workqueue(fcoe_wq);
> >  	return rc;
> > --
> > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 12:51 ` Milan P. Gandhi
                   ` (2 preceding siblings ...)
  (?)
@ 2017-06-02 16:20 ` walter harms
  -1 siblings, 0 replies; 15+ messages in thread
From: walter harms @ 2017-06-02 16:20 UTC (permalink / raw)
  To: kernel-janitors



Am 02.06.2017 18:07, schrieb Julia Lawall:
> 
> 
> On Fri, 2 Jun 2017, walter harms wrote:
> 
>>
>>
>> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
>>> Simplify the check for return code of fcoe_if_init routine
>>> in fcoe_init function such that we could eliminate need for
>>> extra 'out_free' label and duplicate mutex_unlock statement.
>>>
>>> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
>>> ---
>>>  drivers/scsi/fcoe/fcoe.c | 7 +++----
>>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
>>> index ea21e7b..a2cf3d0 100644
>>> --- a/drivers/scsi/fcoe/fcoe.c
>>> +++ b/drivers/scsi/fcoe/fcoe.c
>>> @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
>>>  	fcoe_dev_setup();
>>>
>>>  	rc = fcoe_if_init();
>>> +	mutex_unlock(&fcoe_config_mutex);
>>> +
>>>  	if (rc)
>>> -		goto out_free;
>>> +		goto out_destroy;
>>>
>>> -	mutex_unlock(&fcoe_config_mutex);
>>>  	return 0;
>>>
>> if you do that, why not
>> if (!rc) return 0;
> 
> I agree with Dan.  If's should be for failures.
> 

yep, but it "feels" also wrong to skip of a simple return.
I do not see a good solution.

re,
 wh

> julia
> 
>>
>> re,
>>  wh
>>
>>
>>
>>> -out_free:
>>> -	mutex_unlock(&fcoe_config_mutex);
>>>  out_destroy:
>>>  	destroy_workqueue(fcoe_wq);
>>>  	return rc;
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 12:51 ` Milan P. Gandhi
@ 2017-06-03  2:34   ` Dan Carpenter
  -1 siblings, 0 replies; 15+ messages in thread
From: Dan Carpenter @ 2017-06-03  2:34 UTC (permalink / raw)
  To: Milan P. Gandhi
  Cc: Johannes Thumshirn, Julia Lawall, Laurence Oberman, linux-scsi,
	kernel-janitors

I'm fine with this version...

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-03  2:34   ` Dan Carpenter
  0 siblings, 0 replies; 15+ messages in thread
From: Dan Carpenter @ 2017-06-03  2:34 UTC (permalink / raw)
  To: Milan P. Gandhi
  Cc: Johannes Thumshirn, Julia Lawall, Laurence Oberman, linux-scsi,
	kernel-janitors

I'm fine with this version...

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-02 13:01   ` walter harms
@ 2017-06-03  2:35     ` Dan Carpenter
  -1 siblings, 0 replies; 15+ messages in thread
From: Dan Carpenter @ 2017-06-03  2:35 UTC (permalink / raw)
  To: walter harms
  Cc: mgandhi, Johannes Thumshirn, Julia Lawall, Laurence Oberman,
	linux-scsi, kernel-janitors

On Fri, Jun 02, 2017 at 03:01:29PM +0200, walter harms wrote:
> 
> 
> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> > Simplify the check for return code of fcoe_if_init routine
> > in fcoe_init function such that we could eliminate need for
> > extra 'out_free' label and duplicate mutex_unlock statement.
> > 
> > Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> > ---
> >  drivers/scsi/fcoe/fcoe.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> > index ea21e7b..a2cf3d0 100644
> > --- a/drivers/scsi/fcoe/fcoe.c
> > +++ b/drivers/scsi/fcoe/fcoe.c
> > @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
> >  	fcoe_dev_setup();
> >  
> >  	rc = fcoe_if_init();
> > +	mutex_unlock(&fcoe_config_mutex);
> > +
> >  	if (rc)
> > -		goto out_free;
> > +		goto out_destroy;
> >  
> > -	mutex_unlock(&fcoe_config_mutex);
> >  	return 0;
> >  
> if you do that, why not
> if (!rc) return 0;

Gar...  No.  Please don't get creative with the last if statement.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-03  2:35     ` Dan Carpenter
  0 siblings, 0 replies; 15+ messages in thread
From: Dan Carpenter @ 2017-06-03  2:35 UTC (permalink / raw)
  To: walter harms
  Cc: mgandhi, Johannes Thumshirn, Julia Lawall, Laurence Oberman,
	linux-scsi, kernel-janitors

On Fri, Jun 02, 2017 at 03:01:29PM +0200, walter harms wrote:
> 
> 
> Am 02.06.2017 14:39, schrieb Milan P. Gandhi:
> > Simplify the check for return code of fcoe_if_init routine
> > in fcoe_init function such that we could eliminate need for
> > extra 'out_free' label and duplicate mutex_unlock statement.
> > 
> > Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> > ---
> >  drivers/scsi/fcoe/fcoe.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> > index ea21e7b..a2cf3d0 100644
> > --- a/drivers/scsi/fcoe/fcoe.c
> > +++ b/drivers/scsi/fcoe/fcoe.c
> > @@ -2523,14 +2523,13 @@ static int __init fcoe_init(void)
> >  	fcoe_dev_setup();
> >  
> >  	rc = fcoe_if_init();
> > +	mutex_unlock(&fcoe_config_mutex);
> > +
> >  	if (rc)
> > -		goto out_free;
> > +		goto out_destroy;
> >  
> > -	mutex_unlock(&fcoe_config_mutex);
> >  	return 0;
> >  
> if you do that, why not
> if (!rc) return 0;

Gar...  No.  Please don't get creative with the last if statement.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
  2017-06-03  2:34   ` Dan Carpenter
@ 2017-06-05  4:24     ` Milan P. Gandhi
  -1 siblings, 0 replies; 15+ messages in thread
From: Milan P. Gandhi @ 2017-06-05  4:12 UTC (permalink / raw)
  To: Dan Carpenter, Johannes Thumshirn, Julia Lawall,
	Laurence Oberman, wharms
  Cc: linux-scsi, kernel-janitors

On 06/03/2017 08:04 AM, Dan Carpenter wrote:
> I'm fine with this version...
> 
> regards,
> dan carpenter
> 
Thanks everyone for the review and suggestions!!

Regards,

Milan.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function
@ 2017-06-05  4:24     ` Milan P. Gandhi
  0 siblings, 0 replies; 15+ messages in thread
From: Milan P. Gandhi @ 2017-06-05  4:24 UTC (permalink / raw)
  To: Dan Carpenter, Johannes Thumshirn, Julia Lawall,
	Laurence Oberman, wharms
  Cc: linux-scsi, kernel-janitors

On 06/03/2017 08:04 AM, Dan Carpenter wrote:
> I'm fine with this version...
> 
> regards,
> dan carpenter
> 
Thanks everyone for the review and suggestions!!

Regards,

Milan.

^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-06-05  4:24 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 12:39 [PATCH RESEND] Eliminate extra 'out_free' label from fcoe_init function Milan P. Gandhi
2017-06-02 12:51 ` Milan P. Gandhi
2017-06-02 13:01 ` walter harms
2017-06-02 13:01   ` walter harms
2017-06-02 16:07   ` Julia Lawall
2017-06-02 16:07     ` Julia Lawall
2017-06-03  2:35   ` Dan Carpenter
2017-06-03  2:35     ` Dan Carpenter
2017-06-02 16:06 ` Julia Lawall
2017-06-02 16:06   ` Julia Lawall
2017-06-02 16:20 ` walter harms
2017-06-03  2:34 ` Dan Carpenter
2017-06-03  2:34   ` Dan Carpenter
2017-06-05  4:12   ` Milan P. Gandhi
2017-06-05  4:24     ` Milan P. Gandhi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.