From: Harry Wentland <harry.wentland@amd.com> To: "Wan Jiabing" <wanjiabing@vivo.com>, "Leo Li" <sunpeng.li@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Solomon Chiu" <solomon.chiu@amd.com>, "Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>, "Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>, "Anson Jacob" <Anson.Jacob@amd.com>, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net Subject: Re: [PATCH] drm/display: Fix duplicated argument Date: Fri, 18 Jun 2021 09:55:59 -0400 [thread overview] Message-ID: <0c0c719e-d8fe-b548-80cd-c498642a6c3c@amd.com> (raw) In-Reply-To: <20210616144027.27225-1-wanjiabing@vivo.com> On 2021-06-16 10:40 a.m., Wan Jiabing wrote: > Fix coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: > 55:12-42: duplicated argument to && or || > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > index cb15525ddb49..dc8b3afef301 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > @@ -52,7 +52,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( > *BytePerPixelDETC = 0; > *BytePerPixelY = 4; > *BytePerPixelC = 0; > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { > + } else if (SourcePixelFormat == dm_444_16) { > *BytePerPixelDETY = 2; > *BytePerPixelDETC = 0; > *BytePerPixelY = 2; >
WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <harry.wentland@amd.com> To: "Wan Jiabing" <wanjiabing@vivo.com>, "Leo Li" <sunpeng.li@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Solomon Chiu" <solomon.chiu@amd.com>, "Dmytro Laktyushkin" <Dmytro.Laktyushkin@amd.com>, "Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>, "Anson Jacob" <Anson.Jacob@amd.com>, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net Subject: Re: [PATCH] drm/display: Fix duplicated argument Date: Fri, 18 Jun 2021 09:55:59 -0400 [thread overview] Message-ID: <0c0c719e-d8fe-b548-80cd-c498642a6c3c@amd.com> (raw) In-Reply-To: <20210616144027.27225-1-wanjiabing@vivo.com> On 2021-06-16 10:40 a.m., Wan Jiabing wrote: > Fix coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: > 55:12-42: duplicated argument to && or || > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > .../gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > index cb15525ddb49..dc8b3afef301 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c > @@ -52,7 +52,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes( > *BytePerPixelDETC = 0; > *BytePerPixelY = 4; > *BytePerPixelC = 0; > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == dm_444_16) { > + } else if (SourcePixelFormat == dm_444_16) { > *BytePerPixelDETY = 2; > *BytePerPixelDETC = 0; > *BytePerPixelY = 2; > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-06-18 13:56 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 14:40 [PATCH] drm/display: Fix duplicated argument Wan Jiabing 2021-06-16 14:40 ` Wan Jiabing 2021-06-18 13:55 ` Harry Wentland [this message] 2021-06-18 13:55 ` Harry Wentland 2021-06-18 20:38 ` Alex Deucher 2021-06-18 20:38 ` Alex Deucher 2021-06-18 20:38 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0c0c719e-d8fe-b548-80cd-c498642a6c3c@amd.com \ --to=harry.wentland@amd.com \ --cc=Anson.Jacob@amd.com \ --cc=Dmytro.Laktyushkin@amd.com \ --cc=Xinhui.Pan@amd.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kael_w@yeah.net \ --cc=linux-kernel@vger.kernel.org \ --cc=nicholas.kazlauskas@amd.com \ --cc=solomon.chiu@amd.com \ --cc=sunpeng.li@amd.com \ --cc=wanjiabing@vivo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.