All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keerthy <a0393675@ti.com>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: LINUX-KERNEL <linux-kernel@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH V1 01/10] mfd: da9061: MFD core support
Date: Sat, 8 Oct 2016 08:27:25 +0530	[thread overview]
Message-ID: <0c189115-dff4-bf50-dd37-ac9ee690dd5a@ti.com> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2712@SW-EX-MBX02.diasemi.com>



On Friday 07 October 2016 08:02 PM, Steve Twiss wrote:
> Hi,
>
> On 06 October 2016 17:34, Steve Twiss wrote:
>> On 06 October 2016 11:38, Keerthy [mailto:a0393675@ti.com], wrote:
>>> +	int cell_num;
>>> No need of cell_num.
>>
>>> +		cell_num = ARRAY_SIZE(da9061_devs);
>>> No need of the above assignment
>>
>>> +		cell_num = ARRAY_SIZE(da9062_devs);
>>> No need of the above assignment
>>>
>>> +	ret = mfd_add_devices(chip->dev, PLATFORM_DEVID_NONE, cell,
>>> +			      cell_num, NULL, irq_base,
>>> Use ARRAY_SIZE(cell) instead if cell_num
>>
>> Okay. Can do that.
>
> Okay. I cannot do that.
> Dropped that change.
>
> drivers/mfd/da9062-core.c: In function 'da9062_i2c_probe':
> ./include/linux/bug.h:34:45: error: negative width in bit-field '<anonymous>'
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
>                                              ^
> ./include/linux/compiler-gcc.h:64:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
>                             ^
> ./include/linux/kernel.h:53:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
>                                                            ^
> drivers/mfd/da9062-core.c:919:10: note: in expansion of macro 'ARRAY_SIZE'
>           ARRAY_SIZE(cell), NULL, irq_base,
>           ^

Okay. yes i got it.

>

  reply	other threads:[~2016-10-08  2:57 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  8:43 [PATCH V1 00/10] da9061: DA9061 driver submission Steve Twiss
2016-10-06  8:43 ` [PATCH V1 01/10] mfd: da9061: MFD core support Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06 10:37   ` Keerthy
2016-10-06 10:37     ` Keerthy
2016-10-06 16:34     ` Steve Twiss
2016-10-06 16:34       ` Steve Twiss
2016-10-07 14:32     ` Steve Twiss
2016-10-08  2:57       ` Keerthy [this message]
2016-10-06  8:43 ` [PATCH V1 02/10] regulator: da9061: BUCK and LDO regulator driver Steve Twiss
2016-10-06  8:43 ` [PATCH V1 03/10] Input: da9061: onkey driver Steve Twiss
2016-10-06  8:43 ` [PATCH V1 04/10] watchdog: da9061: watchdog driver Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06 13:28   ` Guenter Roeck
2016-10-06 13:28     ` Guenter Roeck
2016-10-06  8:43 ` [PATCH V1 05/10] thermal: da9062/61: Thermal junction temperature monitoring driver Steve Twiss
2016-10-07  5:28   ` Keerthy
2016-10-07  5:28     ` Keerthy
2016-10-07 17:48     ` Steve Twiss
2016-10-14 13:07       ` Steve Twiss
2016-10-14 13:07         ` Steve Twiss
2016-10-20 13:02     ` Steve Twiss
2016-10-20 13:02       ` Steve Twiss
2016-10-20 14:21     ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 06/10] Documentation: dt: input: temperature driver Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-10 13:37   ` Rob Herring
2016-10-11 11:43     ` Steve Twiss
2016-10-11 11:43       ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 10/10] MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 07/10] Documentation: dt: watchdog: da9062/61 Watchdog timer binding Steve Twiss
2016-10-10 13:39   ` Rob Herring
2016-10-06  8:43 ` [PATCH V1 09/10] Documentation: dt: mfd: da9062/61 MFD binding Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-10 13:42   ` Rob Herring
2016-10-14 12:26     ` Steve Twiss
2016-10-14 12:26       ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 08/10] Documentation: dt: thermal: da9062/61 TJUNC temperature binding Steve Twiss
2016-10-10 13:38   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c189115-dff4-bf50-dd37-ac9ee690dd5a@ti.com \
    --to=a0393675@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.