All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Rob Herring <robh@kernel.org>
Cc: DEVICETREE <devicetree@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	LINUX-INPUT <linux-input@vger.kernel.org>,
	LINUX-KERNEL <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	LINUX-PM <linux-pm@vger.kernel.org>,
	LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"Support Opensource" <Support.Opensource@diasemi.com>,
	Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: RE: [PATCH V1 06/10] Documentation: dt: input: temperature driver
Date: Tue, 11 Oct 2016 11:43:21 +0000	[thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2CC4@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <20161010133718.GA9643@rob-hp-laptop>

Hi,

On 10 October 2016 14:37 Rob Herring wrote:
> On Thu, Oct 06, 2016 at 09:43:30AM +0100, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> The subject is wrong.

Copy/paste error -- I will fix that.

> > Add binding information for DA9061 onkey.
> >
> > This patch updates the compatible string "dlg,da9061-onkey" to support
> > DA9061, removes ther reference to KEY_SLEEP (which the driver no longer
> 
> s/ther/the/

And this.

> > supports) and fixes a typo in the example.
> 
> Why is KEY_SLEEP being removed?

Supporting KEY_SLEEP was not the general convention and the typical solution should have been
for KEY_POWER to support both cases of suspend and S/W power off.
I changed the driver, but failed to update the documentation at that time, so am now updating this
as part of the DA9061.

I will add that information in the next V2 patch e-mail.

Regards,
Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Rob Herring <robh@kernel.org>
Cc: DEVICETREE <devicetree@vger.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	LINUX-INPUT <linux-input@vger.kernel.org>,
	LINUX-KERNEL <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	LINUX-PM <linux-pm@vger.kernel.org>,
	LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	"Support Opensource" <Support.Opensource@diasemi.com>,
	Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: RE: [PATCH V1 06/10] Documentation: dt: input: temperature driver
Date: Tue, 11 Oct 2016 11:43:21 +0000	[thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2CC4@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <20161010133718.GA9643@rob-hp-laptop>

Hi,

On 10 October 2016 14:37 Rob Herring wrote:
> On Thu, Oct 06, 2016 at 09:43:30AM +0100, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> The subject is wrong.

Copy/paste error -- I will fix that.

> > Add binding information for DA9061 onkey.
> >
> > This patch updates the compatible string "dlg,da9061-onkey" to support
> > DA9061, removes ther reference to KEY_SLEEP (which the driver no longer
> 
> s/ther/the/

And this.

> > supports) and fixes a typo in the example.
> 
> Why is KEY_SLEEP being removed?

Supporting KEY_SLEEP was not the general convention and the typical solution should have been
for KEY_POWER to support both cases of suspend and S/W power off.
I changed the driver, but failed to update the documentation at that time, so am now updating this
as part of the DA9061.

I will add that information in the next V2 patch e-mail.

Regards,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-10-11 11:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  8:43 [PATCH V1 00/10] da9061: DA9061 driver submission Steve Twiss
2016-10-06  8:43 ` [PATCH V1 01/10] mfd: da9061: MFD core support Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06 10:37   ` Keerthy
2016-10-06 10:37     ` Keerthy
2016-10-06 16:34     ` Steve Twiss
2016-10-06 16:34       ` Steve Twiss
2016-10-07 14:32     ` Steve Twiss
2016-10-08  2:57       ` Keerthy
2016-10-06  8:43 ` [PATCH V1 02/10] regulator: da9061: BUCK and LDO regulator driver Steve Twiss
2016-10-06  8:43 ` [PATCH V1 03/10] Input: da9061: onkey driver Steve Twiss
2016-10-06  8:43 ` [PATCH V1 04/10] watchdog: da9061: watchdog driver Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06 13:28   ` Guenter Roeck
2016-10-06 13:28     ` Guenter Roeck
2016-10-06  8:43 ` [PATCH V1 05/10] thermal: da9062/61: Thermal junction temperature monitoring driver Steve Twiss
2016-10-07  5:28   ` Keerthy
2016-10-07  5:28     ` Keerthy
2016-10-07 17:48     ` Steve Twiss
2016-10-14 13:07       ` Steve Twiss
2016-10-14 13:07         ` Steve Twiss
2016-10-20 13:02     ` Steve Twiss
2016-10-20 13:02       ` Steve Twiss
2016-10-20 14:21     ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 06/10] Documentation: dt: input: temperature driver Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-10 13:37   ` Rob Herring
2016-10-11 11:43     ` Steve Twiss [this message]
2016-10-11 11:43       ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 10/10] MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 07/10] Documentation: dt: watchdog: da9062/61 Watchdog timer binding Steve Twiss
2016-10-10 13:39   ` Rob Herring
2016-10-06  8:43 ` [PATCH V1 09/10] Documentation: dt: mfd: da9062/61 MFD binding Steve Twiss
2016-10-06  8:43   ` Steve Twiss
2016-10-10 13:42   ` Rob Herring
2016-10-14 12:26     ` Steve Twiss
2016-10-14 12:26       ` Steve Twiss
2016-10-06  8:43 ` [PATCH V1 08/10] Documentation: dt: thermal: da9062/61 TJUNC temperature binding Steve Twiss
2016-10-10 13:38   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ED8E3B22081A4459DAC7699F3695FB7018CCE2CC4@SW-EX-MBX02.diasemi.com \
    --to=stwiss.opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.