All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: Bart Van Assche <bvanassche@acm.org>,
	kernel test robot <oliver.sang@intel.com>
Cc: 0day robot <lkp@intel.com>, John Garry <john.garry@huawei.com>,
	Hannes Reinecke <hare@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [LKP] Re: 2463a604a8: netperf.Throughput_tps 12.8% improvement
Date: Wed, 26 May 2021 09:50:05 +0800	[thread overview]
Message-ID: <0c2d909a-d307-548b-473c-0c85d479573e@linux.intel.com> (raw)
In-Reply-To: <f572997b-8979-26bb-cb3b-9926086c4cc7@acm.org>



On 5/26/2021 12:44 AM, Bart Van Assche wrote:
> On 5/24/21 11:44 PM, kernel test robot wrote:
>> FYI, we noticed a 12.8% improvement of netperf.Throughput_tps due to commit:
>>
>> commit: 2463a604a86728777ce4284214a52de46a808c9e ("[PATCH v3 2/3] Introduce enums for the SAM, message, host and driver status codes")
>> url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Introduce-enums-for-SCSI-status-codes/20210524-105751
>> base: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git for-next
>>
>> in testcase: netperf
>> on test machine: 192 threads 4 sockets Intel(R) Xeon(R) Platinum 9242 CPU @ 2.30GHz with 192G memory
>> with following parameters:
>>
>> 	ip: ipv4
>> 	runtime: 300s
>> 	nr_threads: 16
>> 	cluster: cs-localhost
>> 	test: TCP_CRR
>> 	cpufreq_governor: performance
>> 	ucode: 0x5003006
>>
>> test-description: Netperf is a benchmark that can be use to measure various aspect of networking performance.
>> test-url: http://www.netperf.org/netperf/
> The above email reports a performance improvement for the networking
> subsystem while my patch only affects the SCSI subsystem and should not
> have any performance impact. I'm confused by the above feedback ...

I suspect it related with cache alignment, 2463a604a8 changes "u8" 
(size:1) to "enum xxx_status" (size: 4),  the cache alignment is better 
than before , so cause the improvement.
>
> Bart.
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org

-- 
Zhengjun Xing


WARNING: multiple messages have this Message-ID (diff)
From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: lkp@lists.01.org
Subject: Re: 2463a604a8: netperf.Throughput_tps 12.8% improvement
Date: Wed, 26 May 2021 09:50:05 +0800	[thread overview]
Message-ID: <0c2d909a-d307-548b-473c-0c85d479573e@linux.intel.com> (raw)
In-Reply-To: <f572997b-8979-26bb-cb3b-9926086c4cc7@acm.org>

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]



On 5/26/2021 12:44 AM, Bart Van Assche wrote:
> On 5/24/21 11:44 PM, kernel test robot wrote:
>> FYI, we noticed a 12.8% improvement of netperf.Throughput_tps due to commit:
>>
>> commit: 2463a604a86728777ce4284214a52de46a808c9e ("[PATCH v3 2/3] Introduce enums for the SAM, message, host and driver status codes")
>> url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Introduce-enums-for-SCSI-status-codes/20210524-105751
>> base: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git for-next
>>
>> in testcase: netperf
>> on test machine: 192 threads 4 sockets Intel(R) Xeon(R) Platinum 9242 CPU @ 2.30GHz with 192G memory
>> with following parameters:
>>
>> 	ip: ipv4
>> 	runtime: 300s
>> 	nr_threads: 16
>> 	cluster: cs-localhost
>> 	test: TCP_CRR
>> 	cpufreq_governor: performance
>> 	ucode: 0x5003006
>>
>> test-description: Netperf is a benchmark that can be use to measure various aspect of networking performance.
>> test-url: http://www.netperf.org/netperf/
> The above email reports a performance improvement for the networking
> subsystem while my patch only affects the SCSI subsystem and should not
> have any performance impact. I'm confused by the above feedback ...

I suspect it related with cache alignment, 2463a604a8 changes "u8" 
(size:1) to "enum xxx_status" (size: 4),  the cache alignment is better 
than before , so cause the improvement.
>
> Bart.
> _______________________________________________
> LKP mailing list -- lkp(a)lists.01.org
> To unsubscribe send an email to lkp-leave(a)lists.01.org

-- 
Zhengjun Xing

  reply	other threads:[~2021-05-26  1:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  2:54 [PATCH v3 0/3] Introduce enums for SCSI status codes Bart Van Assche
2021-05-24  2:54 ` [PATCH v3 1/3] libsas: Introduce more SAM status code aliases in enum exec_status Bart Van Assche
2021-05-24 15:25   ` Himanshu Madhani
2021-05-24  2:54 ` [PATCH v3 2/3] Introduce enums for the SAM, message, host and driver status codes Bart Van Assche
2021-05-24 15:25   ` Himanshu Madhani
2021-05-25  6:44   ` 2463a604a8: netperf.Throughput_tps 12.8% improvement kernel test robot
2021-05-25  6:44     ` kernel test robot
2021-05-25 16:44     ` Bart Van Assche
2021-05-25 16:44       ` Bart Van Assche
2021-05-26  1:50       ` Xing Zhengjun [this message]
2021-05-26  1:50         ` Xing Zhengjun
2021-05-24  2:54 ` [PATCH v3 3/3] Change the type of the second argument of scsi_host_complete_all_commands() Bart Van Assche
2021-05-24 15:25   ` Himanshu Madhani
2021-06-08  2:27 ` [PATCH v3 0/3] Introduce enums for SCSI status codes Martin K. Petersen
2021-06-16  3:48 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c2d909a-d307-548b-473c-0c85d479573e@linux.intel.com \
    --to=zhengjun.xing@linux.intel.com \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=martin.petersen@oracle.com \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.