* [PATCH V1] leds: pca955x: Add ACPI support for pca955x
@ 2016-11-23 8:42 ` tnhuynh
2016-11-23 10:19 ` Jacek Anaszewski
[not found] ` <CGME20161123084629epcas1p23e8a52957cac1d4ea5694a550cd6971d@epcas1p2.samsung.com>
0 siblings, 2 replies; 4+ messages in thread
From: tnhuynh @ 2016-11-23 8:42 UTC (permalink / raw)
To: Richard Purdie, Jacek Anaszewski, linux-leds, linux-kernel
Cc: Loc Ho, Thang Nguyen, Phong Vo, patches, Tin Huynh
From: Tin Huynh <tnhuynh@apm.com>
This patch enables ACPI support for leds-pca955x driver.
Signed-off-by: Tin Huynh <tnhuynh@apm.com>
---
drivers/leds/leds-pca955x.c | 26 +++++++++++++++++++++++++-
1 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
index 840401a..8770090 100644
--- a/drivers/leds/leds-pca955x.c
+++ b/drivers/leds/leds-pca955x.c
@@ -40,6 +40,7 @@
* bits the chip supports.
*/
+#include <linux/acpi.h>
#include <linux/module.h>
#include <linux/delay.h>
#include <linux/string.h>
@@ -100,6 +101,17 @@ struct pca955x_chipdef {
};
MODULE_DEVICE_TABLE(i2c, pca955x_id);
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id pca955x_acpi_ids[] = {
+ { .id = "PCA9550", .driver_data = pca9550 },
+ { .id = "PCA9551", .driver_data = pca9551 },
+ { .id = "PCA9552", .driver_data = pca9552 },
+ { .id = "PCA9553", .driver_data = pca9553 },
+ { }
+};
+MODULE_DEVICE_TABLE(acpi, pca955x_acpi_ids);
+#endif
+
struct pca955x {
struct mutex lock;
struct pca955x_led *leds;
@@ -250,7 +262,18 @@ static int pca955x_probe(struct i2c_client *client,
struct led_platform_data *pdata;
int i, err;
- chip = &pca955x_chipdefs[id->driver_data];
+ if (id)
+ chip = &pca955x_chipdefs[id->driver_data];
+#ifdef CONFIG_ACPI
+ else {
+ const struct acpi_device_id *acpi_id;
+
+ acpi_id = acpi_match_device(pca955x_acpi_ids, &client->dev);
+ if (!acpi_id)
+ return -ENODEV;
+ chip = &pca955x_chipdefs[acpi_id->driver_data];
+ }
+#endif
adapter = to_i2c_adapter(client->dev.parent);
pdata = dev_get_platdata(&client->dev);
@@ -358,6 +381,7 @@ static int pca955x_remove(struct i2c_client *client)
static struct i2c_driver pca955x_driver = {
.driver = {
.name = "leds-pca955x",
+ .acpi_match_table = ACPI_PTR(pca955x_acpi_ids),
},
.probe = pca955x_probe,
.remove = pca955x_remove,
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V1] leds: pca955x: Add ACPI support for pca955x
2016-11-23 8:42 ` [PATCH V1] leds: pca955x: Add ACPI support for pca955x tnhuynh
@ 2016-11-23 10:19 ` Jacek Anaszewski
2016-11-23 10:22 ` Mika Westerberg
[not found] ` <CGME20161123084629epcas1p23e8a52957cac1d4ea5694a550cd6971d@epcas1p2.samsung.com>
1 sibling, 1 reply; 4+ messages in thread
From: Jacek Anaszewski @ 2016-11-23 10:19 UTC (permalink / raw)
To: tnhuynh, Richard Purdie, linux-leds, linux-kernel
Cc: Loc Ho, Thang Nguyen, Phong Vo, patches, Rafael J. Wysocki,
Mika Westerberg
Hi Tin,
Thanks for the patch. While adding ACPI support please
always add ACPI maintainers on CC.
Adding Rafael and Mika.
Thanks,
Jacek Anaszewski
On 11/23/2016 09:42 AM, tnhuynh@apm.com wrote:
> From: Tin Huynh <tnhuynh@apm.com>
>
> This patch enables ACPI support for leds-pca955x driver.
>
> Signed-off-by: Tin Huynh <tnhuynh@apm.com>
> ---
> drivers/leds/leds-pca955x.c | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index 840401a..8770090 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -40,6 +40,7 @@
> * bits the chip supports.
> */
>
> +#include <linux/acpi.h>
> #include <linux/module.h>
> #include <linux/delay.h>
> #include <linux/string.h>
> @@ -100,6 +101,17 @@ struct pca955x_chipdef {
> };
> MODULE_DEVICE_TABLE(i2c, pca955x_id);
>
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id pca955x_acpi_ids[] = {
> + { .id = "PCA9550", .driver_data = pca9550 },
> + { .id = "PCA9551", .driver_data = pca9551 },
> + { .id = "PCA9552", .driver_data = pca9552 },
> + { .id = "PCA9553", .driver_data = pca9553 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, pca955x_acpi_ids);
> +#endif
> +
> struct pca955x {
> struct mutex lock;
> struct pca955x_led *leds;
> @@ -250,7 +262,18 @@ static int pca955x_probe(struct i2c_client *client,
> struct led_platform_data *pdata;
> int i, err;
>
> - chip = &pca955x_chipdefs[id->driver_data];
> + if (id)
> + chip = &pca955x_chipdefs[id->driver_data];
> +#ifdef CONFIG_ACPI
> + else {
> + const struct acpi_device_id *acpi_id;
> +
> + acpi_id = acpi_match_device(pca955x_acpi_ids, &client->dev);
> + if (!acpi_id)
> + return -ENODEV;
> + chip = &pca955x_chipdefs[acpi_id->driver_data];
> + }
> +#endif
> adapter = to_i2c_adapter(client->dev.parent);
> pdata = dev_get_platdata(&client->dev);
>
> @@ -358,6 +381,7 @@ static int pca955x_remove(struct i2c_client *client)
> static struct i2c_driver pca955x_driver = {
> .driver = {
> .name = "leds-pca955x",
> + .acpi_match_table = ACPI_PTR(pca955x_acpi_ids),
> },
> .probe = pca955x_probe,
> .remove = pca955x_remove,
>
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] leds: pca955x: Add ACPI support for pca955x
[not found] ` <CAKrQpSvFgWAE8RFDbqXRhuSCRXZY3cvE4AdLi-wPe-LGPLSPLQ@mail.gmail.com>
@ 2016-11-23 10:20 ` Jacek Anaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Jacek Anaszewski @ 2016-11-23 10:20 UTC (permalink / raw)
To: Thang Q. Nguyen, Tin Huynh
Cc: Richard Purdie, linux-leds, linux-kernel, Loc Ho, Phong Vo, patches
Hi Thang,
It is customary to ack the patches using following tag:
Acked-by: Your Name <your_email>
Thanks,
Jacek Anaszewski
On 11/23/2016 09:44 AM, Thang Q. Nguyen wrote:
> Acked.
>
> On Wed, Nov 23, 2016 at 3:42 PM, <tnhuynh@apm.com
> <mailto:tnhuynh@apm.com>> wrote:
>
> From: Tin Huynh <tnhuynh@apm.com <mailto:tnhuynh@apm.com>>
>
> This patch enables ACPI support for leds-pca955x driver.
>
> Signed-off-by: Tin Huynh <tnhuynh@apm.com <mailto:tnhuynh@apm.com>>
> ---
> drivers/leds/leds-pca955x.c | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index 840401a..8770090 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -40,6 +40,7 @@
> * bits the chip supports.
> */
>
> +#include <linux/acpi.h>
> #include <linux/module.h>
> #include <linux/delay.h>
> #include <linux/string.h>
> @@ -100,6 +101,17 @@ struct pca955x_chipdef {
> };
> MODULE_DEVICE_TABLE(i2c, pca955x_id);
>
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id pca955x_acpi_ids[] = {
> + { .id = "PCA9550", .driver_data = pca9550 },
> + { .id = "PCA9551", .driver_data = pca9551 },
> + { .id = "PCA9552", .driver_data = pca9552 },
> + { .id = "PCA9553", .driver_data = pca9553 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, pca955x_acpi_ids);
> +#endif
> +
> struct pca955x {
> struct mutex lock;
> struct pca955x_led *leds;
> @@ -250,7 +262,18 @@ static int pca955x_probe(struct i2c_client *client,
> struct led_platform_data *pdata;
> int i, err;
>
> - chip = &pca955x_chipdefs[id->driver_data];
> + if (id)
> + chip = &pca955x_chipdefs[id->driver_data];
> +#ifdef CONFIG_ACPI
> + else {
> + const struct acpi_device_id *acpi_id;
> +
> + acpi_id = acpi_match_device(pca955x_acpi_ids,
> &client->dev);
> + if (!acpi_id)
> + return -ENODEV;
> + chip = &pca955x_chipdefs[acpi_id->driver_data];
> + }
> +#endif
> adapter = to_i2c_adapter(client->dev.parent);
> pdata = dev_get_platdata(&client->dev);
>
> @@ -358,6 +381,7 @@ static int pca955x_remove(struct i2c_client *client)
> static struct i2c_driver pca955x_driver = {
> .driver = {
> .name = "leds-pca955x",
> + .acpi_match_table = ACPI_PTR(pca955x_acpi_ids),
> },
> .probe = pca955x_probe,
> .remove = pca955x_remove,
> --
> 1.7.1
>
>
>
>
> --
>
>
>
> *Thang Q. Nguyen **|**Staff SW Eng.*
>
> C: +849.7684.7606 |O: +848.3770.0640
>
> F: +848.3770.0641 |tqnguyen@apm.com <mailto:tqnguyen@apm.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] leds: pca955x: Add ACPI support for pca955x
2016-11-23 10:19 ` Jacek Anaszewski
@ 2016-11-23 10:22 ` Mika Westerberg
0 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2016-11-23 10:22 UTC (permalink / raw)
To: Jacek Anaszewski
Cc: tnhuynh, Richard Purdie, linux-leds, linux-kernel, Loc Ho,
Thang Nguyen, Phong Vo, patches, Rafael J. Wysocki
On Wed, Nov 23, 2016 at 11:19:21AM +0100, Jacek Anaszewski wrote:
> Hi Tin,
>
> Thanks for the patch. While adding ACPI support please
> always add ACPI maintainers on CC.
>
> Adding Rafael and Mika.
>
> Thanks,
> Jacek Anaszewski
>
> On 11/23/2016 09:42 AM, tnhuynh@apm.com wrote:
> > From: Tin Huynh <tnhuynh@apm.com>
> >
> > This patch enables ACPI support for leds-pca955x driver.
> >
> > Signed-off-by: Tin Huynh <tnhuynh@apm.com>
> > ---
> > drivers/leds/leds-pca955x.c | 26 +++++++++++++++++++++++++-
> > 1 files changed, 25 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> > index 840401a..8770090 100644
> > --- a/drivers/leds/leds-pca955x.c
> > +++ b/drivers/leds/leds-pca955x.c
> > @@ -40,6 +40,7 @@
> > * bits the chip supports.
> > */
> >
> > +#include <linux/acpi.h>
> > #include <linux/module.h>
> > #include <linux/delay.h>
> > #include <linux/string.h>
> > @@ -100,6 +101,17 @@ struct pca955x_chipdef {
> > };
> > MODULE_DEVICE_TABLE(i2c, pca955x_id);
> >
> > +#ifdef CONFIG_ACPI
> > +static const struct acpi_device_id pca955x_acpi_ids[] = {
> > + { .id = "PCA9550", .driver_data = pca9550 },
> > + { .id = "PCA9551", .driver_data = pca9551 },
> > + { .id = "PCA9552", .driver_data = pca9552 },
> > + { .id = "PCA9553", .driver_data = pca9553 },
Some like to write this
{ "PCA9553", pca9553 },
instead but both work.
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, pca955x_acpi_ids);
> > +#endif
> > +
> > struct pca955x {
> > struct mutex lock;
> > struct pca955x_led *leds;
> > @@ -250,7 +262,18 @@ static int pca955x_probe(struct i2c_client *client,
> > struct led_platform_data *pdata;
> > int i, err;
> >
> > - chip = &pca955x_chipdefs[id->driver_data];
> > + if (id)
> > + chip = &pca955x_chipdefs[id->driver_data];
> > +#ifdef CONFIG_ACPI
You should not need these #ifdefs as acpi_match_device() should be
stubbed out when !CONFIG_ACPI.
Otherwise look good to me.
> > + else {
> > + const struct acpi_device_id *acpi_id;
> > +
> > + acpi_id = acpi_match_device(pca955x_acpi_ids, &client->dev);
> > + if (!acpi_id)
> > + return -ENODEV;
> > + chip = &pca955x_chipdefs[acpi_id->driver_data];
> > + }
> > +#endif
> > adapter = to_i2c_adapter(client->dev.parent);
> > pdata = dev_get_platdata(&client->dev);
> >
> > @@ -358,6 +381,7 @@ static int pca955x_remove(struct i2c_client *client)
> > static struct i2c_driver pca955x_driver = {
> > .driver = {
> > .name = "leds-pca955x",
> > + .acpi_match_table = ACPI_PTR(pca955x_acpi_ids),
> > },
> > .probe = pca955x_probe,
> > .remove = pca955x_remove,
> >
>
>
> --
> Best regards,
> Jacek Anaszewski
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-23 10:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20161123084915epcas2p4fc418350e07d2c4746333a0da733f40a@epcas2p4.samsung.com>
2016-11-23 8:42 ` [PATCH V1] leds: pca955x: Add ACPI support for pca955x tnhuynh
2016-11-23 10:19 ` Jacek Anaszewski
2016-11-23 10:22 ` Mika Westerberg
[not found] ` <CGME20161123084629epcas1p23e8a52957cac1d4ea5694a550cd6971d@epcas1p2.samsung.com>
[not found] ` <CAKrQpSvFgWAE8RFDbqXRhuSCRXZY3cvE4AdLi-wPe-LGPLSPLQ@mail.gmail.com>
2016-11-23 10:20 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.