All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: maarten.lankhorst@linux.intel.com
Subject: Re: [Intel-gfx] [PATCH v2 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume
Date: Wed, 8 Sep 2021 09:58:39 +0200	[thread overview]
Message-ID: <0c78f895-1e71-c10d-0e90-fa09bf555c5b@linux.intel.com> (raw)
In-Reply-To: <51111df6-bf0c-ba09-4a9a-5bd59bec5fa9@intel.com>

Hi, Matt,

Thanks for reviewing.

On 9/7/21 7:37 PM, Matthew Auld wrote:
>
>> +    i915_gem_ww_unlock_single(backup);
>> +    i915_gem_object_put(backup);
>
> I assume we need to set ttm.backup = NULL somewhere here on the 
> failure path, or don't drop the ref? Or at least it looks like 
> potential uaf later?

Yes, I think on failure, we just don't drop the ref here in case 
something at some point decides to retry.

I'll fix up this and other comments.

/Thomas


>
>> +
>> +    return err;
>> +}
>> +

WARNING: multiple messages have this Message-ID (diff)
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: maarten.lankhorst@linux.intel.com
Subject: Re: [PATCH v2 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume
Date: Wed, 8 Sep 2021 09:58:39 +0200	[thread overview]
Message-ID: <0c78f895-1e71-c10d-0e90-fa09bf555c5b@linux.intel.com> (raw)
In-Reply-To: <51111df6-bf0c-ba09-4a9a-5bd59bec5fa9@intel.com>

Hi, Matt,

Thanks for reviewing.

On 9/7/21 7:37 PM, Matthew Auld wrote:
>
>> +    i915_gem_ww_unlock_single(backup);
>> +    i915_gem_object_put(backup);
>
> I assume we need to set ttm.backup = NULL somewhere here on the 
> failure path, or don't drop the ref? Or at least it looks like 
> potential uaf later?

Yes, I think on failure, we just don't drop the ref here in case 
something at some point decides to retry.

I'll fix up this and other comments.

/Thomas


>
>> +
>> +    return err;
>> +}
>> +

  reply	other threads:[~2021-09-08  7:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 16:55 [PATCH v2 0/6] drm/i915: Suspend / resume backup- and restore of LMEM Thomas Hellström
2021-09-06 16:55 ` [Intel-gfx] " Thomas Hellström
2021-09-06 16:55 ` [PATCH v2 1/6] drm/i915/ttm: Implement a function to copy the contents of two TTM-base objects Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-07  8:54   ` Matthew Auld
2021-09-07  8:54     ` [Intel-gfx] " Matthew Auld
2021-09-06 16:55 ` [PATCH v2 2/6] drm/i915/gem: Implement a function to process all gem objects of a region Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-07  9:12   ` Matthew Auld
2021-09-07  9:12     ` [Intel-gfx] " Matthew Auld
2021-09-06 16:55 ` [PATCH v2 3/6] drm/i915 Implement LMEM backup and restore for suspend / resume Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-07 17:37   ` Matthew Auld
2021-09-07 17:37     ` [Intel-gfx] " Matthew Auld
2021-09-08  7:58     ` Thomas Hellström [this message]
2021-09-08  7:58       ` Thomas Hellström
2021-09-10 13:27   ` Thomas Hellström
2021-09-10 13:27     ` [Intel-gfx] " Thomas Hellström
2021-09-06 16:55 ` [PATCH v2 4/6] drm/i915/gt: Register the migrate contexts with their engines Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-06 16:55 ` [PATCH v2 5/6] drm/i915: Don't back up pinned LMEM context images and rings during suspend Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-08 11:01   ` Matthew Auld
2021-09-08 11:01     ` [Intel-gfx] " Matthew Auld
2021-09-08 11:07   ` Matthew Auld
2021-09-08 11:07     ` [Intel-gfx] " Matthew Auld
2021-09-08 12:26     ` Thomas Hellström
2021-09-08 12:26       ` [Intel-gfx] " Thomas Hellström
2021-09-08 13:18       ` Matthew Auld
2021-09-08 13:18         ` [Intel-gfx] " Matthew Auld
2021-09-06 16:55 ` [PATCH v2 6/6] drm/i915: Reduce the number of objects subject to memcpy recover Thomas Hellström
2021-09-06 16:55   ` [Intel-gfx] " Thomas Hellström
2021-09-06 17:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Suspend / resume backup- and restore of LMEM. (rev2) Patchwork
2021-09-06 17:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-06 19:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-08 15:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Suspend / resume backup- and restore of LMEM. (rev3) Patchwork
2021-09-08 15:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-08 19:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c78f895-1e71-c10d-0e90-fa09bf555c5b@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.