All of lore.kernel.org
 help / color / mirror / Atom feed
From: okaya@codeaurora.org
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Lukas Wunner <lukas@wunner.de>,
	linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Peter Jones <pjones@redhat.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Heyi Guo <heyi.guo@linaro.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Thu, 30 Mar 2017 07:42:12 -0400	[thread overview]
Message-ID: <0c8ba1ac389560358458c10915d85526@codeaurora.org> (raw)
In-Reply-To: <CAKv+Gu-ff98HrPK3f+E8soGJUXaaMxPLs2AuJ+rvXd0HWX-jXw@mail.gmail.com>

On 2017-03-30 06:09, Ard Biesheuvel wrote:
> On 30 March 2017 at 11:05, Lorenzo Pieralisi 
> <lorenzo.pieralisi@arm.com> wrote:
>> On Thu, Mar 30, 2017 at 09:46:39AM +0100, Ard Biesheuvel wrote:
>> 
>> [...]
>> 
>>> > I'm asking why we don't fix the actual problem in PCIe ARM64 adaptation instead
>>> > of working around it by quirks.
>>> >
>>> > I don't see any reason why ACPI ARM64 should carry the burden of legacy systems.
>>> >
>>> > Legacy only applies to DT based systems.
>>> >
>>> 
>>> I fully agree with this point: ACPI implies firmware, and so we 
>>> should
>>> be able to rely on firmware to have initialized the PCIe subsystem by
>>> the time the kernel gets to access it.
>> 
>> https://lkml.org/lkml/2016/3/3/458
>> 
> 
> I don't think the fact that at least one system existed over a year
> ago whose UEFI assigned resources incorrectly should prevent us from
> being normative in this case.

My suggestion is to try to reuse the resources if possible. Otherwise, 
reassign the resources.

There were implementation problems by the time you proposed your patch 
and it was delaying progess. That was my objection.

Now that base pci support is in and everybody is  somewhat happy, let's 
figure out the bugs and get this done.

I am ready to test/debug.

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi@vger.kernel.org, Lukas Wunner <lukas@wunner.de>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	linux-pci <linux-pci@vger.kernel.org>,
	Peter Jones <pjones@redhat.com>, Heyi Guo <heyi.guo@linaro.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Hanjun Guo <hanjun.guo@linaro.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Yinghai Lu <yinghai@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Thu, 30 Mar 2017 07:42:12 -0400	[thread overview]
Message-ID: <0c8ba1ac389560358458c10915d85526@codeaurora.org> (raw)
In-Reply-To: <CAKv+Gu-ff98HrPK3f+E8soGJUXaaMxPLs2AuJ+rvXd0HWX-jXw@mail.gmail.com>

On 2017-03-30 06:09, Ard Biesheuvel wrote:
> On 30 March 2017 at 11:05, Lorenzo Pieralisi 
> <lorenzo.pieralisi@arm.com> wrote:
>> On Thu, Mar 30, 2017 at 09:46:39AM +0100, Ard Biesheuvel wrote:
>> 
>> [...]
>> 
>>> > I'm asking why we don't fix the actual problem in PCIe ARM64 adaptation instead
>>> > of working around it by quirks.
>>> >
>>> > I don't see any reason why ACPI ARM64 should carry the burden of legacy systems.
>>> >
>>> > Legacy only applies to DT based systems.
>>> >
>>> 
>>> I fully agree with this point: ACPI implies firmware, and so we 
>>> should
>>> be able to rely on firmware to have initialized the PCIe subsystem by
>>> the time the kernel gets to access it.
>> 
>> https://lkml.org/lkml/2016/3/3/458
>> 
> 
> I don't think the fact that at least one system existed over a year
> ago whose UEFI assigned resources incorrectly should prevent us from
> being normative in this case.

My suggestion is to try to reuse the resources if possible. Otherwise, 
reassign the resources.

There were implementation problems by the time you proposed your patch 
and it was delaying progess. That was my objection.

Now that base pci support is in and everybody is  somewhat happy, let's 
figure out the bugs and get this done.

I am ready to test/debug.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (okaya at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Thu, 30 Mar 2017 07:42:12 -0400	[thread overview]
Message-ID: <0c8ba1ac389560358458c10915d85526@codeaurora.org> (raw)
In-Reply-To: <CAKv+Gu-ff98HrPK3f+E8soGJUXaaMxPLs2AuJ+rvXd0HWX-jXw@mail.gmail.com>

On 2017-03-30 06:09, Ard Biesheuvel wrote:
> On 30 March 2017 at 11:05, Lorenzo Pieralisi 
> <lorenzo.pieralisi@arm.com> wrote:
>> On Thu, Mar 30, 2017 at 09:46:39AM +0100, Ard Biesheuvel wrote:
>> 
>> [...]
>> 
>>> > I'm asking why we don't fix the actual problem in PCIe ARM64 adaptation instead
>>> > of working around it by quirks.
>>> >
>>> > I don't see any reason why ACPI ARM64 should carry the burden of legacy systems.
>>> >
>>> > Legacy only applies to DT based systems.
>>> >
>>> 
>>> I fully agree with this point: ACPI implies firmware, and so we 
>>> should
>>> be able to rely on firmware to have initialized the PCIe subsystem by
>>> the time the kernel gets to access it.
>> 
>> https://lkml.org/lkml/2016/3/3/458
>> 
> 
> I don't think the fact that at least one system existed over a year
> ago whose UEFI assigned resources incorrectly should prevent us from
> being normative in this case.

My suggestion is to try to reuse the resources if possible. Otherwise, 
reassign the resources.

There were implementation problems by the time you proposed your patch 
and it was delaying progess. That was my objection.

Now that base pci support is in and everybody is  somewhat happy, let's 
figure out the bugs and get this done.

I am ready to test/debug.

  reply	other threads:[~2017-03-30 11:42 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 15:30 [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer Ard Biesheuvel
2017-03-22 15:30 ` Ard Biesheuvel
2017-03-22 15:30 ` Ard Biesheuvel
     [not found] ` <1490196629-28088-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-22 19:31   ` Lukas Wunner
2017-03-22 19:31     ` Lukas Wunner
2017-03-22 19:31     ` Lukas Wunner
2017-03-22 19:32     ` Ard Biesheuvel
2017-03-22 19:32       ` Ard Biesheuvel
2017-03-22 19:32       ` Ard Biesheuvel
     [not found]       ` <CAKv+Gu_X-SEnz7h9J8boqqjOQGHQawwdSAq4haH-OGu8zdfNfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23  8:48         ` Lukas Wunner
2017-03-23  8:48           ` Lukas Wunner
2017-03-23  8:48           ` Lukas Wunner
2017-03-23  9:04           ` Ard Biesheuvel
2017-03-23  9:04             ` Ard Biesheuvel
2017-03-23  9:04             ` Ard Biesheuvel
     [not found]             ` <CAKv+Gu93eJ-js3g7M6Jdm6XGMaWMswFmzBG2qNT4rn+3=1+EyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 10:57               ` Lorenzo Pieralisi
2017-03-23 10:57                 ` Lorenzo Pieralisi
2017-03-23 10:57                 ` Lorenzo Pieralisi
2017-03-23 12:25                 ` Ard Biesheuvel
2017-03-23 12:25                   ` Ard Biesheuvel
2017-03-23 12:25                   ` Ard Biesheuvel
2017-03-23 14:31                   ` Lorenzo Pieralisi
2017-03-23 14:31                     ` Lorenzo Pieralisi
2017-03-23 14:31                     ` Lorenzo Pieralisi
2017-03-23 15:15                     ` Ard Biesheuvel
2017-03-23 15:15                       ` Ard Biesheuvel
2017-03-23 15:15                       ` Ard Biesheuvel
2017-03-27 15:37                       ` Ard Biesheuvel
2017-03-27 15:37                         ` Ard Biesheuvel
2017-03-27 15:37                         ` Ard Biesheuvel
2017-03-28 21:27                 ` Sinan Kaya
2017-03-28 21:27                   ` Sinan Kaya
2017-03-28 21:27                   ` Sinan Kaya
2017-03-28 21:39                   ` Ard Biesheuvel
2017-03-28 21:39                     ` Ard Biesheuvel
2017-03-28 21:39                     ` Ard Biesheuvel
     [not found]                     ` <CAKv+Gu9LbwpnJNi1OL25MWvYPxEOfKRHcs2jA2121BPaQWPzow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-28 21:49                       ` Sinan Kaya
2017-03-28 21:49                         ` Sinan Kaya
2017-03-28 21:49                         ` Sinan Kaya
     [not found]                         ` <27f50de3-721e-e8ec-00c8-b7a9d3cff0d6-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-30  8:46                           ` Ard Biesheuvel
2017-03-30  8:46                             ` Ard Biesheuvel
2017-03-30  8:46                             ` Ard Biesheuvel
     [not found]                             ` <CAKv+Gu-qRg8-YRCairppKrEfeLcW+OwVF8qZHp7vxXJA_AwPOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-30 10:05                               ` Lorenzo Pieralisi
2017-03-30 10:05                                 ` Lorenzo Pieralisi
2017-03-30 10:05                                 ` Lorenzo Pieralisi
2017-03-30 10:09                                 ` Ard Biesheuvel
2017-03-30 10:09                                   ` Ard Biesheuvel
2017-03-30 10:09                                   ` Ard Biesheuvel
2017-03-30 11:42                                   ` okaya [this message]
2017-03-30 11:42                                     ` okaya at codeaurora.org
2017-03-30 11:42                                     ` okaya
2017-03-30 13:38                                   ` Ard Biesheuvel
2017-03-30 13:38                                     ` Ard Biesheuvel
2017-03-30 13:38                                     ` Ard Biesheuvel
2017-03-30 13:50                                     ` Sinan Kaya
2017-03-30 13:50                                       ` Sinan Kaya
2017-03-30 13:50                                       ` Sinan Kaya
     [not found]                                       ` <ae87ae28-f50d-095f-576e-f3fd7f96dea2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-02 15:16                                         ` Ard Biesheuvel
2017-04-02 15:16                                           ` Ard Biesheuvel
2017-04-02 15:16                                           ` Ard Biesheuvel
     [not found]                                           ` <CAKv+Gu8x0rQUnTUorknW-mW9LFgrxFYsXyy4LU_w9JbA-m_sjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-10 15:28                                             ` Ard Biesheuvel
2017-04-10 15:28                                               ` Ard Biesheuvel
2017-04-10 15:28                                               ` Ard Biesheuvel
2017-04-10 16:53                                               ` Lorenzo Pieralisi
2017-04-10 16:53                                                 ` Lorenzo Pieralisi
2017-04-10 16:53                                                 ` Lorenzo Pieralisi
2017-04-10 17:06                                                 ` Sinan Kaya
2017-04-10 17:06                                                   ` Sinan Kaya
2017-04-10 17:06                                                   ` Sinan Kaya
2017-04-10 17:13                                                 ` Ard Biesheuvel
2017-04-10 17:13                                                   ` Ard Biesheuvel
2017-04-10 17:13                                                   ` Ard Biesheuvel
     [not found]                                                   ` <CAKv+Gu-AN-OwnAJG5dt0Qg4GU8HxZBowTSA0H3LhNA3nHfrsQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-10 17:29                                                     ` Ard Biesheuvel
2017-04-10 17:29                                                       ` Ard Biesheuvel
2017-04-10 17:29                                                       ` Ard Biesheuvel
     [not found]                                                       ` <CAKv+Gu9dS4OhLbBw59yKYQmoJ8SpFexzk9yH=XfXnzn8NJ4mcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-11 13:16                                                         ` Lorenzo Pieralisi
2017-04-11 13:16                                                           ` Lorenzo Pieralisi
2017-04-11 13:16                                                           ` Lorenzo Pieralisi
2017-04-11 16:06                                                           ` Ard Biesheuvel
2017-04-11 16:06                                                             ` Ard Biesheuvel
2017-04-11 16:06                                                             ` Ard Biesheuvel
2017-04-23  1:45                                                       ` Yinghai Lu
2017-04-23  1:45                                                         ` Yinghai Lu
2017-04-23  1:45                                                         ` Yinghai Lu
     [not found]                                                         ` <20170423014546.GA2704-HmG2f/OLMhfd32I7TRUmRQWg3BAJk+jzdezBB/11ZoCIZ3GwZIjcak9v6f1uFnsJ2SarAXORi/o@public.gmane.org>
2017-04-27 13:55                                                           ` Ard Biesheuvel
2017-04-27 13:55                                                             ` Ard Biesheuvel
2017-04-27 13:55                                                             ` Ard Biesheuvel
     [not found]                                                             ` <CAKv+Gu_n7xP-2RtF44GVzwyoMXDOeF-bR43yStwp2y+oBNs4jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 20:51                                                               ` Yinghai Lu
2017-04-28 20:51                                                                 ` Yinghai Lu
2017-04-28 20:51                                                                 ` Yinghai Lu
2017-03-22 19:36     ` Sinan Kaya
2017-03-22 19:36       ` Sinan Kaya
2017-03-22 19:36       ` Sinan Kaya
2017-03-22 19:41       ` Ard Biesheuvel
2017-03-22 19:41         ` Ard Biesheuvel
2017-03-22 19:41         ` Ard Biesheuvel
2017-03-22 19:49         ` Sinan Kaya
2017-03-22 19:49           ` Sinan Kaya
2017-03-22 19:49           ` Sinan Kaya
2017-03-22 19:52           ` Ard Biesheuvel
2017-03-22 19:52             ` Ard Biesheuvel
2017-03-22 19:52             ` Ard Biesheuvel
2017-03-22 19:57             ` Sinan Kaya
2017-03-22 19:57               ` Sinan Kaya
2017-03-22 19:57               ` Sinan Kaya
     [not found]               ` <4ccb4d92-3830-3980-38c3-7085a3d97734-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-22 20:00                 ` Ard Biesheuvel
2017-03-22 20:00                   ` Ard Biesheuvel
2017-03-22 20:00                   ` Ard Biesheuvel
2017-05-03  3:09   ` Heyi Guo
2017-05-03  3:09     ` Heyi Guo
2017-05-03  3:09     ` Heyi Guo
2017-05-18 14:01     ` Bjorn Helgaas
2017-05-18 14:01       ` Bjorn Helgaas
2017-05-18 14:01       ` Bjorn Helgaas
     [not found]       ` <20170518140154.GA24324-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2017-05-20  8:19         ` Heyi Guo
2017-05-20  8:19           ` Heyi Guo
2017-05-20  8:19           ` Heyi Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c8ba1ac389560358458c10915d85526@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=hanjun.guo@linaro.org \
    --cc=heyi.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lukas@wunner.de \
    --cc=matt@codeblueprint.co.uk \
    --cc=pjones@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.