* [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes
@ 2018-07-04 11:52 Dou Liyang
2018-07-04 12:57 ` Dou Liyang
0 siblings, 1 reply; 2+ messages in thread
From: Dou Liyang @ 2018-07-04 11:52 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, imammedo, Dou Liyang
Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()")
broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0.
Due to the NUMA setup will also check the value of nb_numa_nodes, remove the
check from machine_run_board_init() to fix ths bug.
Fixes 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()")
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
hw/core/machine.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 2077328bcc..962346f90d 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -791,10 +791,8 @@ void machine_run_board_init(MachineState *machine)
{
MachineClass *machine_class = MACHINE_GET_CLASS(machine);
- if (nb_numa_nodes) {
- numa_complete_configuration(machine);
- machine_numa_finish_cpu_init(machine);
- }
+ numa_complete_configuration(machine);
+ machine_numa_finish_cpu_init(machine);
/* If the machine supports the valid_cpu_types check and the user
* specified a CPU with -cpu check here that the user CPU is supported.
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes
2018-07-04 11:52 [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes Dou Liyang
@ 2018-07-04 12:57 ` Dou Liyang
0 siblings, 0 replies; 2+ messages in thread
From: Dou Liyang @ 2018-07-04 12:57 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, imammedo
At 07/04/2018 07:52 PM, Dou Liyang wrote:
> Commit 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()")
> broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
>
> The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0.
>
> Due to the NUMA setup will also check the value of nb_numa_nodes, remove the
> check from machine_run_board_init() to fix ths bug.
>
> Fixes 7a3099fc9c5c("numa: postpone options post-processing till machine_run_board_init()")
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> ---
> hw/core/machine.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Please ignore this patch, it breaks the "make check", will send v2.
Thanks,
dou
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 2077328bcc..962346f90d 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -791,10 +791,8 @@ void machine_run_board_init(MachineState *machine)
> {
> MachineClass *machine_class = MACHINE_GET_CLASS(machine);
>
> - if (nb_numa_nodes) {
> - numa_complete_configuration(machine);
> - machine_numa_finish_cpu_init(machine);
> - }
> + numa_complete_configuration(machine);
> + machine_numa_finish_cpu_init(machine);
>
> /* If the machine supports the valid_cpu_types check and the user
> * specified a CPU with -cpu check here that the user CPU is supported.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-04 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 11:52 [Qemu-devel] [PATCH] hw/machine: Remove the Zero check of nb_numa_nodes Dou Liyang
2018-07-04 12:57 ` Dou Liyang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.