* [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
@ 2022-11-26 9:24 ` Zheng Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Zheng Yongjun @ 2022-11-26 9:24 UTC (permalink / raw)
To: shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: kernel, festevam, linux-imx
In case of error, the function of_clk_get_by_name()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/soc/imx/soc-imx8m.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..32ed9dc88e45 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
clk = of_clk_get_by_name(np, NULL);
- if (!clk) {
- WARN_ON(!clk);
+ if (IS_ERR(clk)) {
+ WARN_ON(IS_ERR(clk));
return 0;
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
@ 2022-11-26 9:24 ` Zheng Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Zheng Yongjun @ 2022-11-26 9:24 UTC (permalink / raw)
To: shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: kernel, festevam, linux-imx
In case of error, the function of_clk_get_by_name()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/soc/imx/soc-imx8m.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..32ed9dc88e45 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
clk = of_clk_get_by_name(np, NULL);
- if (!clk) {
- WARN_ON(!clk);
+ if (IS_ERR(clk)) {
+ WARN_ON(IS_ERR(clk));
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
2022-11-26 9:24 ` Zheng Yongjun
@ 2022-11-28 7:56 ` Ahmad Fatoum
-1 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-11-28 7:56 UTC (permalink / raw)
To: Zheng Yongjun, shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: festevam, linux-imx, kernel
Hi Zheng,
On 26.11.22 10:24, Zheng Yongjun wrote:
> In case of error, the function of_clk_get_by_name()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/soc/imx/soc-imx8m.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..32ed9dc88e45 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
> clk = of_clk_get_by_name(np, NULL);
> - if (!clk) {
> - WARN_ON(!clk);
> + if (IS_ERR(clk)) {
> + WARN_ON(IS_ERR(clk));
> return 0;
You could also rewrite as
if (WARN_ON(IS_ERR(clk))
return 0;
To make it more concise. Change looks good though:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cheers,
Ahmad
> }
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
@ 2022-11-28 7:56 ` Ahmad Fatoum
0 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-11-28 7:56 UTC (permalink / raw)
To: Zheng Yongjun, shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: festevam, linux-imx, kernel
Hi Zheng,
On 26.11.22 10:24, Zheng Yongjun wrote:
> In case of error, the function of_clk_get_by_name()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/soc/imx/soc-imx8m.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..32ed9dc88e45 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
> clk = of_clk_get_by_name(np, NULL);
> - if (!clk) {
> - WARN_ON(!clk);
> + if (IS_ERR(clk)) {
> + WARN_ON(IS_ERR(clk));
> return 0;
You could also rewrite as
if (WARN_ON(IS_ERR(clk))
return 0;
To make it more concise. Change looks good though:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cheers,
Ahmad
> }
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* 答复: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
2022-11-28 7:56 ` Ahmad Fatoum
@ 2022-11-28 8:41 ` zhengyongjun
-1 siblings, 0 replies; 6+ messages in thread
From: zhengyongjun @ 2022-11-28 8:41 UTC (permalink / raw)
To: Ahmad Fatoum, shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: festevam, linux-imx, kernel
Thanks for your adivice :)
Zheng
-----邮件原件-----
发件人: Ahmad Fatoum [mailto:a.fatoum@pengutronix.de]
发送时间: 2022年11月28日 15:56
收件人: zhengyongjun <zhengyongjun3@huawei.com>; shawnguo@kernel.org; s.hauer@pengutronix.de; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
抄送: festevam@gmail.com; linux-imx@nxp.com; kernel@pengutronix.de
主题: Re: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
Hi Zheng,
On 26.11.22 10:24, Zheng Yongjun wrote:
> In case of error, the function of_clk_get_by_name() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading
> the register")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/soc/imx/soc-imx8m.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..32ed9dc88e45 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
> clk = of_clk_get_by_name(np, NULL);
> - if (!clk) {
> - WARN_ON(!clk);
> + if (IS_ERR(clk)) {
> + WARN_ON(IS_ERR(clk));
> return 0;
You could also rewrite as
if (WARN_ON(IS_ERR(clk))
return 0;
To make it more concise. Change looks good though:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cheers,
Ahmad
> }
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
* 答复: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
@ 2022-11-28 8:41 ` zhengyongjun
0 siblings, 0 replies; 6+ messages in thread
From: zhengyongjun @ 2022-11-28 8:41 UTC (permalink / raw)
To: Ahmad Fatoum, shawnguo, s.hauer, linux-arm-kernel, linux-kernel
Cc: festevam, linux-imx, kernel
Thanks for your adivice :)
Zheng
-----邮件原件-----
发件人: Ahmad Fatoum [mailto:a.fatoum@pengutronix.de]
发送时间: 2022年11月28日 15:56
收件人: zhengyongjun <zhengyongjun3@huawei.com>; shawnguo@kernel.org; s.hauer@pengutronix.de; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
抄送: festevam@gmail.com; linux-imx@nxp.com; kernel@pengutronix.de
主题: Re: [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision()
Hi Zheng,
On 26.11.22 10:24, Zheng Yongjun wrote:
> In case of error, the function of_clk_get_by_name() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading
> the register")
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/soc/imx/soc-imx8m.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..32ed9dc88e45 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
> clk = of_clk_get_by_name(np, NULL);
> - if (!clk) {
> - WARN_ON(!clk);
> + if (IS_ERR(clk)) {
> + WARN_ON(IS_ERR(clk));
> return 0;
You could also rewrite as
if (WARN_ON(IS_ERR(clk))
return 0;
To make it more concise. Change looks good though:
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cheers,
Ahmad
> }
>
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-28 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-26 9:24 [PATCH] soc: imx8m: Fix return value check in imx8mq_soc_revision() Zheng Yongjun
2022-11-26 9:24 ` Zheng Yongjun
2022-11-28 7:56 ` Ahmad Fatoum
2022-11-28 7:56 ` Ahmad Fatoum
2022-11-28 8:41 ` 答复: " zhengyongjun
2022-11-28 8:41 ` zhengyongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.