All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Cree <ecree@solarflare.com>
To: kernel test robot <lkp@intel.com>,
	<linux-net-drivers@solarflare.com>, <davem@davemloft.net>
Cc: <kbuild-all@lists.01.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 net-next 04/16] sfc: skeleton EF100 PF driver
Date: Mon, 27 Jul 2020 11:41:04 +0100	[thread overview]
Message-ID: <0c9d51a0-4583-6f5a-46e3-c27dd4e0315c@solarflare.com> (raw)
In-Reply-To: <202007250411.qUhQvyZz%lkp@intel.com>

On 24/07/2020 21:32, kernel test robot wrote:
> Hi Edward,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-1/20200725-000401
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1b6687e31a2df9fbdb12d25c1d1d372777bf96a8
> config: microblaze-randconfig-r021-20200725 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
>>> drivers/net/ethernet/sfc/siena.c:1021:16: error: '__efx_enqueue_skb' undeclared here (not in a function); did you mean 'efx_enqueue_skb'?
>     1021 |  .tx_enqueue = __efx_enqueue_skb,
>          |                ^~~~~~~~~~~~~~~~~
>          |                efx_enqueue_skb
Aaaaaargh.
Apparently INDIRECT_CALLABLE_DECLARE doesn't declare anything #ifndef
 CONFIG_RETPOLINE.  I presumably misunderstood what it was for, and I
 should just declare those prototypes normally, without it.

Time to spin a v5...

-ed

WARNING: multiple messages have this Message-ID (diff)
From: Edward Cree <ecree@solarflare.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 net-next 04/16] sfc: skeleton EF100 PF driver
Date: Mon, 27 Jul 2020 11:41:04 +0100	[thread overview]
Message-ID: <0c9d51a0-4583-6f5a-46e3-c27dd4e0315c@solarflare.com> (raw)
In-Reply-To: <202007250411.qUhQvyZz%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

On 24/07/2020 21:32, kernel test robot wrote:
> Hi Edward,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-1/20200725-000401
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1b6687e31a2df9fbdb12d25c1d1d372777bf96a8
> config: microblaze-randconfig-r021-20200725 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
>>> drivers/net/ethernet/sfc/siena.c:1021:16: error: '__efx_enqueue_skb' undeclared here (not in a function); did you mean 'efx_enqueue_skb'?
>     1021 |  .tx_enqueue = __efx_enqueue_skb,
>          |                ^~~~~~~~~~~~~~~~~
>          |                efx_enqueue_skb
Aaaaaargh.
Apparently INDIRECT_CALLABLE_DECLARE doesn't declare anything #ifndef
 CONFIG_RETPOLINE.  I presumably misunderstood what it was for, and I
 should just declare those prototypes normally, without it.

Time to spin a v5...

-ed

  reply	other threads:[~2020-07-27 10:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 15:56 [PATCH v4 net-next 00/16] sfc: driver for EF100 family NICs, part 1 Edward Cree
2020-07-24 15:57 ` [PATCH v4 net-next 01/16] sfc: remove efx_ethtool_nway_reset() Edward Cree
2020-07-24 15:57 ` [PATCH v4 net-next 02/16] sfc_ef100: add EF100 register definitions Edward Cree
2020-07-24 15:57 ` [PATCH v4 net-next 03/16] sfc_ef100: register accesses on EF100 Edward Cree
2020-07-24 15:57 ` [PATCH v4 net-next 04/16] sfc: skeleton EF100 PF driver Edward Cree
2020-07-24 20:32   ` kernel test robot
2020-07-24 20:32     ` kernel test robot
2020-07-27 10:41     ` Edward Cree [this message]
2020-07-27 10:41       ` Edward Cree
2020-07-24 21:44   ` kernel test robot
2020-07-24 21:44     ` kernel test robot
2020-07-24 15:58 ` [PATCH v4 net-next 05/16] sfc_ef100: reset-handling stub Edward Cree
2020-07-24 15:58 ` [PATCH v4 net-next 06/16] sfc_ef100: PHY probe stub Edward Cree
2020-07-24 15:58 ` [PATCH v4 net-next 07/16] sfc_ef100: don't call efx_reset_down()/up() on EF100 Edward Cree
2020-07-24 15:58 ` [PATCH v4 net-next 08/16] sfc_ef100: implement MCDI transport Edward Cree
2020-07-24 15:59 ` [PATCH v4 net-next 09/16] sfc_ef100: implement ndo_open/close and EVQ probing Edward Cree
2020-07-24 21:54   ` kernel test robot
2020-07-24 21:54     ` kernel test robot
2020-07-24 15:59 ` [PATCH v4 net-next 10/16] sfc_ef100: process events for MCDI completions Edward Cree
2020-07-24 15:59 ` [PATCH v4 net-next 11/16] sfc_ef100: read datapath caps, implement check_caps Edward Cree
2020-07-24 16:00 ` [PATCH v4 net-next 12/16] sfc_ef100: extend ef100_check_caps to cover datapath_caps3 Edward Cree
2020-07-24 16:00 ` [PATCH v4 net-next 13/16] sfc_ef100: actually perform resets Edward Cree
2020-07-24 16:00 ` [PATCH v4 net-next 14/16] sfc_ef100: probe the PHY and configure the MAC Edward Cree
2020-07-24 16:01 ` [PATCH v4 net-next 15/16] sfc_ef100: read device MAC address at probe time Edward Cree
2020-07-24 16:01 ` [PATCH v4 net-next 16/16] sfc_ef100: implement ndo_get_phys_port_{id,name} Edward Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c9d51a0-4583-6f5a-46e3-c27dd4e0315c@solarflare.com \
    --to=ecree@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.