From: Christophe Leroy <christophe.leroy@c-s.fr> To: Horia Geanta <horia.geanta@nxp.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net> Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH v2 0/4] Additional fixes on Talitos driver Date: Tue, 11 Jun 2019 17:40:09 +0200 [thread overview] Message-ID: <0cb7c534-6e48-5284-899c-c0ef85c3c126@c-s.fr> (raw) In-Reply-To: <VI1PR0402MB34853CAF031426F4183FE29B98ED0@VI1PR0402MB3485.eurprd04.prod.outlook.com> Le 11/06/2019 à 17:37, Horia Geanta a écrit : > On 6/11/2019 5:39 PM, Christophe Leroy wrote: >> This series is the last set of fixes for the Talitos driver. >> >> We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and >> SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: >> > I am getting below failures on a sec 3.3.2 (p1020rdb) for hmac(sha384) and > hmac(sha512): Is that new with this series or did you already have it before ? What do you mean by "fuzz testing" enabled ? Is that CONFIG_CRYPTO_MANAGER_EXTRA_TESTS or something else ? Christophe > > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=2497 ksize=124", cfg="random: inplace use_finup nosimd src_divs=[<reimport>76.49%@+4002, <reimport>23.51%@alignmask+26] iv_offset=4" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=27 ksize=121", cfg="random: inplace may_sleep use_digest src_divs=[100.0%@+10] iv_offset=9" > > Reproducibility rate is 100% so far, here are a few more runs - they might help finding a pattern: > > 1. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=184 ksize=121", cfg="random: use_finup src_divs=[<reimport,nosimd>100.0%@+3988] dst_divs=[100.0%@+547] iv_offset=44" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=7 ksize=122", cfg="random: may_sleep use_digest src_divs=[100.0%@+3968] dst_divs=[100.0%@+20]" > > 2. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=6481 ksize=120", cfg="random: use_final src_divs=[<reimport>100.0%@+6] dst_divs=[43.84%@alignmask+6, 56.16%@+22]" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=635 ksize=128", cfg="random: may_sleep use_finup src_divs=[100.0%@+4062] dst_divs=[20.47%@+2509, 72.36%@alignmask+2, 7.17%@alignmask+3990]" > > 3. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=2428 ksize=127", cfg="random: may_sleep use_finup src_divs=[<reimport>35.19%@+18, 64.81%@+1755] dst_divs=[100.0%@+111] iv_offset=5" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=4345 ksize=128", cfg="random: may_sleep use_digest src_divs=[100.0%@+2820] iv_offset=59" > > If you run several times with fuzz testing enabled on your sec2.2, > are you able to see similar failures? > > Thanks, > Horia >
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr> To: Horia Geanta <horia.geanta@nxp.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net> Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 0/4] Additional fixes on Talitos driver Date: Tue, 11 Jun 2019 17:40:09 +0200 [thread overview] Message-ID: <0cb7c534-6e48-5284-899c-c0ef85c3c126@c-s.fr> (raw) In-Reply-To: <VI1PR0402MB34853CAF031426F4183FE29B98ED0@VI1PR0402MB3485.eurprd04.prod.outlook.com> Le 11/06/2019 à 17:37, Horia Geanta a écrit : > On 6/11/2019 5:39 PM, Christophe Leroy wrote: >> This series is the last set of fixes for the Talitos driver. >> >> We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and >> SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: >> > I am getting below failures on a sec 3.3.2 (p1020rdb) for hmac(sha384) and > hmac(sha512): Is that new with this series or did you already have it before ? What do you mean by "fuzz testing" enabled ? Is that CONFIG_CRYPTO_MANAGER_EXTRA_TESTS or something else ? Christophe > > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=2497 ksize=124", cfg="random: inplace use_finup nosimd src_divs=[<reimport>76.49%@+4002, <reimport>23.51%@alignmask+26] iv_offset=4" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=27 ksize=121", cfg="random: inplace may_sleep use_digest src_divs=[100.0%@+10] iv_offset=9" > > Reproducibility rate is 100% so far, here are a few more runs - they might help finding a pattern: > > 1. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=184 ksize=121", cfg="random: use_finup src_divs=[<reimport,nosimd>100.0%@+3988] dst_divs=[100.0%@+547] iv_offset=44" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=7 ksize=122", cfg="random: may_sleep use_digest src_divs=[100.0%@+3968] dst_divs=[100.0%@+20]" > > 2. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=6481 ksize=120", cfg="random: use_final src_divs=[<reimport>100.0%@+6] dst_divs=[43.84%@alignmask+6, 56.16%@+22]" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=635 ksize=128", cfg="random: may_sleep use_finup src_divs=[100.0%@+4062] dst_divs=[20.47%@+2509, 72.36%@alignmask+2, 7.17%@alignmask+3990]" > > 3. > alg: ahash: hmac-sha384-talitos test failed (wrong result) on test vector "random: psize=2428 ksize=127", cfg="random: may_sleep use_finup src_divs=[<reimport>35.19%@+18, 64.81%@+1755] dst_divs=[100.0%@+111] iv_offset=5" > alg: ahash: hmac-sha512-talitos test failed (wrong result) on test vector "random: psize=4345 ksize=128", cfg="random: may_sleep use_digest src_divs=[100.0%@+2820] iv_offset=59" > > If you run several times with fuzz testing enabled on your sec2.2, > are you able to see similar failures? > > Thanks, > Horia >
next prev parent reply other threads:[~2019-06-11 15:40 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-11 14:39 [PATCH v2 0/4] Additional fixes on Talitos driver Christophe Leroy 2019-06-11 14:39 ` Christophe Leroy 2019-06-11 14:39 ` [PATCH v2 1/4] crypto: talitos - move struct talitos_edesc into talitos.h Christophe Leroy 2019-06-11 14:39 ` Christophe Leroy 2019-06-13 12:13 ` Horia Geanta 2019-06-13 12:13 ` Horia Geanta 2019-06-13 12:16 ` Christophe Leroy 2019-06-13 12:16 ` Christophe Leroy 2019-06-13 12:24 ` Horia Geanta 2019-06-13 12:24 ` Horia Geanta 2019-06-13 12:32 ` Christophe Leroy 2019-06-13 12:32 ` Christophe Leroy 2019-06-13 12:39 ` Horia Geanta 2019-06-13 12:39 ` Horia Geanta 2019-06-13 12:50 ` Christophe Leroy 2019-06-13 12:50 ` Christophe Leroy 2019-06-11 14:39 ` [PATCH v2 2/4] crypto: talitos - fix hash on SEC1 Christophe Leroy 2019-06-11 14:39 ` Christophe Leroy 2019-06-11 14:39 ` [PATCH v2 3/4] crypto: talitos - eliminate unneeded 'done' functions at build time Christophe Leroy 2019-06-11 14:39 ` Christophe Leroy 2019-06-13 12:16 ` Horia Geanta 2019-06-13 12:16 ` Horia Geanta 2019-06-11 14:39 ` [PATCH v2 4/4] crypto: talitos - drop icv_ool Christophe Leroy 2019-06-11 14:39 ` Christophe Leroy 2019-06-13 12:21 ` Horia Geanta 2019-06-13 12:21 ` Horia Geanta 2019-06-13 12:28 ` Christophe Leroy 2019-06-13 12:28 ` Christophe Leroy 2019-06-13 13:09 ` Herbert Xu 2019-06-13 13:09 ` Herbert Xu 2019-06-11 15:37 ` [PATCH v2 0/4] Additional fixes on Talitos driver Horia Geanta 2019-06-11 15:37 ` Horia Geanta 2019-06-11 15:40 ` Christophe Leroy [this message] 2019-06-11 15:40 ` Christophe Leroy 2019-06-11 16:30 ` Horia Geanta 2019-06-11 16:30 ` Horia Geanta 2019-06-11 17:16 ` Christophe Leroy 2019-06-11 17:16 ` Christophe Leroy 2019-06-12 5:52 ` Christophe Leroy 2019-06-12 5:52 ` Christophe Leroy 2019-06-12 13:59 ` Horia Geanta 2019-06-12 13:59 ` Horia Geanta 2019-06-13 4:57 ` Christophe Leroy 2019-06-13 4:57 ` Christophe Leroy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0cb7c534-6e48-5284-899c-c0ef85c3c126@c-s.fr \ --to=christophe.leroy@c-s.fr \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=horia.geanta@nxp.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.