* [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
@ 2020-02-28 18:57 Julien Grall
2020-02-28 19:07 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2020-02-28 18:57 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
Andrew Cooper, Julien Grall, Ian Jackson, George Dunlap,
Jan Beulich
From: Julien Grall <jgrall@amazon.com>
The name of the variable 'led' is confusing and only used in one place a
line after. So remove it.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/common/grant_table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 057c78f620..9fd6e60416 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -944,7 +944,6 @@ map_grant_ref(
struct domain *ld, *rd, *owner = NULL;
struct grant_table *lgt, *rgt;
grant_ref_t ref;
- struct vcpu *led;
grant_handle_t handle;
mfn_t mfn;
struct page_info *pg = NULL;
@@ -957,8 +956,7 @@ map_grant_ref(
uint16_t *status;
bool_t need_iommu;
- led = current;
- ld = led->domain;
+ ld = current->domain;
if ( unlikely((op->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0) )
{
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
2020-02-28 18:57 [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref Julien Grall
@ 2020-02-28 19:07 ` Andrew Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2020-02-28 19:07 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk, Julien Grall,
Ian Jackson, George Dunlap, Jan Beulich
On 28/02/2020 18:57, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The name of the variable 'led' is confusing and only used in one place a
> line after. So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
I agree. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
2020-02-28 18:57 Julien Grall
@ 2020-02-28 18:58 ` Julien Grall
0 siblings, 0 replies; 4+ messages in thread
From: Julien Grall @ 2020-02-28 18:58 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall
Please ignore this version as I forgot to CC the maintainers on it.
Cheers,
On 28/02/2020 18:57, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The name of the variable 'led' is confusing and only used in one place a
> line after. So remove it.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
> xen/common/grant_table.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index 057c78f620..9fd6e60416 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -944,7 +944,6 @@ map_grant_ref(
> struct domain *ld, *rd, *owner = NULL;
> struct grant_table *lgt, *rgt;
> grant_ref_t ref;
> - struct vcpu *led;
> grant_handle_t handle;
> mfn_t mfn;
> struct page_info *pg = NULL;
> @@ -957,8 +956,7 @@ map_grant_ref(
> uint16_t *status;
> bool_t need_iommu;
>
> - led = current;
> - ld = led->domain;
> + ld = current->domain;
>
> if ( unlikely((op->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0) )
> {
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref
@ 2020-02-28 18:57 Julien Grall
2020-02-28 18:58 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2020-02-28 18:57 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall
From: Julien Grall <jgrall@amazon.com>
The name of the variable 'led' is confusing and only used in one place a
line after. So remove it.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/common/grant_table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 057c78f620..9fd6e60416 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -944,7 +944,6 @@ map_grant_ref(
struct domain *ld, *rd, *owner = NULL;
struct grant_table *lgt, *rgt;
grant_ref_t ref;
- struct vcpu *led;
grant_handle_t handle;
mfn_t mfn;
struct page_info *pg = NULL;
@@ -957,8 +956,7 @@ map_grant_ref(
uint16_t *status;
bool_t need_iommu;
- led = current;
- ld = led->domain;
+ ld = current->domain;
if ( unlikely((op->flags & (GNTMAP_device_map|GNTMAP_host_map)) == 0) )
{
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-28 19:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 18:57 [Xen-devel] [PATCH] xen/grant-table: Remove 'led' variable in map_grant_ref Julien Grall
2020-02-28 19:07 ` Andrew Cooper
-- strict thread matches above, loose matches on Subject: below --
2020-02-28 18:57 Julien Grall
2020-02-28 18:58 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.