* [PATCH] cgroup: Remove stale comments
@ 2020-05-13 2:13 ` Zefan Li
0 siblings, 0 replies; 6+ messages in thread
From: Zefan Li @ 2020-05-13 2:13 UTC (permalink / raw)
To: Tejun Heo, Johannes Weiner; +Cc: Cgroups, LKML
- The default root is where we can create v2 cgroups.
- The __DEVEL__sane_behavior mount option has been removed long long ago.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
found these when fixing the netprio cgroup bug.
---
kernel/cgroup/cgroup.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 06b5ea9..7a01674 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -153,11 +153,7 @@ static struct static_key_true *cgroup_subsys_on_dfl_key[] = {
static DEFINE_PER_CPU(struct cgroup_rstat_cpu, cgrp_dfl_root_rstat_cpu);
-/*
- * The default hierarchy, reserved for the subsystems that are otherwise
- * unattached - it never has more than a single cgroup, and all tasks are
- * part of that cgroup.
- */
+/* the default hierarchy */
struct cgroup_root cgrp_dfl_root = { .cgrp.rstat_cpu = &cgrp_dfl_root_rstat_cpu };
EXPORT_SYMBOL_GPL(cgrp_dfl_root);
@@ -251,9 +247,6 @@ bool cgroup_ssid_enabled(int ssid)
* cases where a subsystem should behave differnetly depending on the
* interface version.
*
- * The set of behaviors which change on the default hierarchy are still
- * being determined and the mount option is prefixed with __DEVEL__.
- *
* List of changed behaviors:
*
* - Mount options "noprefix", "xattr", "clone_children", "release_agent"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] cgroup: Remove stale comments
@ 2020-05-13 2:13 ` Zefan Li
0 siblings, 0 replies; 6+ messages in thread
From: Zefan Li @ 2020-05-13 2:13 UTC (permalink / raw)
To: Tejun Heo, Johannes Weiner; +Cc: Cgroups, LKML
- The default root is where we can create v2 cgroups.
- The __DEVEL__sane_behavior mount option has been removed long long ago.
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
found these when fixing the netprio cgroup bug.
---
kernel/cgroup/cgroup.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 06b5ea9..7a01674 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -153,11 +153,7 @@ static struct static_key_true *cgroup_subsys_on_dfl_key[] = {
static DEFINE_PER_CPU(struct cgroup_rstat_cpu, cgrp_dfl_root_rstat_cpu);
-/*
- * The default hierarchy, reserved for the subsystems that are otherwise
- * unattached - it never has more than a single cgroup, and all tasks are
- * part of that cgroup.
- */
+/* the default hierarchy */
struct cgroup_root cgrp_dfl_root = { .cgrp.rstat_cpu = &cgrp_dfl_root_rstat_cpu };
EXPORT_SYMBOL_GPL(cgrp_dfl_root);
@@ -251,9 +247,6 @@ bool cgroup_ssid_enabled(int ssid)
* cases where a subsystem should behave differnetly depending on the
* interface version.
*
- * The set of behaviors which change on the default hierarchy are still
- * being determined and the mount option is prefixed with __DEVEL__.
- *
* List of changed behaviors:
*
* - Mount options "noprefix", "xattr", "clone_children", "release_agent"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cgroup: Remove stale comments
@ 2020-05-26 17:20 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2020-05-26 17:20 UTC (permalink / raw)
To: Zefan Li; +Cc: Johannes Weiner, Cgroups, LKML
On Wed, May 13, 2020 at 10:13:11AM +0800, Zefan Li wrote:
> - The default root is where we can create v2 cgroups.
> - The __DEVEL__sane_behavior mount option has been removed long long ago.
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Applied to cgroup/for-5.8.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cgroup: Remove stale comments
@ 2020-05-26 17:20 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2020-05-26 17:20 UTC (permalink / raw)
To: Zefan Li; +Cc: Johannes Weiner, Cgroups, LKML
On Wed, May 13, 2020 at 10:13:11AM +0800, Zefan Li wrote:
> - The default root is where we can create v2 cgroups.
> - The __DEVEL__sane_behavior mount option has been removed long long ago.
>
> Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-5.8.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] cgroup: Remove stale comments
@ 2021-01-13 6:29 ` Li Feng
0 siblings, 0 replies; 6+ messages in thread
From: Li Feng @ 2021-01-13 6:29 UTC (permalink / raw)
To: tj, lizefan, hannes; +Cc: cgroups, linux-kernel, Li Feng
The function "cgroup_mount" had beed removed, remove related comments
to prevent confusion.
Related commit:90129625d9203a917f(cgroup: start switching to fs_context)
Signed-off-by: Li Feng <lifeng2221dd1@zoho.com.cn>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 613845769103..493547b4941c 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2139,7 +2139,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] cgroup: Remove stale comments
@ 2021-01-13 6:29 ` Li Feng
0 siblings, 0 replies; 6+ messages in thread
From: Li Feng @ 2021-01-13 6:29 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A, lizefan-hv44wF8Li93QT0dZR+AlfA,
hannes-druUgvl0LCNAfugRpC6u6w
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Li Feng
The function "cgroup_mount" had beed removed, remove related comments
to prevent confusion.
Related commit:90129625d9203a917f(cgroup: start switching to fs_context)
Signed-off-by: Li Feng <lifeng2221dd1-ytc+IHgoah3M1kAEIRd3EQ@public.gmane.org>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 613845769103..493547b4941c 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2139,7 +2139,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-13 6:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 2:13 [PATCH] cgroup: Remove stale comments Zefan Li
2020-05-13 2:13 ` Zefan Li
2020-05-26 17:20 ` Tejun Heo
2020-05-26 17:20 ` Tejun Heo
2021-01-13 6:29 Li Feng
2021-01-13 6:29 ` Li Feng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.