From: Simon Rowe <simon.rowe@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: simon.rowe@eu.citrix.com
Subject: [PATCH] xs: set read_thread stacksize
Date: Tue, 29 May 2012 16:56:40 +0100 [thread overview]
Message-ID: <0cf61ed6ce86de2b61db.1338307000@drall.uk.xensource.com> (raw)
xs_watch() creates a thread to wake watchers using default attributes. The
stacksize can be quite large (8 MB on Linux), applications that link against
xenstore end up having a larger memory footprint than necessary.
Signed-off-by: Simon Rowe <simon.rowe@eu.citrix.com>
diff -r 53e0571f94e4 -r 0cf61ed6ce86 tools/xenstore/xs.c
--- a/tools/xenstore/xs.c Fri May 25 08:21:25 2012 +0100
+++ b/tools/xenstore/xs.c Tue May 29 16:45:03 2012 +0100
@@ -705,11 +705,31 @@ bool xs_watch(struct xs_handle *h, const
/* We dynamically create a reader thread on demand. */
mutex_lock(&h->request_mutex);
if (!h->read_thr_exists) {
+#if _POSIX_THREAD_ATTR_STACKSIZE > 0
+ pthread_attr_t attr;
+
+ if (pthread_attr_init(&attr) != 0) {
+ mutex_unlock(&h->request_mutex);
+ return false;
+ }
+ if (pthread_attr_setstacksize(&attr, 16 * 1024) != 0) {
+ pthread_attr_destroy(&attr);
+ mutex_unlock(&h->request_mutex);
+ return false;
+ }
+
+ if (pthread_create(&h->read_thr, &attr, read_thread, h) != 0) {
+ pthread_attr_destroy(&attr);
+#else
if (pthread_create(&h->read_thr, NULL, read_thread, h) != 0) {
+#endif
mutex_unlock(&h->request_mutex);
return false;
}
h->read_thr_exists = 1;
+#if _POSIX_THREAD_ATTR_STACKSIZE > 0
+ pthread_attr_destroy(&attr);
+#endif
}
mutex_unlock(&h->request_mutex);
#endif
next reply other threads:[~2012-05-29 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 15:56 Simon Rowe [this message]
2012-05-29 16:39 ` [PATCH] xs: set read_thread stacksize David Vrabel
2012-05-29 19:39 ` Ian Campbell
2012-05-30 7:56 ` Simon Rowe
2012-05-30 9:40 ` Ian Campbell
2012-05-30 12:10 ` Simon Rowe
2012-05-31 7:32 ` Ian Campbell
2012-06-21 9:09 ` Roger Pau Monne
2012-06-21 9:18 ` Ian Campbell
2012-06-21 9:39 ` Roger Pau Monne
2012-06-21 10:18 ` Ian Campbell
2012-06-21 10:27 ` Roger Pau Monne
2012-06-21 10:32 ` Ian Campbell
2012-06-21 17:19 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cf61ed6ce86de2b61db.1338307000@drall.uk.xensource.com \
--to=simon.rowe@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.