Re: [PATCH] xs: set read_thread stacksize

[Roger Pau Monne <roger.pau@citrix.com>]

Ian Campbell wrote:
> On Wed, 2012-05-30 at 13:10 +0100, Simon Rowe wrote:
>> On Wednesday 30 May 2012 10:40:15 Ian Campbell wrote:
>>
>>> If this little trick applies to both NetBSD and uclibc too then I guess
>>> it would be OK, otherwise I think autoconf is necessary.
>> It doesn't look to my untrained eye that xenstore is autoconf-aware. The
>> makefile unilaterally sets USE_PTHREAD for example.
>
> It has autoconf stuff available to it, I think, it just hasn't had cause
> to use it yet...
>
> (USE_PTHREAD is a bit of an odd one anyway, it refers only to the client
> library/cmdline tools and is for building against libc's which don't
> have pthreads)
>
>> Shall I just drop this test for now and if/when xenstore is updated to use
>> autoconf it can be addressed then?
>
> I'd like to here from Roger about what this means for NetBSD and uclibc,
> if it works on those then I think it is fine to do this.

Sorry for the delay, I just received this today (don't know why). I've 
been looking at NetBSD and uClibc, and both have pthread_attr_setstacksize.

What I don't really like is the hardcoded (16 * 1024) value, how do you 
know this is greater than PTHREAD_STACK_MIN?

Frankly I don't understand why do we have to touch this, even if you 
requested 256MB of stack it won't we allocated until you get a page 
fault, so you are only using the physical memory you need.