* [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs @ 2019-11-26 17:08 Igor Druzhinin 2019-11-26 17:14 ` Andrew Cooper 2019-11-27 4:24 ` Jürgen Groß 0 siblings, 2 replies; 3+ messages in thread From: Igor Druzhinin @ 2019-11-26 17:08 UTC (permalink / raw) To: xen-devel; +Cc: jgross, andrew.cooper3, jbeulich, Igor Druzhinin IV bit shouldn't be set in DTE if interrupt remapping is not enabled. It's a regression in behavior of "iommu=no-intremap" option which otherwise would keep interrupt requests untranslated for all of the devices in the system regardless of wether it's described as valid in IVRS or not. Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> --- xen/drivers/passthrough/amd/iommu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 16e84d4..2b81e38 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -1279,7 +1279,7 @@ static int __init amd_iommu_setup_device_table( for ( bdf = 0, size /= sizeof(*dt); bdf < size; ++bdf ) dt[bdf] = (struct amd_iommu_dte){ .v = true, - .iv = true, + .iv = iommu_intremap, }; } -- 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs 2019-11-26 17:08 [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs Igor Druzhinin @ 2019-11-26 17:14 ` Andrew Cooper 2019-11-27 4:24 ` Jürgen Groß 1 sibling, 0 replies; 3+ messages in thread From: Andrew Cooper @ 2019-11-26 17:14 UTC (permalink / raw) To: Igor Druzhinin, xen-devel; +Cc: jgross, jbeulich On 26/11/2019 17:08, Igor Druzhinin wrote: > IV bit shouldn't be set in DTE if interrupt remapping is not > enabled. It's a regression in behavior of "iommu=no-intremap" > option which otherwise would keep interrupt requests untranslated > for all of the devices in the system regardless of wether it's > described as valid in IVRS or not. > > Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> Juergen: 4.13 justification - this is a regression from 4.12. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs 2019-11-26 17:08 [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs Igor Druzhinin 2019-11-26 17:14 ` Andrew Cooper @ 2019-11-27 4:24 ` Jürgen Groß 1 sibling, 0 replies; 3+ messages in thread From: Jürgen Groß @ 2019-11-27 4:24 UTC (permalink / raw) To: Igor Druzhinin, xen-devel; +Cc: andrew.cooper3, jbeulich On 26.11.19 18:08, Igor Druzhinin wrote: > IV bit shouldn't be set in DTE if interrupt remapping is not > enabled. It's a regression in behavior of "iommu=no-intremap" > option which otherwise would keep interrupt requests untranslated > for all of the devices in the system regardless of wether it's > described as valid in IVRS or not. > > Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> Release-acked-by: Juergen Gross <jgross@suse.com> Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-27 4:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-26 17:08 [Xen-devel] [PATCH for-4.13 v2] AMD/IOMMU: honour IR setting while pre-filling DTEs Igor Druzhinin 2019-11-26 17:14 ` Andrew Cooper 2019-11-27 4:24 ` Jürgen Groß
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.