All of lore.kernel.org
 help / color / mirror / Atom feed
From: kajoljain <kjain@linux.ibm.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com,
	trix@redhat.com, yilun.xu@intel.com, linux-fpga@vger.kernel.org,
	maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
Date: Mon, 2 Aug 2021 17:16:42 +0530	[thread overview]
Message-ID: <0d31afc5-b86e-4da6-878c-be4ba7b4a23a@linux.ibm.com> (raw)
In-Reply-To: <YQezqZcOrePV/FnW@archbook>



On 8/2/21 2:28 PM, Moritz Fischer wrote:
> On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote:
>>
>>
>> On 7/13/21 1:12 PM, Kajol Jain wrote:
>>> The performance reporting driver added cpu hotplug
>>> feature but it didn't add pmu migration call in cpu
>>> offline function.
>>> This can create an issue incase the current designated
>>> cpu being used to collect fme pmu data got offline,
>>> as based on current code we are not migrating fme pmu to
>>> new target cpu. Because of that perf will still try to
>>> fetch data from that offline cpu and hence we will not
>>> get counter data.
>>>
>>> Patch fixed this issue by adding pmu_migrate_context call
>>> in fme_perf_offline_cpu function.
>>>
>>> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
>>> Tested-by: Xu Yilun <yilun.xu@intel.com>
>>> Acked-by: Wu Hao <hao.wu@intel.com>
>>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>
>> Any update on this patch? Please let me know if any changes required.
>>
>> Thanks,
>> Kajol Jain
> 
> It's in my 'fixes' branch.

Thanks Moritz for informing me.

Thanks,
Kajol Jain

> 
> - Moritz
> 

WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: mark.rutland@arm.com, maddy@linux.ibm.com,
	rnsastry@linux.ibm.com, trix@redhat.com,
	linux-fpga@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	linux-perf-users@vger.kernel.org, atrajeev@linux.vnet.ibm.com,
	will@kernel.org, yilun.xu@intel.com, hao.wu@intel.com
Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
Date: Mon, 2 Aug 2021 17:16:42 +0530	[thread overview]
Message-ID: <0d31afc5-b86e-4da6-878c-be4ba7b4a23a@linux.ibm.com> (raw)
In-Reply-To: <YQezqZcOrePV/FnW@archbook>



On 8/2/21 2:28 PM, Moritz Fischer wrote:
> On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote:
>>
>>
>> On 7/13/21 1:12 PM, Kajol Jain wrote:
>>> The performance reporting driver added cpu hotplug
>>> feature but it didn't add pmu migration call in cpu
>>> offline function.
>>> This can create an issue incase the current designated
>>> cpu being used to collect fme pmu data got offline,
>>> as based on current code we are not migrating fme pmu to
>>> new target cpu. Because of that perf will still try to
>>> fetch data from that offline cpu and hence we will not
>>> get counter data.
>>>
>>> Patch fixed this issue by adding pmu_migrate_context call
>>> in fme_perf_offline_cpu function.
>>>
>>> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
>>> Tested-by: Xu Yilun <yilun.xu@intel.com>
>>> Acked-by: Wu Hao <hao.wu@intel.com>
>>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>>> Cc: stable@vger.kernel.org
>>> ---
>>
>> Any update on this patch? Please let me know if any changes required.
>>
>> Thanks,
>> Kajol Jain
> 
> It's in my 'fixes' branch.

Thanks Moritz for informing me.

Thanks,
Kajol Jain

> 
> - Moritz
> 

  reply	other threads:[~2021-08-02 11:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  7:42 [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Kajol Jain
2021-07-13  7:42 ` Kajol Jain
2021-08-02  7:45 ` kajoljain
2021-08-02  7:45   ` kajoljain
2021-08-02  8:58   ` Moritz Fischer
2021-08-02  8:58     ` Moritz Fischer
2021-08-02 11:46     ` kajoljain [this message]
2021-08-02 11:46       ` kajoljain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d31afc5-b86e-4da6-878c-be4ba7b4a23a@linux.ibm.com \
    --to=kjain@linux.ibm.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mark.rutland@arm.com \
    --cc=mdf@kernel.org \
    --cc=rnsastry@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=trix@redhat.com \
    --cc=will@kernel.org \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.