PATCH for bmaptool examples

PATCH for bmaptool examples

[tepperson]

[-- Attachment #1.1: Type: text/plain, Size: 100 bytes --]

This patch updates one of the examples for calling bmaptool to the newer bmaptools-native command.

[-- Attachment #1.2: Type: text/html, Size: 100 bytes --]

[-- Attachment #2: yocto_dev_patch.patch --]
[-- Type: application/octet-stream, Size: 950 bytes --]

From 8406d7c8e1d812db3822ac30877537f50e8b352d Mon Sep 17 00:00:00 2001
From: Thomas Epperson <tepperson@briskheat.com>
Date: Fri, 20 May 2022 11:28:15 -0400
Subject: [PATCH] Update documentation for bmaptool usage

---
 documentation/dev-manual/common-tasks.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
index b228c75aa..b196c2651 100644
--- a/documentation/dev-manual/common-tasks.rst
+++ b/documentation/dev-manual/common-tasks.rst
@@ -5880,7 +5880,7 @@ Directory onto a USB stick, or whatever media for which you built your
 image, and boot from the media. You can write the image by using
 ``bmaptool`` or ``dd``::
 
-   $ oe-run-native bmaptool copy mkefidisk-201804191017-sda.direct /dev/sdX
+   $ oe-run-native bmaptools-native bmaptool copy mkefidisk-201804191017-sda.direct /dev/sdX
 
 or ::
 
-- 
2.34.1

Re: [docs] PATCH for bmaptool examples

[Michael Opdenacker]

Hi Thomas,

Thank you for your contribution!

On 5/20/22 17:34, tepperson@briskheat.com wrote:
> This patch updates one of the examples for calling bmaptool to the
> newer bmaptools-native command.

Good catch!

It would actually be better if you send the patch through git
send-email. This makes it easier to review patches because we can reply
to specific lines in our e-mail client.

I believe there's a typo in your patch though. You should replace
"oe-run-native bmaptools-native bmaptool" by "oe-run-native
bmap-tools-native bmaptool".

Another thing, we needed your "Signed-off-by" on your patch. You get it
by adding "-s" to git commit.

Thanks in advance for the new submission.
Cheers,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs] PATCH for bmaptool examples

[Michael Opdenacker]

Hi Thomas,

On 5/20/22 18:23, Thomas Epperson wrote:
> It looks like I don't have git send-email on my system. Yes, I made a typo in my patch, I have corrected it.
>
> From b6bf34d26e49ef637d73085e5fde27bbbefc2ee4 Mon Sep 17 00:00:00 2001
> From: Thomas Epperson <tepperson@briskheat.com>
> Date: Fri, 20 May 2022 11:28:15 -0400
> Subject: [PATCH] Update documentation for bmaptool usage
>
> Signed-off-by: Thomas Epperson <tepperson@briskheat.com>
> ---
>  documentation/dev-manual/common-tasks.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index b228c75aa..04df750ef 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -5880,7 +5880,7 @@ Directory onto a USB stick, or whatever media for which you built your
>  image, and boot from the media. You can write the image by using
>  ``bmaptool`` or ``dd``::
>  
> -   $ oe-run-native bmaptool copy mkefidisk-201804191017-sda.direct /dev/sdX
> +   $ oe-run-native bmap-tools-native bmaptool copy mkefidisk-201804191017-sda.direct /dev/sdX
>  
>  or ::
>  


Thanks for the update. I just slightly modified the patch summary and
merged it into the "master-next" branch.

Thanks again!
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com