[PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Robert P. J. Day]

Variable DEPLOY_DIR_TOOLS was introduced in 2007:

  commit f751a20152c651a33f08ceda0502fa1d4f11c005
  Author: Richard Purdie <richard@openedhand.com>
  Date:   Wed Aug 8 21:02:39 2007 +0000

      bitbake.conf: Sync with OE.dev

apparently never used so get rid of it.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  if there's any actual use of this variable, i can't find it.

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index f7700f1191..9336c244bc 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -410,7 +410,6 @@ DEPLOY_DIR_IPK = "${DEPLOY_DIR}/ipk"
 DEPLOY_DIR_RPM = "${DEPLOY_DIR}/rpm"
 DEPLOY_DIR_DEB = "${DEPLOY_DIR}/deb"
 DEPLOY_DIR_IMAGE ?= "${DEPLOY_DIR}/images/${MACHINE}"
-DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"

 PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}"


-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Jacob Kroon]

On 5/27/20 4:31 PM, Robert P. J. Day wrote:
> 
> Variable DEPLOY_DIR_TOOLS was introduced in 2007:
> 
>    commit f751a20152c651a33f08ceda0502fa1d4f11c005
>    Author: Richard Purdie <richard@openedhand.com>
>    Date:   Wed Aug 8 21:02:39 2007 +0000
> 
>        bitbake.conf: Sync with OE.dev
> 
> apparently never used so get rid of it.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 

meta-openembedded/meta-oe/recipes-support/dfu-util/dfu-util-native_0.9.bb:do_deploy[sstate-outputdirs] 
= "${DEPLOY_DIR_TOOLS}"

✗ patchtest: failure for remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Patchwork]

== Series Details ==

Series: remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf
Revision: 1
URL   : https://patchwork.openembedded.org/series/24343/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Khem Raj]

On Wed, May 27, 2020 at 7:36 AM Jacob Kroon <jacob.kroon@gmail.com> wrote:
>
> On 5/27/20 4:31 PM, Robert P. J. Day wrote:
> >
> > Variable DEPLOY_DIR_TOOLS was introduced in 2007:
> >
> >    commit f751a20152c651a33f08ceda0502fa1d4f11c005
> >    Author: Richard Purdie <richard@openedhand.com>
> >    Date:   Wed Aug 8 21:02:39 2007 +0000
> >
> >        bitbake.conf: Sync with OE.dev
> >
> > apparently never used so get rid of it.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
>
> meta-openembedded/meta-oe/recipes-support/dfu-util/dfu-util-native_0.9.bb:do_deploy[sstate-outputdirs]
> = "${DEPLOY_DIR_TOOLS}"
> 

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Enrico J?rns]

Hi,

Am Donnerstag, den 28.05.2020, 19:02 -0700 schrieb Khem Raj:
> On Wed, May 27, 2020 at 7:36 AM Jacob Kroon <jacob.kroon@gmail.com>
> wrote:
> > On 5/27/20 4:31 PM, Robert P. J. Day wrote:
> > > Variable DEPLOY_DIR_TOOLS was introduced in 2007:
> > > 
> > >    commit f751a20152c651a33f08ceda0502fa1d4f11c005
> > >    Author: Richard Purdie <richard@openedhand.com>
> > >    Date:   Wed Aug 8 21:02:39 2007 +0000
> > > 
> > >        bitbake.conf: Sync with OE.dev
> > > 
> > > apparently never used so get rid of it.
> > > 
> > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > > 
> > 
> > meta-openembedded/meta-oe/recipes-support/dfu-util/dfu-util-
> > native_0.9.bb:do_deploy[sstate-outputdirs]
> > = "${DEPLOY_DIR_TOOLS}"

this was removed now in meta-oe commit
af3fc04cfb64d9f229be26f47b4dec892ff919dc ("dfu-util-native: Remove
DEPLOY_DIR_TOOLS from sstate-outputdirs") apparantely.

However, I do not get the argumentation for that:

>    In commit 1ef92d2423d6d6546e4f0585478540212b26f3a0 deploying the native
>    tool was changed to use DEPLOYDIR, so setting DEPLOY_DIR_TOOLS for sstate-outputdir
>    dependency should have been changed as well.

Setting do_deploy[sstate-outputdirs] to something different than its default appears to be valid for me and has nothing to do with DEPLOYDIR, which is only the sstate intermediate directory name.
And the result of this is, that the tool now lands in DEPLOY_DIR_IMAGE instead.


My motivation of questioning is, that we have in our RAUC recipe a similar usage:

https://github.com/rauc/meta-rauc/blob/master/recipes-core/rauc/rauc-native_1.3.bb#L5

The idea behind that was that one might give some convenience to use the tool manually to manipulate update bundles, re-sign them, obtain meta information, etc.

What is the now suggested way of placing these kind of binaries? Simply in DEPLOY_DIR_IMAGES as the above-mentioned commit does (silently)?
Or is there maybe still some motivation to keep DEPLOY_DIR_TOOLS?


Thanks and best regards

Enrico

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Embedded Linux Consulting & Support        | https://www.pengutronix.de/
 |
Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Khem Raj]

On Mon, Jun 8, 2020 at 1:15 PM Enrico Jörns <ejo@pengutronix.de> wrote:
>
> Hi,
>
> Am Donnerstag, den 28.05.2020, 19:02 -0700 schrieb Khem Raj:
> > On Wed, May 27, 2020 at 7:36 AM Jacob Kroon <jacob.kroon@gmail.com>
> > wrote:
> > > On 5/27/20 4:31 PM, Robert P. J. Day wrote:
> > > > Variable DEPLOY_DIR_TOOLS was introduced in 2007:
> > > >
> > > >    commit f751a20152c651a33f08ceda0502fa1d4f11c005
> > > >    Author: Richard Purdie <richard@openedhand.com>
> > > >    Date:   Wed Aug 8 21:02:39 2007 +0000
> > > >
> > > >        bitbake.conf: Sync with OE.dev
> > > >
> > > > apparently never used so get rid of it.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > > >
> > >
> > > meta-openembedded/meta-oe/recipes-support/dfu-util/dfu-util-
> > > native_0.9.bb:do_deploy[sstate-outputdirs]
> > > = "${DEPLOY_DIR_TOOLS}"
>
> this was removed now in meta-oe commit
> af3fc04cfb64d9f229be26f47b4dec892ff919dc ("dfu-util-native: Remove
> DEPLOY_DIR_TOOLS from sstate-outputdirs") apparantely.
>
> However, I do not get the argumentation for that:
>
> >    In commit 1ef92d2423d6d6546e4f0585478540212b26f3a0 deploying the native
> >    tool was changed to use DEPLOYDIR, so setting DEPLOY_DIR_TOOLS for sstate-outputdir
> >    dependency should have been changed as well.
>
> Setting do_deploy[sstate-outputdirs] to something different than its default appears to be valid for me and has nothing to do with DEPLOYDIR, which is only the sstate intermediate directory name.
> And the result of this is, that the tool now lands in DEPLOY_DIR_IMAGE instead.
>
>
> My motivation of questioning is, that we have in our RAUC recipe a similar usage:
>
> https://github.com/rauc/meta-rauc/blob/master/recipes-core/rauc/rauc-native_1.3.bb#L5
>
> The idea behind that was that one might give some convenience to use the tool manually to manipulate update bundles, re-sign them, obtain meta information, etc.
>
> What is the now suggested way of placing these kind of binaries? Simply in DEPLOY_DIR_IMAGES as the above-mentioned commit does (silently)?
> Or is there maybe still some motivation to keep DEPLOY_DIR_TOOLS?
>

Just use DEPLOY_DIR_IMAGES

>
> Thanks and best regards
>
> Enrico
>
> --
> Pengutronix e.K.                           | Enrico Jörns                |
> Embedded Linux Consulting & Support        | https://www.pengutronix.de/
>  |
> Steuerwalder Str. 21                       | Phone: +49-5121-206917-180  |
> 31137 Hildesheim, Germany                  | Fax:   +49-5121-206917-9    |
>

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Ross Burton]

On Mon, 8 Jun 2020 at 21:15, Enrico J?rns <ejo@pengutronix.de> wrote:

> What is the now suggested way of placing these kind of binaries? Simply in DEPLOY_DIR_IMAGES as the above-mentioned commit does (silently)?
> Or is there maybe still some motivation to keep DEPLOY_DIR_TOOLS?

FWIW, meta-arm is also using DEPLOY_DIR_TOOLS and to fix builds with
master is now manually using DEPLOY_DIR/tools because having a
separate directory does help introduce some structure.

Basically, I'd actually like to see this reverted.

Ross

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Richard Purdie]

On Tue, 2020-06-09 at 14:33 +0100, Ross Burton wrote:
> On Mon, 8 Jun 2020 at 21:15, Enrico J?rns <ejo@pengutronix.de> wrote:
> 
> > What is the now suggested way of placing these kind of binaries?
> > Simply in DEPLOY_DIR_IMAGES as the above-mentioned commit does
> > (silently)?
> > Or is there maybe still some motivation to keep DEPLOY_DIR_TOOLS?
> 
> FWIW, meta-arm is also using DEPLOY_DIR_TOOLS and to fix builds with
> master is now manually using DEPLOY_DIR/tools because having a
> separate directory does help introduce some structure.
> 
> Basically, I'd actually like to see this reverted.

I'm tempted to agree. It was only merged on the basis that it was
unused which isn't true.

Cheers,

Richard

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Robert P. J. Day]

On Tue, 9 Jun 2020, Richard Purdie wrote:

> On Tue, 2020-06-09 at 14:33 +0100, Ross Burton wrote:
> > On Mon, 8 Jun 2020 at 21:15, Enrico J?rns <ejo@pengutronix.de> wrote:
> >
> > > What is the now suggested way of placing these kind of binaries?
> > > Simply in DEPLOY_DIR_IMAGES as the above-mentioned commit does
> > > (silently)?
> > > Or is there maybe still some motivation to keep DEPLOY_DIR_TOOLS?
> >
> > FWIW, meta-arm is also using DEPLOY_DIR_TOOLS and to fix builds with
> > master is now manually using DEPLOY_DIR/tools because having a
> > separate directory does help introduce some structure.
> >
> > Basically, I'd actually like to see this reverted.
>
> I'm tempted to agree. It was only merged on the basis that it was
> unused which isn't true.

  in my defense, i almost immediately admitted i hadn't noticed it in
meta-openembedded.

rday

Re: [OE-core] [PATCH] remove unused DEPLOY_DIR_TOOLS variable from bitbake.conf

[Robert P. J. Day]

On Wed, 27 May 2020, Robert P. J. Day wrote:

>
> Variable DEPLOY_DIR_TOOLS was introduced in 2007:
>
>   commit f751a20152c651a33f08ceda0502fa1d4f11c005
>   Author: Richard Purdie <richard@openedhand.com>
>   Date:   Wed Aug 8 21:02:39 2007 +0000
>
>       bitbake.conf: Sync with OE.dev
>

  never mind, failed to look in meta-openembedded layer, my bad.

rday