From: Jan Kiszka <jan.kiszka@web.de> To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com> Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org Subject: [PATCH 12/18] kvm: Move irqchip event processing out of inner loop Date: Mon, 10 Jan 2011 09:32:05 +0100 [thread overview] Message-ID: <0d68d0b6f32d1333ed7d1abe831d824da1e8f9d5.1294648329.git.jan.kiszka@web.de> (raw) In-Reply-To: <cover.1294648329.git.jan.kiszka@web.de> In-Reply-To: <cover.1294648329.git.jan.kiszka@web.de> From: Jan Kiszka <jan.kiszka@siemens.com> Align with qemu-kvm and prepare for IO exit fix: There is no need to run kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change this service processes will first cause an exit from kvm_cpu_exec anyway. And we will have to reenter the kernel on IO exits unconditionally, something that the current logic prevents. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- kvm-all.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index a8e9f2c..f3c8375 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -824,6 +824,12 @@ int kvm_cpu_exec(CPUState *env) DPRINTF("kvm_cpu_exec()\n"); + if (kvm_arch_process_irqchip_events(env)) { + env->exit_request = 0; + env->exception_index = EXCP_HLT; + return 0; + } + do { #ifndef CONFIG_IOTHREAD if (env->exit_request) { @@ -833,11 +839,6 @@ int kvm_cpu_exec(CPUState *env) } #endif - if (kvm_arch_process_irqchip_events(env)) { - ret = 0; - break; - } - if (env->kvm_vcpu_dirty) { kvm_arch_put_registers(env, KVM_PUT_RUNTIME_STATE); env->kvm_vcpu_dirty = 0; -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de> To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com> Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH 12/18] kvm: Move irqchip event processing out of inner loop Date: Mon, 10 Jan 2011 09:32:05 +0100 [thread overview] Message-ID: <0d68d0b6f32d1333ed7d1abe831d824da1e8f9d5.1294648329.git.jan.kiszka@web.de> (raw) In-Reply-To: <cover.1294648329.git.jan.kiszka@web.de> In-Reply-To: <cover.1294648329.git.jan.kiszka@web.de> From: Jan Kiszka <jan.kiszka@siemens.com> Align with qemu-kvm and prepare for IO exit fix: There is no need to run kvm_arch_process_irqchip_events in the inner VCPU loop. Any state change this service processes will first cause an exit from kvm_cpu_exec anyway. And we will have to reenter the kernel on IO exits unconditionally, something that the current logic prevents. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- kvm-all.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index a8e9f2c..f3c8375 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -824,6 +824,12 @@ int kvm_cpu_exec(CPUState *env) DPRINTF("kvm_cpu_exec()\n"); + if (kvm_arch_process_irqchip_events(env)) { + env->exit_request = 0; + env->exception_index = EXCP_HLT; + return 0; + } + do { #ifndef CONFIG_IOTHREAD if (env->exit_request) { @@ -833,11 +839,6 @@ int kvm_cpu_exec(CPUState *env) } #endif - if (kvm_arch_process_irqchip_events(env)) { - ret = 0; - break; - } - if (env->kvm_vcpu_dirty) { kvm_arch_put_registers(env, KVM_PUT_RUNTIME_STATE); env->kvm_vcpu_dirty = 0; -- 1.7.1
next prev parent reply other threads:[~2011-01-10 8:33 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-10 8:31 [PATCH 00/18] [uq/master] MCE & IO exit fixes, prepare for VCPU loop reuse Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 01/18] Revert "kvm: Drop return value of kvm_cpu_exec" Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 02/18] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 03/18] kvm: Provide sigbus services arch-independently Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 10:13 ` Paolo Bonzini 2011-01-10 10:13 ` [Qemu-devel] " Paolo Bonzini 2011-01-10 10:30 ` Jan Kiszka 2011-01-10 10:30 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 04/18] Refactor signal setup functions in cpus.c Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 05/18] kvm: Set up signal mask also for !CONFIG_IOTHREAD Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:31 ` [PATCH 06/18] kvm: Refactor qemu_kvm_eat_signals Jan Kiszka 2011-01-10 8:31 ` [Qemu-devel] " Jan Kiszka 2011-01-10 10:15 ` Paolo Bonzini 2011-01-10 10:15 ` [Qemu-devel] " Paolo Bonzini 2011-01-10 8:32 ` [PATCH 07/18] kvm: Add MCE signal support for !CONFIG_IOTHREAD Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-24 11:17 ` Marcelo Tosatti 2011-01-24 11:17 ` [Qemu-devel] " Marcelo Tosatti 2011-01-24 12:36 ` Jan Kiszka 2011-01-24 12:36 ` [Qemu-devel] " Jan Kiszka 2011-01-26 8:09 ` Jan Kiszka 2011-01-26 8:09 ` [Qemu-devel] " Jan Kiszka 2011-01-26 12:01 ` Marcelo Tosatti 2011-01-26 12:01 ` [Qemu-devel] " Marcelo Tosatti 2011-01-26 12:06 ` Jan Kiszka 2011-01-26 12:06 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 08/18] kvm: Handle kvm_init_vcpu errors Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 09/18] Refactor kvm&tcg function names in cpus.c Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 10/18] Fix a few coding style violations " Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 11/18] Introduce VCPU self-signaling service Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-24 11:47 ` Marcelo Tosatti 2011-01-24 11:47 ` [Qemu-devel] " Marcelo Tosatti 2011-01-24 12:36 ` Jan Kiszka 2011-01-24 12:36 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` Jan Kiszka [this message] 2011-01-10 8:32 ` [Qemu-devel] [PATCH 12/18] kvm: Move irqchip event processing out of inner loop Jan Kiszka 2011-01-10 8:32 ` [PATCH 13/18] kvm: Unconditionally reenter kernel after IO exits Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 14/18] kvm: Remove static return code of kvm_handle_io Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 15/18] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 16/18] kvm: Separate TCG from KVM cpu execution Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 17/18] kvm: x86: Prepare VCPU loop for in-kernel irqchip Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 8:32 ` [PATCH 18/18] kvm: Drop return values from kvm_arch_pre/post_run Jan Kiszka 2011-01-10 8:32 ` [Qemu-devel] " Jan Kiszka 2011-01-10 10:10 ` [PATCH 00/18] [uq/master] MCE & IO exit fixes, prepare for VCPU loop reuse Jan Kiszka 2011-01-10 10:10 ` [Qemu-devel] " Jan Kiszka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0d68d0b6f32d1333ed7d1abe831d824da1e8f9d5.1294648329.git.jan.kiszka@web.de \ --to=jan.kiszka@web.de \ --cc=avi@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.