* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-16 20:28 [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project Alexander Schulz - XCP-ng Project Member
@ 2018-10-17 8:00 ` Paul Durrant
2018-10-17 15:14 ` Ian Jackson
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Paul Durrant @ 2018-10-17 8:00 UTC (permalink / raw)
To: 'Alexander Schulz - XCP-ng Project Member', xen-devel
Cc: Ian Jackson, Wei Liu
> -----Original Message-----
> From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On Behalf
> Of Alexander Schulz - XCP-ng Project Member
> Sent: 16 October 2018 21:28
> To: xen-devel@lists.xenproject.org
> Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>;
> code@schulzalex.de
> Subject: [Xen-devel] [PATCH] Reservation of PCI device range 0xc200-0xc2ff
> to XCP-ng Project
>
> We are the XCP-ng project (https://xcp-ng.org) and want to distribute
> our own PV-Tools (maybe also per windows updates) so we need an extra
> range.
>
> We also registered a PCI-Device:
>
> "XCP-ng Project PCI Device for Windows Update" ->
> https://pci-ids.ucw.cz/read/PC/5853/c200
>
> Signed-off-by: Alexander Schulz <code@schulzalex.de>
LGTM.
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> docs/man/xen-pci-device-reservations.pod.7 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/man/xen-pci-device-reservations.pod.7
> b/docs/man/xen-pci-device-reservations.pod.7
> index 049e47410f..1cd5a3e115 100644
> --- a/docs/man/xen-pci-device-reservations.pod.7
> +++ b/docs/man/xen-pci-device-reservations.pod.7
> @@ -41,6 +41,7 @@ multiple Xen vendors using conflicting IDs.
> 0x0002 | Citrix XenServer (grandfathered allocation for
> XenServer 6.1)
> 0xc000-0xc0ff | Citrix XenServer
> 0xc100-0xc1ff | Citrix XenClient
> + 0xc200-0xc2ff | XCP-ng Project (https://xcp-ng.org)
> =head1 Notes
> -- 2.17.1.windows.2
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-16 20:28 [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project Alexander Schulz - XCP-ng Project Member
2018-10-17 8:00 ` Paul Durrant
@ 2018-10-17 15:14 ` Ian Jackson
2018-10-17 15:39 ` code
2018-10-17 15:49 ` Wei Liu
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Ian Jackson @ 2018-10-17 15:14 UTC (permalink / raw)
To: Alexander Schulz - XCP-ng Project Member; +Cc: xen-devel, Wei Liu
Alexander Schulz - XCP-ng Project Member writes ("[PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project"):
> We are the XCP-ng project (https://xcp-ng.org) and want to distribute
> our own PV-Tools (maybe also per windows updates) so we need an extra range.
Thanks. I acked your previous message which was sent by private
email; I think you could have transferred my ack to this repost.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
I just wanted to say that it is a very good thing to come here and
reserve a number. We should assign numbers without too much
quibbling, which is why I have given a summary ack.
IMO this should be committed soon.
> We also registered a PCI-Device:
>
> "XCP-ng Project PCI Device for Windows Update" ->
> https://pci-ids.ucw.cz/read/PC/5853/c200
You've got your own PCI device *and* a range in the Xen Platform PCI
Device ? I confess I don't know why that is necessary. Perhaps it is
more obvious to those who understand this all better than I do.
Regards,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-17 15:14 ` Ian Jackson
@ 2018-10-17 15:39 ` code
0 siblings, 0 replies; 8+ messages in thread
From: code @ 2018-10-17 15:39 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Wei Liu
Am 17.10.2018 um 17:14 schrieb Ian Jackson:
> Alexander Schulz - XCP-ng Project Member writes ("[PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project"):
>> We are the XCP-ng project (https://xcp-ng.org) and want to distribute
>> our own PV-Tools (maybe also per windows updates) so we need an extra range.
> Thanks. I acked your previous message which was sent by private
> email; I think you could have transferred my ack to this repost.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> I just wanted to say that it is a very good thing to come here and
> reserve a number. We should assign numbers without too much
> quibbling, which is why I have given a summary ack.
>
> IMO this should be committed soon.
>
>> We also registered a PCI-Device:
>>
>> "XCP-ng Project PCI Device for Windows Update" ->
>> https://pci-ids.ucw.cz/read/PC/5853/c200
> You've got your own PCI device *and* a range in the Xen Platform PCI
> Device ? I confess I don't know why that is necessary. Perhaps it is
> more obvious to those who understand this all better than I do.
It was recommended by Paul Durrant:
https://lists.xenproject.org/archives/html/win-pv-devel/2018-10/msg00005.html
"I think it would probably be better if you took a range. It's not in
writing but I think other things have played with those low numbered
device ids in the past so probably best to avoid them. Would you be ok
with the next range of 0x100 above XenClient, i.e. 0xc200-0xc2ff? ...."
> Regards,
> Ian.
Alexander Schulz
XCP-ng Project Member
Maintainer of: XCP-ng Center and XCP-ng PV-Tools
XCP-ng Project
--------------
web: https://xcp-ng.org
Github: https://github.com/xcp-ng
IRC: #xcp-ng on Freenode
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-16 20:28 [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project Alexander Schulz - XCP-ng Project Member
2018-10-17 8:00 ` Paul Durrant
2018-10-17 15:14 ` Ian Jackson
@ 2018-10-17 15:49 ` Wei Liu
2018-10-17 16:15 ` Ian Jackson
2018-10-17 16:33 ` Wei Liu
4 siblings, 0 replies; 8+ messages in thread
From: Wei Liu @ 2018-10-17 15:49 UTC (permalink / raw)
To: Alexander Schulz - XCP-ng Project Member; +Cc: xen-devel, Ian Jackson, Wei Liu
On Tue, Oct 16, 2018 at 10:28:04PM +0200, Alexander Schulz - XCP-ng Project Member wrote:
> We are the XCP-ng project (https://xcp-ng.org) and want to distribute our
> own PV-Tools (maybe also per windows updates) so we need an extra range.
>
> We also registered a PCI-Device:
>
> "XCP-ng Project PCI Device for Windows Update" ->
> https://pci-ids.ucw.cz/read/PC/5853/c200
>
> Signed-off-by: Alexander Schulz <code@schulzalex.de>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-16 20:28 [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project Alexander Schulz - XCP-ng Project Member
` (2 preceding siblings ...)
2018-10-17 15:49 ` Wei Liu
@ 2018-10-17 16:15 ` Ian Jackson
2018-10-17 16:33 ` Wei Liu
4 siblings, 0 replies; 8+ messages in thread
From: Ian Jackson @ 2018-10-17 16:15 UTC (permalink / raw)
To: Alexander Schulz - XCP-ng Project Member; +Cc: xen-devel, Wei Liu
Alexander Schulz - XCP-ng Project Member writes ("[PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project"):
> We are the XCP-ng project (https://xcp-ng.org) and want to distribute
> our own PV-Tools (maybe also per windows updates) so we need an extra range.
>
> We also registered a PCI-Device:
>
> "XCP-ng Project PCI Device for Windows Update" ->
> https://pci-ids.ucw.cz/read/PC/5853/c200
>
> Signed-off-by: Alexander Schulz <code@schulzalex.de>
I tried to apply this but
gmariner:xen.git> git-am ~/News/x
Applying: Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
error: corrupt patch at line 13
Patch failed at 0001 Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
mariner:xen.git>
That's on the copy I got via my colo and its mail-to-news gateway, so
not mangled by the Citrix corporate email system.
If you prefer you can publish a git branch...
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-16 20:28 [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project Alexander Schulz - XCP-ng Project Member
` (3 preceding siblings ...)
2018-10-17 16:15 ` Ian Jackson
@ 2018-10-17 16:33 ` Wei Liu
2018-10-17 16:36 ` code
4 siblings, 1 reply; 8+ messages in thread
From: Wei Liu @ 2018-10-17 16:33 UTC (permalink / raw)
To: Alexander Schulz - XCP-ng Project Member; +Cc: xen-devel, Ian Jackson, Wei Liu
On Tue, Oct 16, 2018 at 10:28:04PM +0200, Alexander Schulz - XCP-ng Project Member wrote:
> We are the XCP-ng project (https://xcp-ng.org) and want to distribute our
> own PV-Tools (maybe also per windows updates) so we need an extra range.
>
> We also registered a PCI-Device:
>
> "XCP-ng Project PCI Device for Windows Update" ->
> https://pci-ids.ucw.cz/read/PC/5853/c200
>
> Signed-off-by: Alexander Schulz <code@schulzalex.de>
I think your email client / server has mangled this patch badly. As Ian
observed, it wouldn't apply.
Anyway, in the interest of avoiding another round of posting, I have
fixed up the patch and commit it for you.
Wei.
> ---
> docs/man/xen-pci-device-reservations.pod.7 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/man/xen-pci-device-reservations.pod.7
> b/docs/man/xen-pci-device-reservations.pod.7
> index 049e47410f..1cd5a3e115 100644
> --- a/docs/man/xen-pci-device-reservations.pod.7
> +++ b/docs/man/xen-pci-device-reservations.pod.7
> @@ -41,6 +41,7 @@ multiple Xen vendors using conflicting IDs.
> 0x0002 | Citrix XenServer (grandfathered allocation for
> XenServer 6.1)
> 0xc000-0xc0ff | Citrix XenServer
> 0xc100-0xc1ff | Citrix XenClient
> + 0xc200-0xc2ff | XCP-ng Project (https://xcp-ng.org)
> =head1 Notes
> -- 2.17.1.windows.2
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Reservation of PCI device range 0xc200-0xc2ff to XCP-ng Project
2018-10-17 16:33 ` Wei Liu
@ 2018-10-17 16:36 ` code
0 siblings, 0 replies; 8+ messages in thread
From: code @ 2018-10-17 16:36 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Ian Jackson
[-- Attachment #1.1: Type: text/plain, Size: 1531 bytes --]
Thanks for all your support!
Alex
Am 17. Oktober 2018 18:33:45 MESZ schrieb Wei Liu <wei.liu2@citrix.com>:
>On Tue, Oct 16, 2018 at 10:28:04PM +0200, Alexander Schulz - XCP-ng
>Project Member wrote:
>> We are the XCP-ng project (https://xcp-ng.org) and want to distribute
>our
>> own PV-Tools (maybe also per windows updates) so we need an extra
>range.
>>
>> We also registered a PCI-Device:
>>
>> "XCP-ng Project PCI Device for Windows Update" ->
>> https://pci-ids.ucw.cz/read/PC/5853/c200
>>
>> Signed-off-by: Alexander Schulz <code@schulzalex.de>
>
>I think your email client / server has mangled this patch badly. As Ian
>observed, it wouldn't apply.
>
>Anyway, in the interest of avoiding another round of posting, I have
>fixed up the patch and commit it for you.
>
>Wei.
>
>> ---
>> docs/man/xen-pci-device-reservations.pod.7 | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/docs/man/xen-pci-device-reservations.pod.7
>> b/docs/man/xen-pci-device-reservations.pod.7
>> index 049e47410f..1cd5a3e115 100644
>> --- a/docs/man/xen-pci-device-reservations.pod.7
>> +++ b/docs/man/xen-pci-device-reservations.pod.7
>> @@ -41,6 +41,7 @@ multiple Xen vendors using conflicting IDs.
>> 0x0002 | Citrix XenServer (grandfathered allocation for
>> XenServer 6.1)
>> 0xc000-0xc0ff | Citrix XenServer
>> 0xc100-0xc1ff | Citrix XenClient
>> + 0xc200-0xc2ff | XCP-ng Project (https://xcp-ng.org)
>> =head1 Notes
>> -- 2.17.1.windows.2
>>
>>
[-- Attachment #1.2: Type: text/html, Size: 2150 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread