All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Petri Latvala <petri.latvala@intel.com>,
	Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t 2/3] Remove extra '\0' in strncpy in igt_save_module_param
Date: Tue, 29 May 2018 21:46:55 -0300	[thread overview]
Message-ID: <0d8325c242cc19f74149bfe721e395bf4de951df.1527639529.git.rodrigosiqueiramelo@gmail.com> (raw)
In-Reply-To: <cover.1527639529.git.rodrigosiqueiramelo@gmail.com>

This patch fix the following gcc warning:

warning: ‘strncpy’ specified bound 32 equals destination size
[-Wstringop-truncation]
  strncpy(data->name, name, PARAM_NAME_MAX_SZ);

This error happens due to the '\0' character appended by strncpy. Notice
that reduces by one in the total of bytes to be copied, in this case, is
harmless because the strings received in the parameter already have
'\0'.

Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
 lib/igt_aux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 5dd2761e..06f586d6 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1240,7 +1240,7 @@ static void igt_save_module_param(const char *name, const char *file_path)
 	data = calloc(1, sizeof (*data));
 	igt_assert(data);
 
-	strncpy(data->name, name, PARAM_NAME_MAX_SZ);
+	strncpy(data->name, name, PARAM_NAME_MAX_SZ - 1); // -1 because of '\0'
 
 	fd = open(file_path, O_RDONLY);
 	igt_assert(fd >= 0);
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Petri Latvala <petri.latvala@intel.com>,
	Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org, gustavo@padovan.org,
	intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/3] Remove extra '\0' in strncpy in igt_save_module_param
Date: Tue, 29 May 2018 21:46:55 -0300	[thread overview]
Message-ID: <0d8325c242cc19f74149bfe721e395bf4de951df.1527639529.git.rodrigosiqueiramelo@gmail.com> (raw)
In-Reply-To: <cover.1527639529.git.rodrigosiqueiramelo@gmail.com>

This patch fix the following gcc warning:

warning: ‘strncpy’ specified bound 32 equals destination size
[-Wstringop-truncation]
  strncpy(data->name, name, PARAM_NAME_MAX_SZ);

This error happens due to the '\0' character appended by strncpy. Notice
that reduces by one in the total of bytes to be copied, in this case, is
harmless because the strings received in the parameter already have
'\0'.

Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
 lib/igt_aux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 5dd2761e..06f586d6 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1240,7 +1240,7 @@ static void igt_save_module_param(const char *name, const char *file_path)
 	data = calloc(1, sizeof (*data));
 	igt_assert(data);
 
-	strncpy(data->name, name, PARAM_NAME_MAX_SZ);
+	strncpy(data->name, name, PARAM_NAME_MAX_SZ - 1); // -1 because of '\0'
 
 	fd = open(file_path, O_RDONLY);
 	igt_assert(fd >= 0);
-- 
2.17.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-05-30  0:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  0:46 [PATCH i-g-t 0/3] Fix some GCC warnings Rodrigo Siqueira
2018-05-30  0:46 ` [igt-dev] " Rodrigo Siqueira
2018-05-30  0:46 ` [PATCH i-g-t 1/3] Avoid truncate string in __igt_lsof_fds Rodrigo Siqueira
2018-05-30  0:46   ` [igt-dev] " Rodrigo Siqueira
2018-06-04 10:40   ` Arkadiusz Hiler
2018-06-04 10:40     ` [Intel-gfx] " Arkadiusz Hiler
2018-06-05  1:45     ` Rodrigo Siqueira
2018-06-05  1:45       ` [igt-dev] " Rodrigo Siqueira
2018-05-30  0:46 ` Rodrigo Siqueira [this message]
2018-05-30  0:46   ` [igt-dev] [PATCH i-g-t 2/3] Remove extra '\0' in strncpy in igt_save_module_param Rodrigo Siqueira
2018-06-04 11:04   ` Arkadiusz Hiler
2018-06-04 11:04     ` [Intel-gfx] " Arkadiusz Hiler
2018-05-30  0:47 ` [PATCH i-g-t 3/3] Move declaration to the top of the code Rodrigo Siqueira
2018-05-30  0:47   ` [igt-dev] " Rodrigo Siqueira
2018-06-04 10:54   ` Arkadiusz Hiler
2018-06-04 10:54     ` [igt-dev] " Arkadiusz Hiler
2018-05-30  2:25 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix some GCC warnings Patchwork
2018-05-30  4:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-06-04  8:39 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-06-04  9:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d8325c242cc19f74149bfe721e395bf4de951df.1527639529.git.rodrigosiqueiramelo@gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.