All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Prashant Malani <pmalani@chromium.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: heikki.krogerus@linux.intel.com,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"David Airlie" <airlied@linux.ie>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Tzung-Bi Shih" <tzungbi@google.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	swboyd@chromium.org, "Pin-Yen Lin" <treapking@chromium.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	"Xin Ji" <xji@analogixsemi.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"José Expósito" <jose.exposito89@gmail.com>
Subject: Re: [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding
Date: Wed, 8 Jun 2022 11:21:41 +0200	[thread overview]
Message-ID: <0d891f54-4a81-549b-8365-fb40cd077c83@linaro.org> (raw)
In-Reply-To: <ba499783-1794-1c00-348a-d912c9562e1e@linaro.org>

On 08/06/2022 11:18, Krzysztof Kozlowski wrote:
>> +anyOf:
>> +  - required:
>> +      - mode-switch
>> +  - required:
>> +      - orientation-switch
>> +
>> +additionalProperties: true
> 
> Why true? I see usb-connector has it from commit 6a0e321ea735
> ("dt-bindings: Explicitly allow additional properties in common schemas")
>  but that looks also weird - this is not a common schema, but a
> complete, generic one.
> 

Ah, I see now, the parent device uses the additional properties. It's
ok, skip the comment.


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Prashant Malani <pmalani@chromium.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: bleung@chromium.org, swboyd@chromium.org,
	heikki.krogerus@linux.intel.com,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@linux.ie>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hsin-Yi Wang" <hsinyi@chromium.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"José Expósito" <jose.exposito89@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Pin-Yen Lin" <treapking@chromium.org>,
	"Robert Foss" <robert.foss@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Tzung-Bi Shih" <tzungbi@google.com>,
	"Xin Ji" <xji@analogixsemi.com>
Subject: Re: [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding
Date: Wed, 8 Jun 2022 11:21:41 +0200	[thread overview]
Message-ID: <0d891f54-4a81-549b-8365-fb40cd077c83@linaro.org> (raw)
In-Reply-To: <ba499783-1794-1c00-348a-d912c9562e1e@linaro.org>

On 08/06/2022 11:18, Krzysztof Kozlowski wrote:
>> +anyOf:
>> +  - required:
>> +      - mode-switch
>> +  - required:
>> +      - orientation-switch
>> +
>> +additionalProperties: true
> 
> Why true? I see usb-connector has it from commit 6a0e321ea735
> ("dt-bindings: Explicitly allow additional properties in common schemas")
>  but that looks also weird - this is not a common schema, but a
> complete, generic one.
> 

Ah, I see now, the parent device uses the additional properties. It's
ok, skip the comment.


Best regards,
Krzysztof

  reply	other threads:[~2022-06-08  9:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 19:00 [PATCH 0/7] usb: typec: Introduce typec-switch binding Prashant Malani
2022-06-07 19:00 ` Prashant Malani
2022-06-07 19:00 ` [PATCH 1/7] usb: typec: mux: Allow muxes to specify mode-switch Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-07 19:00 ` [PATCH 2/7] usb: typec: mux: Add CONFIG guards for functions Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-08 20:13   ` Prashant Malani
2022-06-08 20:13     ` Prashant Malani
2022-06-07 19:00 ` [PATCH 3/7] dt-bindings: usb: Add Type-C switch binding Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-08  9:18   ` Krzysztof Kozlowski
2022-06-08  9:18     ` Krzysztof Kozlowski
2022-06-08  9:21     ` Krzysztof Kozlowski [this message]
2022-06-08  9:21       ` Krzysztof Kozlowski
2022-06-08 17:15     ` Prashant Malani
2022-06-08 17:15       ` Prashant Malani
2022-06-09  6:43       ` Krzysztof Kozlowski
2022-06-09  6:43         ` Krzysztof Kozlowski
2022-06-07 19:00 ` [PATCH 4/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-08  9:24   ` Krzysztof Kozlowski
2022-06-08  9:24     ` Krzysztof Kozlowski
2022-06-08 17:08     ` Prashant Malani
2022-06-08 17:08       ` Prashant Malani
2022-06-08 21:56       ` Prashant Malani
2022-06-08 21:56         ` Prashant Malani
2022-06-09  6:41         ` Krzysztof Kozlowski
2022-06-09  6:41           ` Krzysztof Kozlowski
2022-06-09 18:24           ` Prashant Malani
2022-06-09 18:24             ` Prashant Malani
2022-06-07 19:00 ` [PATCH 5/7] drm/bridge: anx7625: Register number of Type C switches Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-07 19:00 ` [PATCH 6/7] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-08 18:14   ` kernel test robot
2022-06-08 18:14     ` kernel test robot
2022-06-08 18:35   ` kernel test robot
2022-06-08 18:35     ` kernel test robot
2022-06-08 22:31   ` kernel test robot
2022-06-08 22:31     ` kernel test robot
2022-06-07 19:00 ` [PATCH 7/7] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani
2022-06-07 19:00   ` Prashant Malani
2022-06-09  0:14   ` kernel test robot
2022-06-09  0:14     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d891f54-4a81-549b-8365-fb40cd077c83@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hsinyi@chromium.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=jose.exposito89@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=narmstrong@baylibre.com \
    --cc=nfraprado@collabora.com \
    --cc=pmalani@chromium.org \
    --cc=robert.foss@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=swboyd@chromium.org \
    --cc=treapking@chromium.org \
    --cc=tzimmermann@suse.de \
    --cc=tzungbi@google.com \
    --cc=xji@analogixsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.