Re: [PATCH v2] agetty: don't put the VC into canonical mode

[Lubomir Rintel <lkundrak@v3.sk>]

On Fri, 2018-10-19 at 15:08 +0200, Stanislav Brabec wrote:
> Dne 19. 10. 18 v 8:09 Lubomir Rintel napsal(a):
> > On Tue, 2018-10-16 at 09:40 +0200, Karel Zak wrote:
> > > On Tue, Oct 16, 2018 at 08:41:49AM +0200, Lubomir Rintel wrote:
> > > > Seems like zero lflags do the job just fine on a Linux VT. Reset it
> > > > to
> > > > canonical mode before running login.
> > > 
> > > What about Del/Backspace keys when user is typing login name? :-)
> > 
> > They seem to work the same as they used to?
> > 
> > From Stanislav's message I notice that there's supposed to be some
> > problem with them -- I'm not seeing that. Either the patch does
> > something different or I'm not looking at the right thing.
> > 
> > (I haven't looked at Stanislav's patch -- but I surely intend to give
> > it a try.)
> I am writing about non-canonical mode.

Yes, so am I.

> It was partially used in past.
> 
> Now agetty uses canonical mode. It handles Backspace by itself, but it
> makes impossible to implement "stop reloads when at least one character
> is entered". So we will have to switch to a non-canonical mode.

I've submitted a patch that does that, and my understanding is that so
did you (I didn't yet take a look -- sorry. I definitely intend to).

I just remarked that I haven't noticed a problem with character erase.
I have no idea why.

Lubo